Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-11 Thread Rafael J. Wysocki
On Friday, 11 of January 2008, Shaohua Li wrote: > > On Fri, 2008-01-11 at 07:39 +0800, Rafael J. Wysocki wrote: > > On Monday, 7 of January 2008, Shaohua Li wrote: > > > > > > On Sat, 2008-01-05 at 04:44 +0800, Rafael J. Wysocki wrote: > > > > On Friday, 4 of January 2008, Shaohua Li wrote: > > >

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-10 Thread Shaohua Li
On Fri, 2008-01-11 at 07:39 +0800, Rafael J. Wysocki wrote: > On Monday, 7 of January 2008, Shaohua Li wrote: > > > > On Sat, 2008-01-05 at 04:44 +0800, Rafael J. Wysocki wrote: > > > On Friday, 4 of January 2008, Shaohua Li wrote: > > > > > > > > On Fri, 2008-01-04 at 01:04 +0800, Rafael J. Wysoc

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-10 Thread Rafael J. Wysocki
On Monday, 7 of January 2008, Shaohua Li wrote: > > On Sat, 2008-01-05 at 04:44 +0800, Rafael J. Wysocki wrote: > > On Friday, 4 of January 2008, Shaohua Li wrote: > > > > > > On Fri, 2008-01-04 at 01:04 +0800, Rafael J. Wysocki wrote: > > > > On Thursday, 3 of January 2008, Shaohua Li wrote: > >

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-06 Thread Shaohua Li
On Sat, 2008-01-05 at 04:44 +0800, Rafael J. Wysocki wrote: > On Friday, 4 of January 2008, Shaohua Li wrote: > > > > On Fri, 2008-01-04 at 01:04 +0800, Rafael J. Wysocki wrote: > > > On Thursday, 3 of January 2008, Shaohua Li wrote: > > > > > > > > On Wed, 2008-01-02 at 22:05 +0800, Rafael J. Wys

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-04 Thread Rafael J. Wysocki
On Friday, 4 of January 2008, Shaohua Li wrote: > > On Fri, 2008-01-04 at 01:04 +0800, Rafael J. Wysocki wrote: > > On Thursday, 3 of January 2008, Shaohua Li wrote: > > > > > > On Wed, 2008-01-02 at 22:05 +0800, Rafael J. Wysocki wrote: > > > > On Wednesday, 2 of January 2008, Shaohua Li wrote: >

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Shaohua Li
On Fri, 2008-01-04 at 01:04 +0800, Rafael J. Wysocki wrote: > On Thursday, 3 of January 2008, Shaohua Li wrote: > > > > On Wed, 2008-01-02 at 22:05 +0800, Rafael J. Wysocki wrote: > > > On Wednesday, 2 of January 2008, Shaohua Li wrote: > > > > ACPI defines a hardware signature. BIOS calculates th

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Thursday, 3 of January 2008, Nigel Cunningham wrote: >> Hi. >> >> Rafael J. Wysocki wrote: I suppose we can always disable this when we start to support hardware changing over hibernate (I have ideas in this direction - memory cold plugging, for a s

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Rafael J. Wysocki
On Thursday, 3 of January 2008, Shaohua Li wrote: > > On Wed, 2008-01-02 at 22:05 +0800, Rafael J. Wysocki wrote: > > On Wednesday, 2 of January 2008, Shaohua Li wrote: > > > ACPI defines a hardware signature. BIOS calculates the signature > > > according to hardware configure, if hardware changes

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Rafael J. Wysocki
On Thursday, 3 of January 2008, Nigel Cunningham wrote: > Hi. > > Rafael J. Wysocki wrote: > >> I suppose we can always disable this when we start to support hardware > >> changing over hibernate (I have ideas in this direction - memory cold > >> plugging, for a start). > > > > Well, if we suppor

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: >> I suppose we can always disable this when we start to support hardware >> changing over hibernate (I have ideas in this direction - memory cold >> plugging, for a start). > > Well, if we support such features, we won't be following ACPI any more. Mmm. Apparently I

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-03 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: Is there another mechanism preventing this? >>> Not at the kernel level, but you can prevent this from happening by running >>> mkswap on all swap spaces that refuse to come up after a fresh boot. >> We really should do something about this. It should be possible

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Shaohua Li
On Wed, 2008-01-02 at 22:05 +0800, Rafael J. Wysocki wrote: > On Wednesday, 2 of January 2008, Shaohua Li wrote: > > ACPI defines a hardware signature. BIOS calculates the signature > > according to hardware configure, if hardware changes, the signature > will > > change, in this case, S4 resume s

Re: [linux-pm] [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Shaohua Li
On Wed, 2008-01-02 at 17:29 +0800, Johannes Berg wrote: > > Once reading the ACPI spec I noticed that ACPI supports this feature > > so it is qute nice to implement it, since this will prevent resume from > > disk what hardware was changed. > > > > But.. how many bioses are broken regarding this

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Rafael J. Wysocki
On Wednesday, 2 of January 2008, Nigel Cunningham wrote: > Hi. > > Rafael J. Wysocki wrote: > > On Wednesday, 2 of January 2008, Erik Andrén wrote: > >> Hi, > >> > >> 2008/1/2, Shaohua Li <[EMAIL PROTECTED]>: > >>> ACPI defines a hardware signature. BIOS calculates the signature > >>> according to

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Rafael J. Wysocki
On Wednesday, 2 of January 2008, Nigel Cunningham wrote: > Hi. > > Rafael J. Wysocki wrote: > > On Wednesday, 2 of January 2008, Shaohua Li wrote: > >> ACPI defines a hardware signature. BIOS calculates the signature > >> according to hardware configure, if hardware changes, the signature will > >

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Wednesday, 2 of January 2008, Shaohua Li wrote: >> ACPI defines a hardware signature. BIOS calculates the signature >> according to hardware configure, if hardware changes, the signature will >> change, in this case, S4 resume should fail. > > The idea is fine, b

Re: [linux-pm] Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Wednesday, 2 of January 2008, Erik Andrén wrote: >> Hi, >> >> 2008/1/2, Shaohua Li <[EMAIL PROTECTED]>: >>> ACPI defines a hardware signature. BIOS calculates the signature >>> according to hardware configure, if hardware changes, the signature will >>> change, in

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Rafael J. Wysocki
On Wednesday, 2 of January 2008, Erik Andrén wrote: > Hi, > > 2008/1/2, Shaohua Li <[EMAIL PROTECTED]>: > > > > ACPI defines a hardware signature. BIOS calculates the signature > > according to hardware configure, if hardware changes, the signature will > > change, in this case, S4 resume should f

Re: [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Rafael J. Wysocki
On Wednesday, 2 of January 2008, Shaohua Li wrote: > ACPI defines a hardware signature. BIOS calculates the signature > according to hardware configure, if hardware changes, the signature will > change, in this case, S4 resume should fail. The idea is fine, but I'd prefer to do that in a more stra

Re: [linux-pm] [patch] hibernation: utilize ACPI hardware signature

2008-01-02 Thread Johannes Berg
> Once reading the ACPI spec I noticed that ACPI supports this feature > so it is qute nice to implement it, since this will prevent resume from disk > what hardware was changed. > > But.. how many bioses are broken regarding this feature If they are broken though, how likely is it they'll

Re: [linux-pm] [patch] hibernation: utilize ACPI hardware signature

2008-01-01 Thread Maxim Levitsky
On Wednesday, 2 January 2008 08:59:22 Shaohua Li wrote: > ACPI defines a hardware signature. BIOS calculates the signature > according to hardware configure, if hardware changes, the signature will > change, in this case, S4 resume should fail. > > Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> > -

[patch] hibernation: utilize ACPI hardware signature

2008-01-01 Thread Shaohua Li
ACPI defines a hardware signature. BIOS calculates the signature according to hardware configure, if hardware changes, the signature will change, in this case, S4 resume should fail. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/acpi/sleep/main.c | 13 + include/linux/su