Re: brightness control on thinkpad t61p

2008-01-08 Thread Henrique de Moraes Holschuh
On Tue, 08 Jan 2008, Matthew Garrett wrote: On Mon, Jan 07, 2008 at 10:32:46PM -0200, Henrique de Moraes Holschuh wrote: Should we? Why? We lose information doing that. Instead of a nice linear 0-100% brightness scale, you are now back to an 8 or 16-level non-linear brightness scale.

Re: brightness control on thinkpad t61p

2008-01-08 Thread Matthew Garrett
On Tue, Jan 08, 2008 at 10:06:53AM -0200, Henrique de Moraes Holschuh wrote: Is there a *real* technical reason why we can't just round to the nearest? That will work well with any firmware, and it will not remove functionality from any box, while at the same time plugging the current issues

Re: brightness control on thinkpad t61p

2008-01-08 Thread Henrique de Moraes Holschuh
On Tue, 08 Jan 2008, Matthew Garrett wrote: On Tue, Jan 08, 2008 at 10:06:53AM -0200, Henrique de Moraes Holschuh wrote: Is there a *real* technical reason why we can't just round to the nearest? That will work well with any firmware, and it will not remove functionality from any box, while

Re: brightness control on thinkpad t61p

2008-01-08 Thread Matthew Garrett
On Tue, Jan 08, 2008 at 10:48:20AM -0200, Henrique de Moraes Holschuh wrote: Heck, back to the video.c driver, you shouldn't even assume _BCL gives you a sorted list after the second element. I admit it takes an special kind of weird firmware to screw with _BCL like that, but the ACPI spec

Re: brightness control on thinkpad t61p

2008-01-08 Thread Matthew Garrett
On Tue, Jan 08, 2008 at 03:45:02PM +, Richard Purdie wrote: I did't get enough context above but I went through the archives and it seems this is about linearising backlight values. Indeed. The ACPI spec provides a range of 0-100, without specifying what this actually means (it gives

Re: brightness control on thinkpad t61p

2008-01-08 Thread Richard Purdie
On Tue, 2008-01-08 at 10:48 -0200, Henrique de Moraes Holschuh wrote: On Tue, 08 Jan 2008, Matthew Garrett wrote: On Tue, Jan 08, 2008 at 10:06:53AM -0200, Henrique de Moraes Holschuh wrote: Is there a *real* technical reason why we can't just round to the nearest? That will work well

Re: brightness control on thinkpad t61p

2008-01-08 Thread Richard Purdie
On Tue, 2008-01-08 at 15:54 +, Matthew Garrett wrote: On Tue, Jan 08, 2008 at 03:45:02PM +, Richard Purdie wrote: I did't get enough context above but I went through the archives and it seems this is about linearising backlight values. Indeed. The ACPI spec provides a range of

Re: brightness control on thinkpad t61p

2008-01-08 Thread Henrique de Moraes Holschuh
On Tue, 08 Jan 2008, Richard Purdie wrote: On Tue, 2008-01-08 at 15:54 +, Matthew Garrett wrote: On Tue, Jan 08, 2008 at 03:45:02PM +, Richard Purdie wrote: I did't get enough context above but I went through the archives and it seems this is about linearising backlight values.

Re: brightness control on thinkpad t61p

2008-01-08 Thread Richard Purdie
On Tue, 2008-01-08 at 14:49 -0200, Henrique de Moraes Holschuh wrote: On Tue, 08 Jan 2008, Richard Purdie wrote: On Tue, 2008-01-08 at 15:54 +, Matthew Garrett wrote: On Tue, Jan 08, 2008 at 03:45:02PM +, Richard Purdie wrote: I did't get enough context above but I went

Re: brightness control on thinkpad t61p

2008-01-08 Thread Henrique de Moraes Holschuh
On Tue, 08 Jan 2008, Richard Purdie wrote: So be it, then. But my request that we get a way to add the information we are losing to the backlight class still stands. The thing is does this 0-100 value have a use to userspace? Its You can request something like middle brightness please

Re: brightness control on thinkpad t61p

2008-01-07 Thread Matthew Garrett
On Sun, Jan 06, 2008 at 11:36:23PM -0200, Henrique de Moraes Holschuh wrote: Bah, I spoke too soon. Latest round of BIOSes seems to have broken this, either that or I completely misunderstood the older AML code. Rounding to the nearest supplied _BCL value before we call _BCM apparently

Re: brightness control on thinkpad t61p

2008-01-07 Thread Henrique de Moraes Holschuh
On Mon, 07 Jan 2008, Matthew Garrett wrote: On Sun, Jan 06, 2008 at 11:36:23PM -0200, Henrique de Moraes Holschuh wrote: Bah, I spoke too soon. Latest round of BIOSes seems to have broken this, either that or I completely misunderstood the older AML code. Rounding to the nearest

Re: brightness control on thinkpad t61p

2008-01-06 Thread Henrique de Moraes Holschuh
On Thu, 27 Dec 2007, Henrique de Moraes Holschuh wrote: On Wed, 26 Dec 2007, Matthew Garrett wrote: On Wed, Dec 26, 2007 at 02:10:27PM -0800, Andrew Morton wrote: Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work, but its interface vanished in 2.6.24-rc5 and the acpi

Re: brightness control on thinkpad t61p

2007-12-27 Thread Henrique de Moraes Holschuh
On Wed, 26 Dec 2007, Matthew Garrett wrote: On Wed, Dec 26, 2007 at 02:10:27PM -0800, Andrew Morton wrote: Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work, but its interface vanished in 2.6.24-rc5 and the acpi driver does not work. As I said, the interface for the

Re: brightness control on thinkpad t61p

2007-12-27 Thread Henrique de Moraes Holschuh
On Wed, 26 Dec 2007, Andrew Morton wrote: Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work, but its interface vanished in 2.6.24-rc5 and the acpi driver does not work. As I said, give thinkpad-acpi the brightness_enable=1 parameter, and it will export its backlight interface,

Re: brightness control on thinkpad t61p

2007-12-27 Thread Henrique de Moraes Holschuh
On Wed, 26 Dec 2007, Andrew Morton wrote: For thinkpad-acpi at least, it is not a regression. 2.6.23/0.16 did NOT support your thinkpad (it will pretend to work, but it won't work 100% right as it only supports 8 levels of backlight control). Well it may have been partially working, but

Re: brightness control on thinkpad t61p

2007-12-26 Thread Matthew Garrett
On Wed, Dec 26, 2007 at 02:10:27PM -0800, Andrew Morton wrote: Vice versa for me. The thinkpad_acpi driver in 2.6.23 _does_ work, but its interface vanished in 2.6.24-rc5 and the acpi driver does not work. As I said, the interface for the ACPI backlight driver is confusing. 10 will only

Re: brightness control on thinkpad t61p

2007-12-26 Thread Andrew Morton
On Mon, 24 Dec 2007 15:08:37 -0200 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Sun, 23 Dec 2007, Andrew Morton wrote: When I fire up the latest Linus tree on my thinkpad t61p I get: thinkpad_acpi: ThinkPad ACPI Extras v0.17 thinkpad_acpi: http://ibm-acpi.sf.net/

Re: brightness control on thinkpad t61p

2007-12-26 Thread Andrew Morton
On Mon, 24 Dec 2007 07:34:06 + Matthew Garrett [EMAIL PROTECTED] wrote: On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote: and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so my `brightness' script no longer works. That, my friends, is a

Re: brightness control on thinkpad t61p

2007-12-24 Thread Henrique de Moraes Holschuh
On Sun, 23 Dec 2007, Andrew Morton wrote: When I fire up the latest Linus tree on my thinkpad t61p I get: thinkpad_acpi: ThinkPad ACPI Extras v0.17 thinkpad_acpi: http://ibm-acpi.sf.net/ thinkpad_acpi: ThinkPad BIOS 7LET44WW (1.14 ), EC 7KHT22WW-1.06 thinkpad_acpi: Lenovo ThinkPad T61p

Re: brightness control on thinkpad t61p

2007-12-24 Thread Henrique de Moraes Holschuh
On Mon, 24 Dec 2007, Matthew Garrett wrote: On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote: and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so my `brightness' script no longer works. That, my friends, is a regression. The thinkpad_acpi brightness

brightness control on thinkpad t61p

2007-12-23 Thread Andrew Morton
When I fire up the latest Linus tree on my thinkpad t61p I get: thinkpad_acpi: ThinkPad ACPI Extras v0.17 thinkpad_acpi: http://ibm-acpi.sf.net/ thinkpad_acpi: ThinkPad BIOS 7LET44WW (1.14 ), EC 7KHT22WW-1.06 thinkpad_acpi: Lenovo ThinkPad T61p thinkpad_acpi: radio switch found; radios are

Re: brightness control on thinkpad t61p

2007-12-23 Thread Rafael J. Wysocki
On Sunday, 23 of December 2007, Andrew Morton wrote: When I fire up the latest Linus tree on my thinkpad t61p I get: thinkpad_acpi: ThinkPad ACPI Extras v0.17 thinkpad_acpi: http://ibm-acpi.sf.net/ thinkpad_acpi: ThinkPad BIOS 7LET44WW (1.14 ), EC 7KHT22WW-1.06 thinkpad_acpi: Lenovo

Re: brightness control on thinkpad t61p

2007-12-23 Thread Matthew Garrett
On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote: and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so my `brightness' script no longer works. That, my friends, is a regression. The thinkpad_acpi brightness interface simply doesn't work correctly on