On Mon, 2008-02-25 at 11:15 +0100, Ingo Molnar wrote:
> * Yi Yang <[EMAIL PROTECTED]> wrote:
>
> > cpuidle C-state sysfs node time and usage are very easy to overflow
> > because they are all of unsigned int type, time will overflow within
> > about two hours,
* Yi Yang <[EMAIL PROTECTED]> wrote:
> cpuidle C-state sysfs node time and usage are very easy to overflow
> because they are all of unsigned int type, time will overflow within
> about two hours, usage will take longer time to overflow, but they are
> increasing for eve
cpuidle C-state sysfs node time and usage are very easy to overflow because
they are all of unsigned int type, time will overflow within about two hours,
usage will take longer time to overflow, but they are increasing for ever.
This patch will convert them to unsigned long long.
Signed-off-by
From: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Documentation for cpuidle infrastructure. (resend)
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Reviewed-by: Randy Dunlap <[EMAIL PROTECTED]>
Signed-off-by: Len Brown <[EMAIL PROTECTED]>
---
Documentation/00-
From: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Add a new sysfs entry under cpuidle states. desc - can be used by driver to
communicate to userspace any specific information about the state.
This helps in identifying the exact hardware C-states behind the ACPI C-state
definition.
Idea is to
Since this is cumulative time in usecs, increase to a 64-bit value.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
---
drivers/cpuidle/sysfs.c |6 +-
include/linux/cpuidle.h |2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/sysfs.c b/d
Y
def_bool y
Index: linux-2.6.25-rc/drivers/cpuidle/cpuidle.c
===
--- linux-2.6.25-rc.orig/drivers/cpuidle/cpuidle.c
+++ linux-2.6.25-rc/drivers/cpuidle/cpuidle.c
@@ -27,6 +27,17 @@ static void (*pm_idle_old)(void);
static
On Thursday 07 February 2008 05:27, Ingo Molnar wrote:
>
> * Len Brown <[EMAIL PROTECTED]> wrote:
>
> > From: Len Brown <[EMAIL PROTECTED]>
> >
> > This reverts commit f757397097d0713c949af76dccabb65a2785782e.
> > which ironically broke the ia64 build
>
> hm, this seems to be an internal ACPI c
* Len Brown <[EMAIL PROTECTED]> wrote:
> From: Len Brown <[EMAIL PROTECTED]>
>
> This reverts commit f757397097d0713c949af76dccabb65a2785782e.
> which ironically broke the ia64 build
hm, this seems to be an internal ACPI commit - why not eliminate both
commits (the broken one and the revert on
From: Len Brown <[EMAIL PROTECTED]>
This reverts commit f757397097d0713c949af76dccabb65a2785782e.
which ironically broke the ia64 build
---
arch/x86/Kconfig |3 ---
drivers/cpuidle/cpuidle.c |2 +-
include/linux/cpuidle.h | 13 -
3 files changed, 1 inse
arch/x86/Kconfig |3 +++
drivers/acpi/processor_idle.c | 4 +++-
drivers/cpuidle/cpuidle.c | 41 +
include/linux/cpuidle.h | 13 ++---
4 files changed, 57 insertions(+), 4 deletions(-)
diff --git a/arch/x86/Kconfig
From: [EMAIL PROTECTED] <[EMAIL PROTECTED]>
Show C1 idle time in /sysfs cpuidle interface. C1 idle time may not
be entirely accurate in all cases. It includes the time spent
in the interrupt handler after wakeup with "hlt" based C1. But, it will
be accurate with "mwait"
<[EMAIL PROTECTED]>
Signed-off-by: Len Brown <[EMAIL PROTECTED]>
---
arch/x86/Kconfig |3 +++
drivers/cpuidle/cpuidle.c |2 +-
include/linux/cpuidle.h | 13 +
3 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/
From: Len Brown <[EMAIL PROTECTED]>
Start with default value of 6, so by default,
there is no functional change in this patch.
Signed-off-by: Len Brown <[EMAIL PROTECTED]>
---
drivers/acpi/processor_idle.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/
From: Len Brown <[EMAIL PROTECTED]>
More aggressively request deep C-states.
Note that the job of the OS is to minimize latency
impact to expected break events such as interrupts.
It is not the job of the OS to try to calculate if
the C-state will reach energy break-even.
The platform doesn't gi
device *dev = &pr->power.dev;
> @@ -1659,6 +1659,8 @@ static int acpi_processor_setup_cpuidle(
> }
>
> count++;
> + if (count == CPUIDLE_STATE_MAX)
> + break;
> }
. Please define "confuses"?
>
> > $ ls -lR /sys/devices/system/cpu/
> >
> > gives :
> >
> > /sys/devices/system/cpu/:
> > total 0
> > drwxr-xr-x 4 root root 0 Jan 30 09:36 cpu0
> > drwxr-xr-x 2 root root 0 Jan 30 09:36 cpuidle
>
> gives :
>
> /sys/devices/system/cpu/:
> total 0
> drwxr-xr-x 4 root root 0 Jan 30 09:36 cpu0
> drwxr-xr-x 2 root root 0 Jan 30 09:36 cpuidle
>
> /sys/devices/system/cpu/cpu0:
> total 0
> drwxr-xr-x 3 root root 0 Jan 30 09:36 cpufreq
> drwxr-xr-x 5 root root 0 Jan
> > +++ b/arch/x86/Kconfig
> > @@ -105,6 +105,9 @@ config ARCH_HAS_ILOG2_U32
> > config ARCH_HAS_ILOG2_U64
> > def_bool n
> >
> > +config ARCH_HAS_CPU_IDLE_WAIT
> > + def_bool y
> > +
> > config GENERIC_CALIBRATE_DELAY
> > de
+ def_bool y
> +
> config GENERIC_CALIBRATE_DELAY
> def_bool y
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index d2fabe7..794962d 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -82,7 +82,7 @@ void
if (count == CPUIDLE_STATE_MAX)
+ break;
}
dev->state_count = count;
Index: linux-2.6.25-rc/drivers/cpuidle/cpuidle.c
===
--- linux-2.6.25-rc.orig/drivers/cpuidle/cpuidle.c
+++ linux-2.6.25-rc
config
+++ b/arch/x86/Kconfig
@@ -105,6 +105,9 @@ config ARCH_HAS_ILOG2_U32
config ARCH_HAS_ILOG2_U64
def_bool n
+config ARCH_HAS_CPU_IDLE_WAIT
+ def_bool y
+
config GENERIC_CALIBRATE_DELAY
def_bool y
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index d
ng List
> >Subject: Re: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
> >
> >[ Another update based on Rafael's suggestions. ]
> >
> >Convert cpu_idle_wait() to cpuidle_kick_cpus() macro which is
> >SMP-only, and gives error on non supported CPU.
>
>-Original Message-
>From: Kevin Hilman [mailto:[EMAIL PROTECTED]
>Sent: Thursday, January 31, 2008 1:34 PM
>To: Rafael J. Wysocki
>Cc: Pallipadi, Venkatesh; Len Brown; ACPI Devel Maling List
>Subject: Re: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
>
>[
00644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -105,6 +105,9 @@ config ARCH_HAS_ILOG2_U32
config ARCH_HAS_ILOG2_U64
def_bool n
+config ARCH_HAS_CPU_IDLE_WAIT
+ def_bool y
+
config GENERIC_CALIBRATE_DELAY
def_bool y
diff --git a/drivers/cpuidle/cpuidle.c b/driv
gt;
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index d2fabe7..794962d 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -82,7 +82,7 @@ void cpuidle_uninstall_idle_handler(void)
> {
> if (enabled_devices &&
[ Updated with suggestions from Rafael ]
Convert cpu_idle_wait() to cpuidle_kick_cpus() macro which is
SMP-only, and gives error on non supported CPU.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index d2fabe7..794962d
D]>
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index d2fabe7..762d878 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -18,6 +18,14 @@
>
> #include "cpuidle.h"
>
> +#if !defined(CONFIG_SMP)
&
Len,
Please include this along with your other cpuidle patches for 2.6.25.
Thanks,
Venki
Acked-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
>-Original Message-
>From: Kevin Hilman [mailto:[EMAIL PROTECTED]
>Sent: Thursday, January 31, 2008 12:06 PM
>To: Pallipadi,
[Updated patch pased on suggestions from Venkatesh.]
Convert cpu_idle_wait() to cpuidle_kick_cpus() macro which is
SMP-only, and gives error on non supported CPU.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index d
>-Original Message-
>From: Kevin Hilman [mailto:[EMAIL PROTECTED]
>Sent: Thursday, January 31, 2008 10:51 AM
>To: Pallipadi, Venkatesh
>Cc: Len Brown; ACPI Devel Maling List
>Subject: Re: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
>
>"Pallipadi,
"Pallipadi, Venkatesh" <[EMAIL PROTECTED]> writes:
>> Wrap cpu_idle_wait() in an x86 #ifdef since it's x86 only.
>> Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
>>
>> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
>&g
>-Original Message-
>From: Rafael J. Wysocki [mailto:[EMAIL PROTECTED]
>Sent: Wednesday, January 30, 2008 2:17 AM
>To: Len Brown
>Cc: ACPI Devel Maling List; Pallipadi, Venkatesh; Kevin Hilman
>Subject: Fwd: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
>
On systems without ACPI, query the CPUidle sysfs interface for C-state
details. It uses the CPUIdle stateN/usage and stateN/time files for
the 'usage' and 'duration' values used for calculations in powertop.
For now, if both ACPI and CPUidle are present, it will read data
Hi,
Please have a look at this.
Rafael
--- Begin Message ---
Wrap cpu_idle_wait() in an x86 #ifdef since it's x86 only.
Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]>
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index d2fabe7..4d0f9b0 100644
--- a/driv
actual suspend/resume process anyway, deep C-states
were disabled via the addition of .suspend/.resume hooks
in to the ACPI processor driver.
Here that workaround is ported to the cpuidle version of
the ACPI idle loop. Technically, ACPI could un-register
itself from cpuidle on .suspend, but tha
the addition of .suspend/.resume hooks
> in to the ACPI processor driver.
>
> Here that workaround is ported to the cpuidle version of
> the ACPI idle loop. Technically, ACPI could un-register
> itself from cpuidle on .suspend, but that code path
> is currently quite cumbersome. S
actual suspend/resume process anyway, deep C-states
were disabled via the addition of .suspend/.resume hooks
in to the ACPI processor driver.
Here that workaround is ported to the cpuidle version of
the ACPI idle loop. Technically, ACPI could un-register
itself from cpuidle on .suspend, but tha
From: Len Brown <[EMAIL PROTECTED]>
per 3ebcd8868cfd953cb95777cdfa65effa3756c941
(ACPI: idle: delete access to ACPI_BITREG_BUS_MASTER_RLD)
delete this code, and the port of it to cpuidle.
Signed-off-by: Len Brown <[EMAIL PROTECTED]>
---
drivers/acpi/processor_i
From: Len Brown <[EMAIL PROTECTED]>
Reduces the cpuidle processor_idle.c diff vs 2.6.22 from this
processor_idle.c | 2006 ++-
1 file changed, 1219 insertions(+), 787 deletions(-)
to this:
processor_idle.c
> -acpi-suspend-consolidate-handling-of-sx-states.patch
> -acpi-suspend-consolidate-handling-of-sx-states-addendum.patch
Those two went to Linus Saturday morning.
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo i
On Sun, 23 Sep 2007 22:28:30 -0400 Len Brown <[EMAIL PROTECTED]> wrote:
> On Sunday 23 September 2007 20:57, Andrew Morton wrote:
> >
> > Whaaaaa? Seems that the cpuidle patches all got dropped, but the x86_64
> > dynticks patches were fairly heavily dependent upon t
On Sunday 23 September 2007 20:57, Andrew Morton wrote:
>
> Wha? Seems that the cpuidle patches all got dropped, but the x86_64
> dynticks patches were fairly heavily dependent upon them. (iow: I'm
> screwed).
>
> I can go back to the old version of git-acpi
ded for default policy of cpuidle. That way users will not be able to
> have cpuidle without any policy loosing all C-state power savings.
>
> Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
>
> I
Behalf Of Venki Pallipadi
Sent: Thursday, September 13, 2007 1:39 PM
To: Brown, Len
Cc: linux-acpi@vger.kernel.org; [EMAIL PROTECTED]
Subject: [PATCH] Configure cpuidle governors by default
Quoting Len "Do not give an option to users to shoot themselves in the
foot".
Remove th
Quoting Len "Do not give an option to users to shoot themselves in the foot".
Remove the configurability of ladder and menu governors as they are
needed for default policy of cpuidle. That way users will not be able to
have cpuidle without any policy loosing all C-state power saving
On 09/04/2007 05:43 PM, Len Brown wrote:
> On Tuesday 04 September 2007 16:47, Chuck Ebbert wrote:
>> A look at the 'cpuidle' branch of git-acpi shows a commit
>> e40cede7d63a029e92712a3fe02faee60cc38fb4, "cpuidle: first
>> round of documentation updates&quo
On Tuesday 04 September 2007 16:47, Chuck Ebbert wrote:
> A look at the 'cpuidle' branch of git-acpi shows a commit
> e40cede7d63a029e92712a3fe02faee60cc38fb4, "cpuidle: first
> round of documentation updates" that doesn't show up in that
> branch online. The e
* Len Brown <[EMAIL PROTECTED]> wrote:
> acpi_state_timer_broadcast(pr, cx, 0);
> - cx->time += ticks_elapsed(t1, t2);
> +
> + /* Do not account our idle-switching overhead: */
> + sleep_ticks -= cx->latency_ticks + C2_OVERHEAD;
> +
> + cx->time += sleep_ticks;
the schedule
Ingo, Thomas, Venki, Adam,
Ingo sent some sched hooks to acpi_processor_idle() upstream.
As the cpuidle in the acpi test branch deleted this function,
that results in a merge conflict.
The patch below should resolve the conflict -- but to be honest
I'm pretty zonked right now and could
This patch removes cpuidle_get_bm_activity() and updates governors
accordingly.
Please Apply,
Adam
Change Summary:
drivers/cpuidle/driver.c | 13 --
drivers/cpuidle/governors/ladder.c | 46 -
drivers/cpuidle/governors/menu.c | 26
This patch changes the registration return codes for when CPUIDLE
support is not compiled into the kernel. As a result, the ACPI
processor driver will load properly even if CPUIDLE is unavailable.
However, it may be possible to cleanup the ACPI processor driver further
and eliminate some dead
Currently max_cstate is limited to 0, resulting in no idle processor
power management on ACPI platforms. This patch restores the value to
the array size.
Please Apply,
Adam
Change Summary:
processor_idle.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff -urN a/drivers/acpi/pr
This patch updates the ACPI processor driver to detect BM activity and
limit state entry depth internally, rather than exposing such
requirements to CPUIDLE. As a result, CPUIDLE can drop this
ACPI-specific interface and become more platform independent. BM
activity is now handled much more
This patch allows the "current_governor" sysfs entry to properly handle
input terminated with '\n'.
Please Apply,
Adam
Change Summary:
sysfs.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
---
diff -urN a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/s
Change Summary:
menu.c | 46 +-
1 file changed, 29 insertions(+), 17 deletions(-)
---
diff -urN a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
--- a/drivers/cpuidle/governors/menu.c 2007-08-13 00:02:10.0 -0400
+++ b
Hi Len,
The following CPUIDLE patches apply against the ACPI test tree. Please
let me know if you have any questions or comments.
Thanks,
Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
Hi!
> Documentation changes based on Pavel's feedback.
Thanks!
> -System global cpuidle information are under
> +System global cpuidle related information and tunables are under
> /sys/devices/system/cpu/cpuidle
>
> The current interfaces in this directory has
inux-2.6.22-rc4-mm2/drivers/cpuidle/governors/menu.c.old 2007-06-13
00:25:03.0 +0200
+++ linux-2.6.22-rc4-mm2/drivers/cpuidle/governors/menu.c 2007-06-13
00:25:13.0 +0200
@@ -123,7 +123,7 @@
data->deepest_bm_state = i - 1;
}
-struct cpuidle_governor me
On Wed, Jun 06, 2007 at 01:56:41PM -0700, Venki Pallipadi wrote:
>
>
> Documentation changes based on Pavel's feedback.
Can you also update Documentation/00-INDEX file please.
-Anil
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECT
Documentation changes based on Pavel's feedback.
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc-mm/Documentation/cpuidle/sysfs.txt
===
--- linux-2.6.22-rc-mm.orig/Documentation/cpuidl
signed intrating;
int (*init)(struct cpuidle_device *dev);
void (*exit)(struct cpuidle_device *dev);
Index: linux-2.6.22-rc-mm/drivers/cpuidle/governors/menu.c
===
--- linux-2.6
ipadi <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc-mm/drivers/cpuidle/governors/menu.c
===
--- linux-2.6.22-rc-mm.orig/drivers/cpuidle/governors/menu.c2007-06-05
09:39:27.0 -0700
+++ linux-2.6.22-rc-mm/drivers/cpuidl
Make default cpuidle sysfs to show current_governor and current_driver in
read-only mode. More elaborate available_governors and available_drivers with
writeable current_governor and current_driver interface only appear with
"cpuidle_sysfs_switch" boot parameter.
Signed-off-by:
Fix the uninitialized usage of ret.
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc-mm/drivers/cpuidle/sysfs.c
===
--- linux-2.6.22-rc-mm.orig/drivers/cpuidle/sysfs.c 2007-06-04
Keep /proc/acpi/processor/CPU*/power around for a while as powertop depends
on it. It will be marked deprecated and removed in future. powertop can use
cpuidle interfaces instead.
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc-mm/drivers/acpi/processor_
Compile fix for menu governor.
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc-mm/drivers/cpuidle/governors/menu.c
===
--- linux-2.6.22-rc-mm.orig/drivers/cpuidle/governors/menu.c2007-06-01
Len,
Following are a bunch of small changes to cpuidle trying to prepare it
for mainline. Some of the changes are just the compile timer errors/warnings
and you probably already have them in acpi-test.
Should apply cleanly to latest acpi-test. Please include in acpi-test.
Thanks,
Venki
This
xpects all idle handlers to enable interrupts before returning from
> idle handler. This is due to enter_idle(), exit_idle() races. Make
> cpuidle_idle_call() confirm to this when there is no pm_idle_old.
>
> Also, cpuidle look at the return values of attch_driver() and set
> curren
On Wednesday 25 April 2007 22:40, Shaohua Li wrote:
> resend the three patches per Len's request. No real change except adding
> patch description and diffstat.
Thanks, and next time when you break the text lines to fit into 80 columns,
it will be even better:-)
1,2,3 applied to acpi-test -- thou
On Wednesday 25 April 2007 22:40, Shaohua Li wrote:
> With CPUIDLE framework, the max_cstate (to limit max cpu c-state) parameter
> is ingored. Some systems require it to ignore C2/C3 and some drivers like ipw
> require it too.
>
> Signed-off-by: Shaohua Li &l
races. Make
cpuidle_idle_call() confirm to this when there is no pm_idle_old.
Also, cpuidle look at the return values of attch_driver() and set
current_driver to NULL if attach fails on all CPUs.
Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[
add cpuidle_force_redetect_devices API, which force all CPU redetect idle
states. Next patch will use it.
Signed-off-by: Shaohua Li <[EMAIL PROTECTED]>
---
drivers/acpi/processor_idle.c |3 +-
drivers/cpuidle/driver.c | 56 +++---
include
With CPUIDLE framework, the max_cstate (to limit max cpu c-state) parameter is
ingored. Some systems require it to ignore C2/C3 and some drivers like ipw
require it too.
Signed-off-by: Shaohua Li <[EMAIL PROTECTED]>
---
drivers/acpi/osl.c| 10 ++
driver
resend the three patches per Len's request. No real change except adding
patch description and diffstat.
Fix the cpuidle sysfs issue.
a. make kobject dynamicaly allocated
b. fixed sysfs init issue to avoid suspend/resume issue
Signed-off-by: Shaohua Li <[EMAIL PROTECTED]>
---
d
On Tue, 2007-04-03 at 09:49 +0800, Pallipadi, Venkatesh wrote:
>
> >-Original Message-
> >From: Li, Shaohua
> >Sent: Monday, April 02, 2007 6:34 PM
> >To: Pallipadi, Venkatesh
> >Cc: linux acpi; Brown, Len; Adam Belay
> >Subject: RE: [PATCH] acpi
>-Original Message-
>From: Li, Shaohua
>Sent: Monday, April 02, 2007 6:34 PM
>To: Pallipadi, Venkatesh
>Cc: linux acpi; Brown, Len; Adam Belay
>Subject: RE: [PATCH] acpi cpuidle driver should handle max_cstate
>
>On Tue, 2007-04-03 at 00:44 +0800, Pallipadi, V
On Tue, 2007-04-03 at 00:44 +0800, Pallipadi, Venkatesh wrote:
>
> >-Original Message-
> >From: Li, Shaohua
> >Sent: Monday, April 02, 2007 1:38 AM
> >To: linux acpi
> >Cc: Brown, Len; Adam Belay; Pallipadi, Venkatesh
> >Subject: [PATCH] acpi
>-Original Message-
>From: Li, Shaohua
>Sent: Monday, April 02, 2007 1:38 AM
>To: linux acpi
>Cc: Brown, Len; Adam Belay; Pallipadi, Venkatesh
>Subject: [PATCH] acpi cpuidle driver should handle max_cstate
>
>After switching to cpuidle framework, acpi driver ing
After switching to cpuidle framework, acpi driver ingorned max_cstate,
which will break ipw driver. Below patch fixed the issue. It's a little
complicated, but this really should be handled in the driver instead of
cpuidle core. If you have better fix, please speak.
Signed-off-by: Shaoh
On 3/29/07, Ed Sweetman <[EMAIL PROTECTED]> wrote:
NVRM: loading NVIDIA UNIX x86_64 Kernel Module 1.0-9746 Fri Dec 15 10:19:35
PST 2006
PCI: Setting latency timer of device :01:00.0 to 64
NVRM: loading NVIDIA UNIX x86_64 Kernel Module 1.0-9746 Fri Dec 15 10:19:35
PST 2006
**WARNING** I2
applied
thanks,
-len
On Tuesday 27 March 2007 01:38, [EMAIL PROTECTED] wrote:
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> A 1-bit bitfield has no room for a sign bit.
> drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without
> explicit `signed' or
On Mar 27, 2007, at 12:04 PM, Adam Belay wrote:
On Mon, 2007-03-26 at 13:36 +0800, Shaohua Li wrote:
Hi,
On Sat, 2007-03-24 at 03:47 -0400, Adam Belay wrote:
This patch adds the 'menu' governor, as was described in my first
email.
+/**
+ * menu_select - selects the next idle state to en
On Mon, 2007-03-26 at 13:36 +0800, Shaohua Li wrote:
> Hi,
> On Sat, 2007-03-24 at 03:47 -0400, Adam Belay wrote:
> > This patch adds the 'menu' governor, as was described in my first email.
> >
>
> > +/**
> > + * menu_select - selects the next idle state to enter
> > + * @dev: the CPU
> > + */
>
From: Randy Dunlap <[EMAIL PROTECTED]>
A 1-bit bitfield has no room for a sign bit.
drivers/cpuidle/governors/ladder.c:54:16: error: dubious bitfield without
explicit `signed' or `unsigned'
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
Cc: Venkatesh Pallipadi <[EMAIL
Hi,
On Sat, 2007-03-24 at 03:47 -0400, Adam Belay wrote:
> This patch adds the 'menu' governor, as was described in my first email.
>
> +/**
> + * menu_select - selects the next idle state to enter
> + * @dev: the CPU
> + */
> +static int menu_select(struct cpuidle_device *dev)
> +{
> + struc
This patch adds the 'menu' governor, as was described in my first email.
Thanks,
Adam
Kconfig| 11 +++
governors/Makefile |1
governors/menu.c | 152 +
3 files changed, 164 insertions(+)
diff -urN a/drive
This patch prepares cpuidle for the menu governor. It adds an optional
stage after idle state entry to give the governor an opportunity to
check why the state was exited. Also it makes sure the idle loop
returns after each state entry, allowing the appropriate dynticks code
to run.
Thanks,
Adam
red. I would be happy to test any
> > patches, etc.
> >
> > Larry
> >
> > ==
> >
> > The console log ends with the following entries:
> >
> > ACPI: Processor [CPU0] (supports 8 throttling states)
> > AC
>
> The console log ends with the following entries:
>
> ACPI: Processor [CPU0] (supports 8 throttling states)
> ACPI: Processor [CPU1] (supports 8 throttling states)
> cpuidle: driver acpi_idle failed to attach to cpu 0
> cpuidle: driver acpi_idle failed to attach to cpu 0
&g
ing
>
> I don't think you can merge anything anymore with such a FIXME.
Certainly it need to work well with NOHZ before it can go upstream.
Indeed, NOHZ is one of the reasons for doing cpuidle in the first place.
But then NOHZ is probably going to take some time to mature also,
certainly
On 15/03/07, Len Brown <[EMAIL PROTECTED]> wrote:
On Thursday 15 March 2007 09:13, Richard Hughes wrote:
> What about some documentation so that userspace knows what to do with
> this new framework?
What does userspace need to know in addition to what is in
Documentation/cpuidle/
On Thursday 15 March 2007 09:13, Richard Hughes wrote:
> What about some documentation so that userspace knows what to do with
> this new framework?
What does userspace need to know in addition to what is in
Documentation/cpuidle/?
-
To unsubscribe from this list: send the line "
On 10/03/07, Len Brown <[EMAIL PROTECTED]> wrote:
arch/i386/Kconfig |2 +
arch/x86_64/Kconfig|2 +
drivers/Makefile |1 +
drivers/cpuidle/Kconfig| 28 +++
drivers/cpuidle/Makefile |5 +
drivers/c
Len Brown <[EMAIL PROTECTED]> writes:
> +
> +/**
> + * cpuidle_idle_call - the main idle loop
> + *
> + * NOTE: no locks or semaphores should be used here
> + * FIXME: DYNTICKS handling
I don't think you can merge anything anymore with such a FIXME.
Besides cpuid
_device *dev)
+{return 0;}
+
+#endif
/**
* CPUIDLE GOVERNOR INTERFACE *
@@ -153,8 +164,20 @@ struct cpuidle_governor {
struct module *owner;
};
+#ifdef CONFIG_CPU_IDLE
+
extern int cpuidle_register_governor(struct cpuidle_governor *gov);
extern void cpuidle_unregister_g
padi <[EMAIL PROTECTED]>
Cc: Adam Belay <[EMAIL PROTECTED]>
Cc: Shaohua Li <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Len Brown <[EMAIL PROTECTED]>
---
drivers/cpuidle/cpuidle.h |2 --
drivers/cpuidle/driver.c
From: Len Brown <[EMAIL PROTECTED]>
build fix for CONFIG_ACPI=n
In file included from drivers/cpuidle/governors/ladder.c:21:
include/acpi/processor.h:88: error: expected specifier-qualifier-list before
âacpi_integerâ
include/acpi/processor.h:106: error: expected specifier-qualifie
From: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Announcing 'cpuidle', a new CPU power management infrastructure to manage
idle CPUs in a clean and efficient manner.
cpuidle separates out the drivers that can provide support for multiple types
of idle states and policy governors tha
From: Venkatesh Pallipadi <[EMAIL PROTECTED]>
Hookup ACPI C-states onto generic cpuidle infrastructure.
drivers/acpi/procesor_idle.c is now a ACPI C-states driver that registers as
a driver in cpuidle infrastructure and the policy part is removed from
drivers/acpi/processor_idle.c.
1 - 100 of 113 matches
Mail list logo
