Re: [PATCH] mremap: add MREMAP_NOHOLE flag --resend

2015-03-23 Thread Aliaksey Kandratsenka
Hi. On Sun, Mar 22, 2015 at 10:17 PM, Shaohua Li wrote: > On Sat, Mar 21, 2015 at 11:06:14PM -0700, Aliaksey Kandratsenka wrote: >> But now I realize that it is more interesting than that. I.e. because as >> Daniel >> pointed out, mremap holds mmap_sem exclusively, while page faults are >> holdi

Re: [PATCH] mremap: add MREMAP_NOHOLE flag --resend

2015-03-23 Thread Aliaksey Kandratsenka
Hi. First of all, I'd like to apologize for messing up formatting of my past email. I've learned my lesson. On Sun, Mar 22, 2015 at 12:22 AM, Daniel Micay wrote: >> My initial thinking was that we'd likely use mremap in all cases where >> we know >> that touching destination would cause minor pa

Re: [PATCH V2 1/2] af_packet: make tpacket_rcv to not set status value before run_filter

2015-03-23 Thread David Miller
From: Alexander Drozdov Date: Mon, 23 Mar 2015 09:11:12 +0300 > It is just an optimization. We don't need the value of status variable > if the packet is filtered. > > Signed-off-by: Alexander Drozdov Applied to net-next -- To unsubscribe from this list: send the line "unsubscribe linux-api" i

Re: [PATCH V2 2/2] af_packet: pass checksum validation status to the user

2015-03-23 Thread David Miller
From: Alexander Drozdov Date: Mon, 23 Mar 2015 09:11:13 +0300 > Introduce TP_STATUS_CSUM_VALID tp_status flag to tell the > af_packet user that at least the transport header checksum > has been already validated. > > For now, the flag may be set for incoming packets only. > > Signed-off-by: Ale

Re: [PATCH v4 00/14] Add kdbus implementation

2015-03-23 Thread Eric W. Biederman
Andy Lutomirski writes: > On Mon, Mar 23, 2015 at 8:28 AM, David Herrmann wrote: >> Hi >> >> On Thu, Mar 19, 2015 at 4:48 PM, Andy Lutomirski wrote: >>> On Thu, Mar 19, 2015 at 4:26 AM, David Herrmann >>> wrote: >>> But you're comparing to the wrong thing, IMO. Of course it's much >>> faste

Re: [PATCH v4 00/14] Add kdbus implementation

2015-03-23 Thread Andy Lutomirski
On Mon, Mar 23, 2015 at 8:28 AM, David Herrmann wrote: > Hi > > On Thu, Mar 19, 2015 at 4:48 PM, Andy Lutomirski wrote: >> On Thu, Mar 19, 2015 at 4:26 AM, David Herrmann >> wrote: >>> metadata handling is local to the connection that sends the message. >>> It does not affect the overall perfor

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-23 Thread Srinivas Kandagatla
On 23/03/15 21:09, Mark Brown wrote: On Fri, Mar 13, 2015 at 09:50:14AM +, Srinivas Kandagatla wrote: A couple of *very* minor points below, otherwise this looks OK to me. Thankyou for the review. +struct eeprom_device *eeprom_register(struct eeprom_config *config) +{ + struct ee

Re: [PATCH 02/14] twl4030_charger: use devres for power_supply_register and kzalloc.

2015-03-23 Thread Pavel Machek
On Mon 2015-03-23 10:20:28, NeilBrown wrote: > From: NeilBrown > > Final allocations/registrations are now managed by devres. > > Signed-off-by: NeilBrown Patches 1,2: Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni

Re: [PATCH 13/14] twl4030_charger: Increase current carefully while watching voltage.

2015-03-23 Thread Pavel Machek
Hi! > The USB Battery Charging spec (BC1.2) suggests a dedicated > charging port can deliver from 0.5 to 5.0A at between 4.75 and 5.25 > volts. > > To choose the "correct" current voltage setting requires a trial > and error approach: try to draw current and see if the voltage drops > too low. >

Re: [PATCH 0/5] Enhancements to twl4030 phy to support better charging - V2

2015-03-23 Thread Pavel Machek
On Mon 2015-03-23 09:35:23, NeilBrown wrote: > Hi Kishon, > I wonder if you could queue the following for the next merge window. > They allow the twl4030 phy to provide more information to the > twl4030 battery charger. > There are only minimal changes since the first version, particularly > d

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-23 Thread Mark Brown
On Fri, Mar 13, 2015 at 09:50:14AM +, Srinivas Kandagatla wrote: A couple of *very* minor points below, otherwise this looks OK to me. > +struct eeprom_device *eeprom_register(struct eeprom_config *config) > +{ > + struct eeprom_device *eeprom; > + int rval; > + > + if (!config->r

Re: [PATCH v2 01/11] stm class: Introduce an abstraction for System Trace Module devices

2015-03-23 Thread Alexander Shishkin
Mathieu Poirier writes: >> +source "drivers/hwtracing/stm/Kconfig" >> + >> endmenu > > When the coresight framework and drivers were submitted for review > people asked that I move the Kconfig options to > "arch/arm[64]/kernel.debug", resulting in coresight configurable > options showing up unde

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Michael S. Tsirkin
On Mon, Mar 23, 2015 at 04:05:29PM +0100, Gerd Hoffmann wrote: > On Mo, 2015-03-23 at 15:54 +0100, Michael S. Tsirkin wrote: > > On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > > >

Re: [PATCH v10 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

2015-03-23 Thread Alexei Starovoitov
On 3/23/15 5:07 AM, Ingo Molnar wrote: * David Laight wrote: From: Alexei Starovoitov Debugging of BPF programs needs some form of printk from the program, so let programs call limited trace_printk() with %d %u %x %p modifiers only. Should anyone be allowed to use BPF programs to determine

Re: [PATCH v9 tip 8/9] samples: bpf: IO latency analysis (iosnoop/heatmap)

2015-03-23 Thread Alexei Starovoitov
On 3/23/15 12:40 AM, Ingo Molnar wrote: * Alexei Starovoitov wrote: BPF C program attaches to blk_mq_start_request/blk_update_request kprobe events to calculate IO latency. ... +/* kprobe is NOT a stable ABI + * This bpf+kprobe example can stop working any time. + */ +SEC("kprobe/blk_mq

Re: [PATCH v2 7/7] clone4: Add a CLONE_FD flag to get task exit notification via fd

2015-03-23 Thread David Drysdale
On Sun, Mar 15, 2015 at 8:00 AM, Josh Triplett wrote: > diff --git a/include/linux/compat.h b/include/linux/compat.h > index 6c4a68d..c90df5a 100644 > --- a/include/linux/compat.h > +++ b/include/linux/compat.h > @@ -299,6 +299,8 @@ struct compat_clone4_args { > compat_ulong_t stack_start;

Re: [PATCH v9 tip 6/9] samples: bpf: simple non-portable kprobe filter example

2015-03-23 Thread Alexei Starovoitov
On 3/23/15 12:35 AM, Ingo Molnar wrote: * Alexei Starovoitov wrote: +void read_trace_pipe(void) +{ + int trace_fd; + + trace_fd = open(DEBUGFS "trace_pipe", O_RDONLY, 0); + if (trace_fd < 0) + return; + + while (1) { + static char buf[4096];

Re: [PATCH v9 tip 6/9] samples: bpf: simple non-portable kprobe filter example

2015-03-23 Thread Alexei Starovoitov
On 3/23/15 12:29 AM, Ingo Molnar wrote: ** ** ** This means that this is a DEBUG kernel and it is ** ** unsafe for production use. ** But I think printing that it's unsafe for production use is over the top: it

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Cornelia Huck
On Mon, 23 Mar 2015 16:05:29 +0100 Gerd Hoffmann wrote: > On Mo, 2015-03-23 at 15:54 +0100, Michael S. Tsirkin wrote: > > On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > > > virt

Re: [PATCH v4 00/14] Add kdbus implementation

2015-03-23 Thread David Herrmann
Hi On Thu, Mar 19, 2015 at 4:48 PM, Andy Lutomirski wrote: > On Thu, Mar 19, 2015 at 4:26 AM, David Herrmann wrote: >> metadata handling is local to the connection that sends the message. >> It does not affect the overall performance of other bus operations in >> parallel. > > Sure it does if it

Re: [PATCH v2 3/7] Introduce a new clone4 syscall with more flag bits and extensible arguments

2015-03-23 Thread josh
On Mon, Mar 23, 2015 at 02:11:45PM +, David Drysdale wrote: > On Sun, Mar 15, 2015 at 7:59 AM, Josh Triplett wrote: > > diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S > > index 0286735..ba28306 100644 > > --- a/arch/x86/ia32/ia32entry.S > > +++ b/arch/x86/ia32/ia32entry.S >

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Gerd Hoffmann
On Mo, 2015-03-23 at 15:54 +0100, Michael S. Tsirkin wrote: > On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > > >

Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor

2015-03-23 Thread josh
On Mon, Mar 23, 2015 at 02:12:34PM +, David Drysdale wrote: > On Mon, Mar 16, 2015 at 11:29 PM, wrote: > > On Mon, Mar 16, 2015 at 03:14:14PM -0700, Thiago Macieira wrote: > >> On Monday 16 March 2015 14:44:20 Kees Cook wrote: > >> > > O_CLOEXEC > >> > > Set

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Michael S. Tsirkin
On Mon, Mar 23, 2015 at 03:27:35PM +0100, Gerd Hoffmann wrote: > Hi, > > > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > > Just don't go there. > > > So to clarify, you dislike using __virtio32

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Gerd Hoffmann
Hi, > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > Just don't go there. > So to clarify, you dislike using __virtio32 in virtio input header? Well, as I understand things __virtio32 implies byte

Re: [PATCH v2 0/7] CLONE_FD: Task exit notification via file descriptor

2015-03-23 Thread David Drysdale
On Mon, Mar 16, 2015 at 11:29 PM, wrote: > On Mon, Mar 16, 2015 at 03:14:14PM -0700, Thiago Macieira wrote: >> On Monday 16 March 2015 14:44:20 Kees Cook wrote: >> > > O_CLOEXEC >> > > Set the close-on-exec flag on the new file >> > >descriptor. See the descr

Re: [PATCH v2 3/7] Introduce a new clone4 syscall with more flag bits and extensible arguments

2015-03-23 Thread David Drysdale
On Sun, Mar 15, 2015 at 7:59 AM, Josh Triplett wrote: > diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S > index 0286735..ba28306 100644 > --- a/arch/x86/ia32/ia32entry.S > +++ b/arch/x86/ia32/ia32entry.S > @@ -483,6 +483,7 @@ GLOBAL(\label) > PTREGSCALL stub32_execveat,

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Michael S. Tsirkin
On Mon, Mar 23, 2015 at 02:44:52PM +0100, Gerd Hoffmann wrote: > Hi, > > > > At least, this needs a comment explaining what the function does, > > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > > virtio_bitmap_or. > > > > Can do that, sure. > > Well, the function where th

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Gerd Hoffmann
Hi, > > At least, this needs a comment explaining what the function does, > > and maybe wrap it in a helper like virtio_input_bitmap_copy or > > virtio_bitmap_or. > > Can do that, sure. Well, the function where this is in already cares about the bitmap copy only. Can add a comment though. >

Re: [Gta04-owner] [PATCH 08/14] twl4030_charger: allow max_current to be managed via sysfs.

2015-03-23 Thread jake42
Hello Neil, some suggestions: On 23.03.2015 00:20, NeilBrown wrote: From: NeilBrown diff --git a/Documentation/ABI/testing/sysfs-class-power-twl4030 b/Documentation/ABI/testing/sysfs-class-power-twl4030 new file mode 100644 index ..06092209d851 --- /dev/null +++ b/Documentation/ABI

RE: [PATCH v10 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

2015-03-23 Thread David Laight
From: Alexei Starovoitov > Debugging of BPF programs needs some form of printk from the program, > so let programs call limited trace_printk() with %d %u %x %p modifiers only. Should anyone be allowed to use BPF programs to determine the kernel addresses of any items? Looks as though it is leaking

Re: [PATCH v10 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

2015-03-23 Thread Ingo Molnar
* David Laight wrote: > From: Alexei Starovoitov > > Debugging of BPF programs needs some form of printk from the program, > > so let programs call limited trace_printk() with %d %u %x %p modifiers only. > > Should anyone be allowed to use BPF programs to determine the kernel > addresses of any

Re: bpf+tracing next steps. Was: [PATCH v9 tip 3/9] tracing: attach BPF programs to kprobes

2015-03-23 Thread Masami Hiramatsu
(2015/03/23 13:57), Alexei Starovoitov wrote: > On 3/22/15 7:17 PM, Masami Hiramatsu wrote: >> (2015/03/23 3:03), Alexei Starovoitov wrote: >> >>> User space tools that will compile ktap/dtrace scripts into bpf might >>> use build-id for their own purpose, but that's a different discussion. >> >> A

Re: [PATCH 1/1] Add virtio-input driver.

2015-03-23 Thread Gerd Hoffmann
Hi, > > > > + if (cfg & (1 << (bit % 8))) > > > > + set_bit(bit, bits); > > > > > > what if not set? does something clear the mask? > > > > kzalloc? > > So you are really just reading in array of bytes? > All this set bit trickery is just to convert things

Re: [PATCH v9 tip 8/9] samples: bpf: IO latency analysis (iosnoop/heatmap)

2015-03-23 Thread Ingo Molnar
* Alexei Starovoitov wrote: > BPF C program attaches to blk_mq_start_request/blk_update_request kprobe > events > to calculate IO latency. ... > +/* kprobe is NOT a stable ABI > + * This bpf+kprobe example can stop working any time. > + */ > +SEC("kprobe/blk_mq_start_request") > +int bpf_pro

Re: [PATCH v9 tip 0/9] tracing: attach eBPF programs to kprobes

2015-03-23 Thread Ingo Molnar
* Steven Rostedt wrote: > On Fri, 20 Mar 2015 16:30:01 -0700 > Alexei Starovoitov wrote: > > > Hi Ingo, > > > > I think it's good to go. > > Patch 1 is already in net-next. Patch 3 depends on it. > > I'm assuming it's not going to be a problem during merge window. > > Patch 3 will have a mino

Re: [PATCH v9 tip 6/9] samples: bpf: simple non-portable kprobe filter example

2015-03-23 Thread Ingo Molnar
* Alexei Starovoitov wrote: > +void read_trace_pipe(void) > +{ > + int trace_fd; > + > + trace_fd = open(DEBUGFS "trace_pipe", O_RDONLY, 0); > + if (trace_fd < 0) > + return; > + > + while (1) { > + static char buf[4096]; > + ssize_t sz; > + >

Re: [PATCH v9 tip 6/9] samples: bpf: simple non-portable kprobe filter example

2015-03-23 Thread Ingo Molnar
* Alexei Starovoitov wrote: > tracex1_kern.c - C program compiled into BPF. > It attaches to kprobe:netif_receive_skb > When skb->dev->name == "lo", it prints sample debug message into trace_pipe > via bpf_trace_printk() helper function. > > tracex1_user.c - corresponding user space component t