Re: [PATCH v4 02/17] sched_clock: Use seqcount instead of rolling our own

2013-07-19 Thread Will Deacon
On Fri, Jul 19, 2013 at 12:21:15AM +0100, Stephen Boyd wrote: We're going to increase the cyc value to 64 bits in the near future. Doing that is going to break the custom seqcount implementation in the sched_clock code because 64 bit numbers aren't guaranteed to be atomic. Replace the cyc_copy

Re: [PATCH v4 04/17] sched_clock: Add support for 32 bit sched_clock

2013-07-19 Thread Baruch Siach
Hi Stephen, On Thu, Jul 18, 2013 at 04:21:17PM -0700, Stephen Boyd wrote: The ARM architected system counter has at least 56 usable bits. Add support for counters with more than 32 bits to the generic sched_clock implementation so we can increase the time between wakeups due to dealing with

RE: [PATCH V3 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-07-19 Thread Seungwon Jeon
On Thursday, July 18, 2013, Dolev Raviv wrote: Hi, Sorry for the late response. I had a few days off. On Thu, July 11, 2013, Dolev Raviv wrote: On Tuesday, July 09, 2013, Sujit Reddy Thumma wrote: From: Dolev Raviv dra...@codeaurora.org Allow UFS device to complete its

RE: [PATCH V3 1/2] scsi: ufs: Add support for host assisted background operations

2013-07-19 Thread Seungwon Jeon
On Thu, July 18, 2013, Sujit Reddy Thumma wrote: I'm not sure that BKOPS with runtime-pm associates. Do you think it's helpful for power management? How about hibernation scheme for runtime-pm? I'm testing and I can introduce soon. Well, I am thinking on following approach when we

RE: [PATCH V3 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-19 Thread Seungwon Jeon
On Tue, July 09, 2013 Sujit Reddy Thumma wrote: Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: Problem: If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait for one of the

RE: [PATCH V3 3/4] scsi: ufs: Fix device and host reset methods

2013-07-19 Thread Seungwon Jeon
On Tue, July 09, 2013, Sujit Reddy Thumma wrote: As of now SCSI initiated error handling is broken because, the reset APIs don't try to bring back the device initialized and ready for further transfers. In case of timeouts, the scsi error handler takes care of handling aborts and resets.

RE: [PATCH V3 2/4] scsi: ufs: Fix hardware race conditions while aborting a command

2013-07-19 Thread Seungwon Jeon
On Tue, July 09, 2013, Sujit Reddy Thumma wrote: There is a possible race condition in the hardware when the abort command is issued to terminate the ongoing SCSI command as described below: - A bit in the door-bell register is set in the controller for a new SCSI command. - In some rare

RE: [PATCH V3 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-19 Thread Seungwon Jeon
On Tue, July 09, 2013, Sujit Reddy Thumma wrote: Error handling in UFS driver is broken and resets the host controller for fatal errors without re-initialization. Correct the fatal error handling sequence according to UFS Host Controller Interface (HCI) v1.1 specification. o Upon

Re: [PATCH v4 02/17] sched_clock: Use seqcount instead of rolling our own

2013-07-19 Thread Nicolas Pitre
On Fri, 19 Jul 2013, Will Deacon wrote: Looks good to me. The current scheme would be very fiddly to extend to 64-bit values on 32-bit architectures without cheap atomic doubleword accesses. You should have a look at include/linux/cnt32_to_63.h. This could be applied to pure software counters

Re: [PATCH V3 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-07-19 Thread Sujit Reddy Thumma
On 7/19/2013 7:17 PM, Seungwon Jeon wrote: On Thu, July 18, 2013, Sujit Reddy Thumma wrote: + * ufshcd_wait_for_register - wait for register value to change + * @hba - per-adapter interface + * @reg - mmio register offset + * @mask - mask to apply to read register value + * @val - wait

Re: [PATCH V3 2/4] scsi: ufs: Fix hardware race conditions while aborting a command

2013-07-19 Thread Sujit Reddy Thumma
On 7/19/2013 7:26 PM, Seungwon Jeon wrote: On Tue, July 09, 2013, Sujit Reddy Thumma wrote: There is a possible race condition in the hardware when the abort command is issued to terminate the ongoing SCSI command as described below: - A bit in the door-bell register is set in the controller

Re: [PATCH V3 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-19 Thread Sujit Reddy Thumma
On 7/19/2013 7:26 PM, Seungwon Jeon wrote: On Tue, July 09, 2013 Sujit Reddy Thumma wrote: Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: Problem: If there are more than 8 TM commands the implementation returns error

Re: [PATCH V3 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-19 Thread Sujit Reddy Thumma
On 7/19/2013 7:28 PM, Seungwon Jeon wrote: On Tue, July 09, 2013, Sujit Reddy Thumma wrote: Error handling in UFS driver is broken and resets the host controller for fatal errors without re-initialization. Correct the fatal error handling sequence according to UFS Host Controller Interface

Re: [PATCH V3 3/4] scsi: ufs: Fix device and host reset methods

2013-07-19 Thread Sujit Reddy Thumma
On 7/19/2013 7:27 PM, Seungwon Jeon wrote: On Tue, July 09, 2013, Sujit Reddy Thumma wrote: As of now SCSI initiated error handling is broken because, the reset APIs don't try to bring back the device initialized and ready for further transfers. In case of timeouts, the scsi error handler

Re: [PATCH V3 1/2] scsi: ufs: Add support for host assisted background operations

2013-07-19 Thread Sujit Reddy Thumma
I'm not sure that BKOPS with runtime-pm associates. Do you think it's helpful for power management? How about hibernation scheme for runtime-pm? I'm testing and I can introduce soon. Well, I am thinking on following approach when we introduce power management. ufshcd_runtime_suspend() {

Re: [PATCH v4 13/17] clocksource: tegra: Switch to sched_clock_register()

2013-07-19 Thread Stephen Warren
On 07/18/2013 05:21 PM, Stephen Boyd wrote: The 32 bit sched_clock interface now supports 64 bits. Upgrade to the 64 bit function to allow us to remove the 32 bit registration interface. Acked-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar...@nvidia.com -- To unsubscribe

Re: [PATCH v4 07/17] clocksource: bcm2835: Switch to sched_clock_register()

2013-07-19 Thread Stephen Warren
On 07/18/2013 05:21 PM, Stephen Boyd wrote: The 32 bit sched_clock interface now supports 64 bits. Upgrade to the 64 bit function to allow us to remove the 32 bit registration interface. Acked-by: Stephen Warren swar...@wwwdotorg.org -- To unsubscribe from this list: send the line unsubscribe