Re: [PATCH 3/4] msm_serial: Make baud_code detection more dynamic

2013-07-25 Thread Bjorn Andersson
On Wed, Jul 24, 2013 at 10:37 AM, Stephen Boyd wrote: > [snip] > + unsigned int i, divisor; > + const struct msm_baud_map *entry; > + static const struct msm_baud_map table[] = { > + { 1536, 0x00, 1 }, > + { 768, 0x11, 1 }, > + { 384,

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Jack Pham
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > SINGLE_STEP_SET_FEATURE test as follows: > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > index 2b70277..8e6dc09 100644 > --- a/drivers/usb/

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Felipe Balbi wrote: > On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > > On Thu, 25 Jul 2013, Greg KH wrote: > > > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > > From: Manu Gautam > > > > > > > > The USB Embedded High-speed Host Electric

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg KH wrote: > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > From: Manu Gautam > > > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > > SINGLE_STEP_SET_FEATUR

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg KH wrote: > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > From: Manu Gautam > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > SINGLE_STEP_SET_FEATURE test as follows: > > > > 1) The host enumerates the test device with VI

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Greg KH
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > From: Manu Gautam > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > SINGLE_STEP_SET_FEATURE test as follows: > > 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 > 2) The host sends the SETUP

Re: [PATCH v1 04/14] clk: Add set_rate_and_parent() op

2013-07-25 Thread Stephen Boyd
On 07/25, Tomasz Figa wrote: > On Wednesday 24 of July 2013 17:43:32 Stephen Boyd wrote: > > Some of Qualcomm's clocks can change their parent and rate at the > > same time with a single register write. Add support for this > > hardware to the common clock framework by adding a new > > set_rate_and

Re: [PATCH v1 08/14] clk: msm: Add MSM clock driver

2013-07-25 Thread Stephen Boyd
On 07/25, Tomasz Figa wrote: > On Wednesday 24 of July 2013 17:43:36 Stephen Boyd wrote: > > Add a clock driver that registers clocks from a DT node's > > 'clocks' child. Each new SoC will add a file describing the > > software interface and frequency plan to drivers/clk/msm/ and > > then hook that

Re: [PATCH v1 05/14] clk: msm: Add support for phase locked loops (PLLs)

2013-07-25 Thread Stephen Boyd
On 07/25, Tomasz Figa wrote: > On Wednesday 24 of July 2013 17:43:33 Stephen Boyd wrote: > > +extern struct clk *pll_clk_register(struct device *dev, struct pll_desc > > *desc, +struct clk_init_data *init); > > +extern struct clk *pll_vote_clk_register(struct device *dev, > > +

Re: [PATCH v1 02/14] clk: Add of_init_clk_data() to parse common clock bindings

2013-07-25 Thread Stephen Boyd
On 07/25, Tomasz Figa wrote: > On Wednesday 24 of July 2013 17:43:30 Stephen Boyd wrote: > > Consolidate DT parsing for the common bits of a clock binding in > > one place to simplify clock drivers. This also has the added > > benefit of standardizing how the clock names used by the common > > cloc

Re: [PATCH v1 03/14] clk: Add of_clk_match() for device drivers

2013-07-25 Thread Stephen Boyd
On 07/25, Tomasz Figa wrote: > Hi Stephen, > > On Wednesday 24 of July 2013 17:43:31 Stephen Boyd wrote: > > In similar fashion as of_regulator_match() add an of_clk_match() > > function that finds an initializes clock init_data structs from > > devicetree. Drivers should use this API to find cloc

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote: > > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > > > index 6d05085..111f454 100644 > > > --- a/drivers/usb/phy/phy-msm-usb.c > > > +++ b/drivers/usb/phy/phy-msm-usb.c > > > @@ -64,8 +64,8 @@ stati

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-25 Thread Ivan T. Ivanov
On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote: > On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This patch move global regulators variables to driver state > > structire and move allocation of the regulators to be devm managed. > > spl

Re: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-25 Thread Ivan T. Ivanov
Hi, On Wed, 2013-07-24 at 15:38 +0300, Felipe Balbi wrote: > Hi, > > On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Use managed device resources to clean up the probe/remove > > and get DT support for free. > > > > Signed-off-by: Ivan T. Iv

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-25 Thread Ivan T. Ivanov
Hi, On Wed, 2013-07-24 at 15:22 +0300, Felipe Balbi wrote: > On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: linux-...@vger.kernel.org > > Cc: linux-ker...@vger.kernel.org > > > > Signed-o

Re: [PATCH 0/3] MSM gpio fixes

2013-07-25 Thread Linus Walleij
On Thu, Jul 25, 2013 at 12:41 AM, David Brown wrote: > On Sat, Jul 20, 2013 at 10:54:42PM +0200, Linus Walleij wrote: >>> ARM: msm: Consolidate gpiomux for older architectures >> >> This does not look like a fix? Surely this can wait for v3.12? > > It fixes compilation. But, it could also wait

Re: [PATCH v1 08/14] clk: msm: Add MSM clock driver

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:36 Stephen Boyd wrote: > Add a clock driver that registers clocks from a DT node's > 'clocks' child. Each new SoC will add a file describing the > software interface and frequency plan to drivers/clk/msm/ and > then hook that into the msm_cc_match_tab

Re: [PATCH v1 05/14] clk: msm: Add support for phase locked loops (PLLs)

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:33 Stephen Boyd wrote: > Add support for MSM's PLLs (phase locked loops). This is > sufficient enough to be able to determine the rate the PLL is > running at. We can add rate setting support later when it's > needed. > > Cc: devicet...@vger.kernel.o

Re: [PATCH v1 04/14] clk: Add set_rate_and_parent() op

2013-07-25 Thread Tomasz Figa
On Wednesday 24 of July 2013 17:43:32 Stephen Boyd wrote: > Some of Qualcomm's clocks can change their parent and rate at the > same time with a single register write. Add support for this > hardware to the common clock framework by adding a new > set_rate_and_parent() op. When the clock framework

Re: [PATCH v1 02/14] clk: Add of_init_clk_data() to parse common clock bindings

2013-07-25 Thread Tomasz Figa
Hi Stephen, Pretty good idea, but I have some comments inline. On Wednesday 24 of July 2013 17:43:30 Stephen Boyd wrote: > Consolidate DT parsing for the common bits of a clock binding in > one place to simplify clock drivers. This also has the added > benefit of standardizing how the clock names

Re: [PATCH v1 03/14] clk: Add of_clk_match() for device drivers

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:31 Stephen Boyd wrote: > In similar fashion as of_regulator_match() add an of_clk_match() > function that finds an initializes clock init_data structs from > devicetree. Drivers should use this API to find clocks that their > device is providing and t