Re: [PATCH V5 0/4] scsi: ufs: Improve UFS error handling

2013-08-12 Thread Dolev Raviv
Hi, I tested the new set of patches (V5 1-4) and it works. Thanks, Dolev The first patch fixes many issues with current task management handling in UFSHCD driver. Others improve error handling in various scenarios. These patches are rebased on: [PATCH 9/9] drivers/scsi/ufs: don't check

Re: [PATCH V5 1/4] scsi: ufs: Fix broken task management command implementation

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv dra...@codeaurora.org Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: Problem: If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait for one of the

Re: [PATCH V5 2/4] scsi: ufs: Fix hardware race conditions while aborting a command

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv dra...@codeaurora.org There is a possible race condition in the hardware when the abort command is issued to terminate the ongoing SCSI command as described below: - A bit in the door-bell register is set in the controller for a new SCSI command. - In some rare

Re: [PATCH V5 3/4] scsi: ufs: Fix device and host reset methods

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv dra...@codeaurora.org As of now SCSI initiated error handling is broken because, the reset APIs don't try to bring back the device initialized and ready for further transfers. In case of timeouts, the scsi error handler takes care of handling aborts and resets.

Re: [PATCH V5 4/4] scsi: ufs: Improve UFS fatal error handling

2013-08-12 Thread Dolev Raviv
Tested-by: Dolev Raviv dra...@codeaurora.org Error handling in UFS driver is broken and resets the host controller for fatal errors without re-initialization. Correct the fatal error handling sequence according to UFS Host Controller Interface (HCI) v1.1 specification. o Processed requests

Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible

2013-08-12 Thread Mark Rutland
Hi, Apologies for the long delay for review on this. I really like the direction this is going, but I have some qualms with the implementation. On Fri, Aug 02, 2013 at 03:15:23AM +0100, Rohit Vaswani wrote: This makes it easy to add SMP support for new targets by adding cpus property and the

Re: [PATCH 3/4] ARM: msm: Add SMP support for 8960

2013-08-12 Thread Mark Rutland
On Fri, Aug 02, 2013 at 03:15:24AM +0100, Rohit Vaswani wrote: Add the cpus bindings and the Krait release sequence to make SMP work for MSM8960 Signed-off-by: Rohit Vaswani rvasw...@codeaurora.org --- Documentation/devicetree/bindings/arm/cpus.txt | 2 +

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Stephen Boyd
On 08/10/13 12:11, Ohad Ben-Cohen wrote: Otherwise, Stephen - do we have your Ack here? I was happy to see your review but not sure what's the latest status. The smp_mb() should be removed. Otherwise I'm willing to accept that we only build this driver on ARCH_MSM for now. We can fix that in

Re: [PATCH v2] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Stephen Boyd
On 07/29/13 15:00, Kumar Gala wrote: diff --git a/drivers/hwspinlock/msm_hwspinlock.c b/drivers/hwspinlock/msm_hwspinlock.c new file mode 100644 index 000..dbd9a69 --- /dev/null +++ b/drivers/hwspinlock/msm_hwspinlock.c @@ -0,0 +1,150 @@ +/* + * Copyright (c) 2013, The Linux

Re: [RESEND PATCH 4/4] ARM: msm: Add support for 8974 SMP

2013-08-12 Thread Mark Rutland
On Fri, Aug 02, 2013 at 03:15:25AM +0100, Rohit Vaswani wrote: Add the cpus bindings and the Kraitv2 release sequence to make SMP work for 2 cores on MSM8974. Signed-off-by: Rohit Vaswani rvasw...@codeaurora.org --- Documentation/devicetree/bindings/arm/cpus.txt | 1 +

Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block

2013-08-12 Thread Kumar Gala
On Aug 10, 2013, at 2:11 PM, Ohad Ben-Cohen wrote: + Grant On Thu, Aug 1, 2013 at 5:10 PM, Kumar Gala ga...@codeaurora.org wrote: On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: On 07/29, Kumar Gala wrote: diff --git a/Documentation/devicetree/bindings/arm/msm/tcsr-mutex.txt

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 11:04:48AM -0400, Alan Stern wrote: heh, it doesn't need to be entirely in the core. Core could have the generic calls and HCDs could implement some callbacks, but I think quite a bit of the code will be similar if we implement the same thing on all

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote: On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) probably good to spell out Synopsys rather than SNPS Synopsys (the company) has

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Felipe Balbi wrote: maybe a single callback for supporting 'testmodes' ? which receives the test mode as argument ? I don't have a clear picture of how you would apply such an approach to this case. There would have to be a way to tell the HCD to insert a

Re: [PATCH v1 09/14] clk: msm: Add support for MSM8960's global clock controller (GCC)

2013-08-12 Thread Stephen Boyd
On 08/08, Mark Rutland wrote: Hi Stephen, On Thu, Jul 25, 2013 at 01:43:37AM +0100, Stephen Boyd wrote: Fill in the data and wire up the global clock controller to the MSM clock driver. This should allow most non-multimedia device drivers to control their clocks on 8960 based platforms.

Re: [PATCH v1 03/14] clk: Add of_clk_match() for device drivers

2013-08-12 Thread Stephen Boyd
On 08/12, Mike Turquette wrote: Quoting Stephen Boyd (2013-07-24 17:43:31) In similar fashion as of_regulator_match() add an of_clk_match() function that finds an initializes clock init_data structs from devicetree. Drivers should use this API to find clocks that their device is providing