RE: [PATCH V2 1/3] scsi: ufs: Allow vendor specific initialization

2013-09-09 Thread Seungwon Jeon
Hi Sujit, On Tue, August 27, 2013, Sujit Reddy Thumma wrote: Some vendor specific controller versions might need to configure vendor specific - registers, clocks, voltage regulators etc. to initialize the host controller UTP layer and Uni-Pro stack. Provide some common initialization

Re: [PATCH RFC v2 2/5] spmi: Linux driver framework for SPMI

2013-09-09 Thread Mark Brown
On Fri, Aug 23, 2013 at 11:06:25AM -0500, Josh Cartwright wrote: On Thu, Aug 22, 2013 at 04:10:54PM -0700, Greg Kroah-Hartman wrote: On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote: + Example: Read 4 bytes starting at register address 0x1234 for SID 2\n + \n + echo

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Rohit Vaswani
On 9/6/2013 2:50 PM, Olof Johansson wrote: Hi, Some comments below. On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard snip dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ - msm8960-cdp.dtb + msm8960-cdp.dtb \

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Kumar Gala
On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: On 9/6/2013 2:50 PM, Olof Johansson wrote: Hi, Some comments below. On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard snip dtb-$(CONFIG_ARCH_MSM) +=

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Stephen Warren
On 09/09/2013 01:17 PM, Kumar Gala wrote: On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: On 9/6/2013 2:50 PM, Olof Johansson wrote: Hi, Some comments below. On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Kumar Gala
On Sep 9, 2013, at 2:29 PM, Stephen Warren wrote: On 09/09/2013 01:17 PM, Kumar Gala wrote: On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: On 9/6/2013 2:50 PM, Olof Johansson wrote: Hi, Some comments below. On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Stephen Warren
On 09/09/2013 01:48 PM, Kumar Gala wrote: On Sep 9, 2013, at 2:29 PM, Stephen Warren wrote: On 09/09/2013 01:17 PM, Kumar Gala wrote: On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote: On 9/6/2013 2:50 PM, Olof Johansson wrote: Hi, Some comments below. On Fri, Sep 06, 2013 at

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Rohit Vaswani
On 9/9/2013 2:25 PM, Kumar Gala wrote: snip On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard snip dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ - msm8960-cdp.dtb + msm8960-cdp.dtb \ +

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Kumar Gala
On Sep 9, 2013, at 4:42 PM, Rohit Vaswani wrote: On 9/9/2013 2:25 PM, Kumar Gala wrote: snip On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard snip dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \ - msm8960-cdp.dtb

Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard

2013-09-09 Thread Rohit Vaswani
On 9/9/2013 3:04 PM, Kumar Gala wrote: On Sep 9, 2013, at 4:42 PM, Rohit Vaswani wrote: On 9/9/2013 2:25 PM, Kumar Gala wrote: snip On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote: This patch adds basic board support for APQ8074 Dragonboard snip dtb-$(CONFIG_ARCH_MSM) +=

[PATCH 2/2] ARM: msm: Create a common board-dt and config ARCH_MSM_DT

2013-09-09 Thread Rohit Vaswani
Create a config ARCH_MSM_DT and common board-dt.c to encapsulate the MSM DT based targets. Signed-off-by: Rohit Vaswani rvasw...@codeaurora.org --- arch/arm/mach-msm/Kconfig | 13 +++ arch/arm/mach-msm/Makefile| 3 +-- arch/arm/mach-msm/board-dt-8660.c | 48

[PATCH 1/2] ARM: msm: Remove irqs-*.h files for DT based targets

2013-09-09 Thread Rohit Vaswani
From: Stephen Boyd sb...@codeaurora.org We don't want or need the irqs.h files from the DT based MSM targets. Remove these header files and select sparse irq so that we don't try to include the mach/irqs.h file. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/Kconfig

Re: [PATCH 2/2] ARM: msm: Create a common board-dt and config ARCH_MSM_DT

2013-09-09 Thread Stephen Boyd
On 09/09/13 16:01, Rohit Vaswani wrote: diff --git a/arch/arm/mach-msm/board-dt.c b/arch/arm/mach-msm/board-dt.c new file mode 100644 index 000..c140c53 --- /dev/null +++ b/arch/arm/mach-msm/board-dt.c @@ -0,0 +1,32 @@ +/* Copyright (c) 2010-2012, The Linux Foundation. All rights

[PATCHv2 1/2] ARM: msm: Remove irqs-*.h files for DT based targets

2013-09-09 Thread Rohit Vaswani
From: Stephen Boyd sb...@codeaurora.org We don't want or need the irqs.h files from the DT based MSM targets. Remove these header files and select sparse irq so that we don't try to include the mach/irqs.h file. Reviewed-by: Rohit Vaswani rvasw...@codeaurora.org Signed-off-by: Stephen Boyd

[PATCHv2 2/2] ARM: msm: Create a common board-dt and config ARCH_MSM_DT

2013-09-09 Thread Rohit Vaswani
Create a config ARCH_MSM_DT and common board-dt.c to encapsulate the MSM DT based targets. Reviewed-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Rohit Vaswani rvasw...@codeaurora.org --- arch/arm/mach-msm/Kconfig | 13 +++ arch/arm/mach-msm/Makefile| 3 +--

[PATCH 1/2] ARM: msm: trout: fix 'pointer from integer' warnings

2013-09-09 Thread Josh Cartwright
Fix several errors, all in the following form: arch/arm/mach-msm/board-trout-gpio.c: In function 'trout_gpio_irq_ack': arch/arm/mach-msm/board-trout-gpio.c:120:2: warning: passing argument 2 of '__raw_writeb' makes pointer from integer without a cast [enabled by default] writeb(mask,

[PATCH 2/2] ARM: msm: trout: fix uninit var warning

2013-09-09 Thread Josh Cartwright
Fix the following warning when !CONFIG_MMC: arch/arm/mach-msm/board-trout.c: In function 'trout_init': arch/arm/mach-msm/board-trout.c:67:6: warning: unused variable 'rc' [-Wunused-variable] int rc; ^ Also, while we're here, rework explicit printk(KERN_CRIT..) to use pr_crit.