Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-20 Thread Felipe Balbi
Hi, Tim Bird writes: > On 11/16/2015 09:21 AM, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >>> On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: >>>> >>>> >>>> On 11/10/2015 07:14 PM, Peter Ch

Re: [PATCH 4/4] Documentation: usb: dwc3: qcom: Add TCSR mux usage

2015-11-20 Thread Felipe Balbi
Hi, Andy Gross writes: > This patch adds documentation for the optional syscon-tcsr property in the > Qualcomm DWC3 node. The syscon-tcsr specifies the register and bit used to > configure the TCSR USB phy mux register. > > Signed-off-by: Andy Gross > --- > Documentation/devicetree/bindings/u

Re: [PATCH 2/4] usb: dwc3: qcom: Configure TCSR phy mux register

2015-11-20 Thread Felipe Balbi
Hi, Andy Gross writes: > This patch adds automatic configuration of the TCSR phy mux register based on > the syscon-tcsr devicetree entry. This configuration is optional, as some > platforms may not require the mux selection. > > Signed-off-by: Andy Gross just when I find a way to make a gene

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-16 Thread Felipe Balbi
Hi, Peter Chen writes: > On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: >> >> >> On 11/10/2015 07:14 PM, Peter Chen wrote: >> > On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote: >> >> This fixes a bug where if you disconnect and re-connect the USB cable, >> >> the gadget dri

Re: [PATCH] usb: phy: msm: Add D+/D- lines route control

2015-07-21 Thread Felipe Balbi
On Wed, Jul 08, 2015 at 12:45:54PM +0300, Ivan T. Ivanov wrote: > apq8016-sbc board is using Dual SPDT USB Switch (TC7USB40MU), > witch is controlled by GPIO to de/multiplex D+/D- USB lines to > USB2513B Hub and uB connector. Add support for this. > > Signed-off-by: Ivan T. Ivanov doesn't apply:

Re: [PATCH 3/5] usb: phy: ab8500-usb: Rename regulator_set_optimum_mode

2015-02-27 Thread Felipe Balbi
On Wed, Feb 11, 2015 at 07:35:29PM -0800, Bjorn Andersson wrote: > The function regulator_set_optimum_mode() is changing name to > regulator_set_load(), so update the code accordingly. > > Signed-off-by: Bjorn Andersson since this depends on the rest of the series: Acked-by:

Re: [PATCH 4/5] usb: phy: phy-msm-usb: Rename regulator_set_optimum_mode

2015-02-27 Thread Felipe Balbi
On Wed, Feb 11, 2015 at 07:35:30PM -0800, Bjorn Andersson wrote: > The function regulator_set_optimum_mode() is changing name to > regulator_set_load(), so update the code accordingly. > > Signed-off-by: Bjorn Andersson since this depends on the rest of the series: Acked-by:

Re: [PATCH] i2c: qup: Fix order of runtime pm initialization

2014-09-29 Thread Felipe Balbi
; Signed-off-by: Andy Gross Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature

Re: [Patch v9 1/3] usb: dwc3: qcom: Add device tree binding

2014-09-16 Thread Felipe Balbi
Hi, On Tue, Sep 16, 2014 at 11:15:43AM -0700, Jack Pham wrote: > Hi Andy, > > On Fri, Sep 12, 2014 at 02:28:06PM -0500, Andy Gross wrote: > > +Example device nodes: > > + > > + hs_phy: phy@100f8800 { > > + compatible = "qcom,dwc3-hs-usb-phy"; > > + re

Re: [Patch v9 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-13 Thread Felipe Balbi
Hi, On Sat, Sep 13, 2014 at 12:16:01PM +0530, Kishon Vijay Abraham I wrote: > On Saturday 13 September 2014 12:58 AM, Andy Gross wrote: > > This patch adds a new driver for the Qualcomm USB 3.0 PHY that exists on > > some > > Qualcomm platforms. This driver uses the generic PHY framework and wil

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
Hi, On Sat, Sep 13, 2014 at 01:55:50AM +0530, Pramod Gurav wrote: > >>> + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP_KERNEL); > >>> + if (!qdwc) > >>> + return -ENOMEM; > >>> + > >>> + platform_set_drvdata(pdev, qdwc); > >>> + > >>> + qdwc->dev = &pdev

Re: [Patch v9 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
On Sat, Sep 13, 2014 at 01:44:25AM +0530, Pramod Gurav wrote: > Andy, > Couple of minor comments. > > On Sat, Sep 13, 2014 at 12:58 AM, Andy Gross wrote: > > > From: "Ivan T. Ivanov" > > > > DWC3 glue layer is hardware layer around Synopsys DesignWare > > USB3 core. Its purpose is to supply Syn

Re: [PATCH v8 3/3] phy: Add Qualcomm DWC3 HS/SS PHY driver

2014-09-12 Thread Felipe Balbi
Gross Kishon, this looks good to my eyes. It has no direct dependency with dwc3 glue layer. Can you still grab this for v3.18 merge window ? Reviewed-by: Felipe Balbi Acked-by: Felipe Balbi cheers -- balbi signature.asc Description: Digital signature

Re: [PATCH v8 2/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-09-12 Thread Felipe Balbi
Hi, On Fri, Sep 12, 2014 at 12:29:45PM -0500, Andy Gross wrote: > From: "Ivan T. Ivanov" > > DWC3 glue layer is hardware layer around Synopsys DesignWare > USB3 core. Its purpose is to supply Synopsys IP with required > clocks, voltages and interface it with the rest of the SoC. > > Signed-off-

Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-20 Thread Felipe Balbi
On Thu, Jul 17, 2014 at 09:16:40PM +0100, Srinivas Kandagatla wrote: > This patch makes the phy reset clk and reset line optional as this clk > is not available on boards like IFC6410 with APQ8064. > > phy-reset clk is only used as argument to the mach level callbacks, so > this patch adds conditi

Re: [PATCH RESEND] usb: chipidea: msm: Use USB PHY API to control PHY state

2014-08-19 Thread Felipe Balbi
HY API perspective, so: Acked-by: Felipe Balbi However, it doesn't look like msm_phy_init() is equivalent to the lines removes. Care to comment ? > --- > drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git

Re: Fwd: Status of chipidea msm USB reset patch

2014-08-14 Thread Felipe Balbi
Hi, On Thu, Aug 14, 2014 at 09:53:10AM -0700, Tim Bird wrote: > Ping. Anybody know the status of this patch? Is it queued in someone's tree? > Without it the USB driver for the Qualcomm 8974 (hsusb phy) doesn't > work (at least for me). > It looks like it got dropped from Ivan's original patch s

Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-07-17 Thread Felipe Balbi
Hi, On Thu, Jul 17, 2014 at 02:14:15PM +0100, Srinivas Kandagatla wrote: > On 17/07/14 13:54, pramod gurav wrote: > >Hi Srini, > > > >On Thu, Jul 17, 2014 at 6:19 PM, wrote: > >>From: Srinivas Kandagatla > >> > >>This patch makes the phy reset clk and reset line optional as this clk > >>is not

Re: [Patch v7 3/3] usb: dwc3: qcom: Add device tree binding

2014-07-02 Thread Felipe Balbi
Hi, On Wed, Jul 02, 2014 at 02:48:17PM +0200, Arnd Bergmann wrote: > On Wednesday 02 July 2014 11:43:25 Ivan T. Ivanov wrote: > > > > > > > > > > > >> > + > > > >> > + ranges; > > > >> > + > > > >> > + status = "disabled"; > > > >> > + > > > >> > +

Re: [PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 06:29:57PM +0100, Srinivas Kandagatla wrote: > Use case is when the phy is configured in host mode and a usb device is > attached to board before bootup. On bootup, with the existing code and > runtime pm enabled, the driver would decrement the pm usage count > without check

Re: [PATCH v1 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 06:29:34PM +0100, Srinivas Kandagatla wrote: > This patch makes the msm ehci driver available to use on QCOM SOCs, > which have the same IP. > > Signed-off-by: Srinivas Kandagatla Alan, this is ok to me: Acked-by: Felipe Balbi > --- > drivers/us

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 11:23:43AM +0100, Srinivas Kandagatla wrote: > Hi Felipe, > > On 27/06/14 16:54, Felipe Balbi wrote: > >Hi, > > > >On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: > >>Use case is when the phy is configured in host m

Re: [RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Felipe Balbi
Hi, On Wed, Jun 18, 2014 at 06:00:01PM +0100, Srinivas Kandagatla wrote: > While testing usb host on Qualcomm APQ8064, I encountered few issues. > These patches fixes those issues. > > Without these patches USB is not functional on AQ8064. > All the patches are tested on IFC6410. please resend w

Re: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-06-30 Thread Felipe Balbi
Hi, first of all, since this is a brand new PHY driver, could you guys use the generic phy framework instead ? (drivers/phy) On Mon, Jun 30, 2014 at 11:03:52AM -0500, Andy Gross wrote: > diff --git a/drivers/usb/phy/phy-qcom-hsusb.c > b/drivers/usb/phy/phy-qcom-hsusb.c > new file mode 100644 > i

Re: [Patch v7 1/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 30, 2014 at 11:03:51AM -0500, Andy Gross wrote: > +static int dwc3_qcom_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct dwc3_qcom *qdwc; > + int ret = 0; > + > + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-27 Thread Felipe Balbi
Hi, On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: > Use case is when the phy is configured in host mode and a usb device is > attached to board before bootup. On bootup, with the existing code and > runtime pm enabled, the driver would decrement the pm usage count > without

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

2014-05-05 Thread Felipe Balbi
On Mon, May 05, 2014 at 10:03:31AM -0500, Felipe Balbi wrote: > On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote: > > On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > > > this solves the following build warning found when > > > running compile test

Re: [PATCH 1/3] usb: phy: msm: cast to unsigned long int

2014-05-05 Thread Felipe Balbi
On Sat, May 03, 2014 at 09:56:32AM +0300, Ivan T. Ivanov wrote: > On Wed, 2014-04-30 at 11:38 -0500, Felipe Balbi wrote: > > this solves the following build warning found when > > running compile tests. > > > > drivers/usb/phy/phy-msm-usb.c: In function ‘msm_otg_read_d

Re: [PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-05-02 Thread Felipe Balbi
On Fri, May 02, 2014 at 08:49:05AM +0300, Ivan T. Ivanov wrote: > On Wed, 2014-04-30 at 11:27 -0500, Felipe Balbi wrote: > > On Thu, Apr 24, 2014 at 06:48:11PM +0300, Ivan T. Ivanov wrote: > > > From: Tim Bird > > > > > > Fix the value used for Parallel Tran

Re: [PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-04-30 Thread Felipe Balbi
Hi, On Wed, Apr 30, 2014 at 08:07:05PM +0200, Bird, Tim wrote: > Signed-off-by:Tim Bird thanks Tim but I already had your SoB in the patch, I need Ivan's :-) > > Sent from my Sony Xperia™ smartphone > > Felipe Balbi wrote > > >On Thu, Apr 24, 201

[PATCH 1/3] usb: phy: msm: cast to unsigned long int

2014-04-30 Thread Felipe Balbi
id->data; ^ Signed-off-by: Felipe Balbi --- all patches are on top of Ivan's 20 patch series. drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 9dc79

[PATCH 3/3] usb: phy: msm: enable build on other architectures

2014-04-30 Thread Felipe Balbi
By adding COMPILE_TEST to the list of dependencies we can build test this driver on all other architectures which is very valuable for maintainers applying patches and to find silly mistakes during development. Signed-off-by: Felipe Balbi --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1

[PATCH 2/3] usb: phy: msm: switch over to writel()

2014-04-30 Thread Felipe Balbi
Remove that single instance of writel_relaxed() call which is only available on ARM architecture. This will let us build test this driver on all different architectures. Signed-off-by: Felipe Balbi --- drivers/usb/phy/phy-msm-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v7 16/20] usb: phy: msm: Fix PTS definitions for MSM USB controller

2014-04-30 Thread Felipe Balbi
On Thu, Apr 24, 2014 at 06:48:11PM +0300, Ivan T. Ivanov wrote: > From: Tim Bird > > Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB > controller. This is a standard chipidea PORTSC definition, where > a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL. > Fix the

Re: [PATCH v8 17/20] usb: phy: msm: Select secondary PHY via TCSR

2014-04-30 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 04:34:20PM +0300, Ivan T. Ivanov wrote: > From: Tim Bird > > Select the secondary PHY using the TCSR register, if phy-num=1 > in the DTS (or phy_number is set in the platform data). The > SOC has 2 PHYs which can be used with the OTG port, and this > code allows configuri

Re: [PATCH v8 14/20] usb: phy: msm: Add support for secondary PHY control

2014-04-30 Thread Felipe Balbi
Hi, On Mon, Apr 28, 2014 at 04:34:17PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Allow support to use 2nd HSPHY with USB2 Core. > Some platforms may have configuration to allow USB controller > work with any of the two HSPHYs present. By default driver > configures USB core to us

Re: [PATCH v8 02/20] usb: phy: msm: Remove __init macro from driver probe method

2014-04-28 Thread Felipe Balbi
On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote: > On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote: > > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote:

Re: [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-04-25 Thread Felipe Balbi
On Thu, Apr 24, 2014 at 01:49:38PM -0300, Fabio Estevam wrote: > On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote: > > > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX"); > > + if (IS_ERR(motg->vddcx)) { > > + dev_err(motg->phy.dev, "unable to get h

Re: [PATCH v7 20/20] usb: phy: msm: Use usb_add_phy_dev() to register device

2014-04-25 Thread Felipe Balbi
On Thu, Apr 24, 2014 at 09:06:24PM +0400, Sergei Shtylyov wrote: > Hello. > > On 04/24/2014 07:48 PM, Ivan T. Ivanov wrote: > > >From: "Ivan T. Ivanov" > > >They could be more than one USB2.0 PHY's on the platform. > >s/They/There/ > > >This will allow all of them to be registred successf

Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM

2014-04-23 Thread Felipe Balbi
On Wed, Apr 23, 2014 at 11:48:29AM +0300, Ivan T. Ivanov wrote: > On Tue, 2014-04-22 at 10:24 -0500, Felipe Balbi wrote: > > On Tue, Apr 22, 2014 at 06:16:35PM +0300, Ivan T. Ivanov wrote: > > > > > > Hi, > > > > > > On Tue, 2014-04-22 at 09:57 -050

Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM

2014-04-22 Thread Felipe Balbi
On Tue, Apr 22, 2014 at 06:16:35PM +0300, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-04-22 at 09:57 -0500, Felipe Balbi wrote: > > On Tue, Apr 22, 2014 at 12:20:20PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > >

Re: [PATCH v6 03/19] usb: phy: msm: Move global regulators variables to driver state

2014-04-22 Thread Felipe Balbi
On Tue, Apr 22, 2014 at 06:12:19PM +0300, Ivan T. Ivanov wrote: > On Tue, 2014-04-22 at 09:57 -0500, Felipe Balbi wrote: > > On Tue, Apr 22, 2014 at 12:20:22PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > #define ENOLOG

Re: [PATCH v6 03/19] usb: phy: msm: Move global regulators variables to driver state

2014-04-22 Thread Felipe Balbi
On Tue, Apr 22, 2014 at 12:20:22PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" #define ENOLOG ENOCOMMIT return -ENOLOG; -- balbi signature.asc Description: Digital signature

Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM

2014-04-22 Thread Felipe Balbi
On Tue, Apr 22, 2014 at 12:20:20PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Controller could be found on APQ and MSM platforms, > make configuration description more generic. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/usb/phy/Kconfig | 6 +++--- > 1 file changed, 3 inse

Re: [PATCH RFC 06/12] mmc: mmci: Add write delay to variant structure.

2014-04-21 Thread Felipe Balbi
Hi, On Mon, Apr 21, 2014 at 10:48:18PM +0100, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch adds write delay parameter required after each write to controller > registers on some of the SOCs like Qualcomm ones. The delay parameter will > provide information on

Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR

2014-04-21 Thread Felipe Balbi
On Mon, Apr 21, 2014 at 10:03:28AM -0700, Tim Bird wrote: > On Mon, Apr 21, 2014 at 9:14 AM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Apr 04, 2014 at 03:18:11PM -0700, Tim Bird wrote: > >> Select the secondary PHY using the TCSR register, if phy-num=1 > >&

Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR

2014-04-21 Thread Felipe Balbi
Hi, On Fri, Apr 04, 2014 at 03:18:11PM -0700, Tim Bird wrote: > Select the secondary PHY using the TCSR register, if phy-num=1 > in the DTS (or phy_number is set in the platform data). The > SOC has 2 PHYs which can be used with the OTG port, and this > code allows configuring the correct one. >

Re: [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support

2014-03-10 Thread Felipe Balbi
Hi, On Sat, Mar 08, 2014 at 06:46:52PM +0200, Ivan T. Ivanov wrote: > Hi, > > On 03/08/2014 02:15 AM, Felipe Balbi wrote: > > On Wed, Mar 05, 2014 at 05:54:03PM -0800, Tim Bird wrote: > >> Ivan, > >> > >> I'm still unsuccessful at getting this p

Re: [PATCHv2] usb: gadget: f_fs: Add flags to descriptors block

2014-02-25 Thread Felipe Balbi
Hi, On Tue, Feb 25, 2014 at 06:02:18PM +0100, Michal Nazarewicz wrote: > This reworks the way SuperSpeed descriptors are added and instead of > having a magick after full and high speed descriptors, it reworks the > whole descriptors block to include a flags field which lists which > descriptors a

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-24 Thread Felipe Balbi
On Tue, Feb 25, 2014 at 12:05:00PM +0900, Mark Brown wrote: > On Mon, Feb 24, 2014 at 06:09:13PM -0600, Felipe Balbi wrote: > > > > + depends on ARCH_QCOM || (COMPILE_TEST && OF && ARM) > > > do you really want to make it depend on ARM even when C

Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-24 Thread Felipe Balbi
Hi, On Mon, Feb 24, 2014 at 05:11:40PM -0600, Andy Gross wrote: > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 605b016..f87cef9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -401,4 +401,13 @@ config DMATEST > config DMA_ENGINE_RAID > bool > > +confi

Re: [PATCH] usb: phy: msm: fix possible build error

2014-02-19 Thread Felipe Balbi
Hi, On Tue, Feb 18, 2014 at 10:28:06PM -0800, Stephen Boyd wrote: > On 02/18, Felipe Balbi wrote: > > This will fail builds on configs where > > CONFIG_PM_RUNTIME=y and CONFIG_PM_SLEEP=n. > > > > Following build error will show up: > > > > dri

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:33:21AM -0600, Josh Cartwright wrote: > On Tue, Feb 18, 2014 at 10:24:16AM -0600, Felipe Balbi wrote: > > On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: > > > On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: > >

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Felipe Balbi
On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: > On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: > > Both the PM_RUNTIME and PM_SLEEP callbacks call into the common > > msm_otg_{suspend,resume} routines, however these routines are only being > > built when CONFIG_

Re: [PATCH v5 1/6] spmi: Linux driver framework for SPMI

2014-02-15 Thread Felipe Balbi
Hi, On Mon, Feb 03, 2014 at 05:05:33PM -0600, Josh Cartwright wrote: [ snip ] > +#ifdef CONFIG_PM_RUNTIME > +static int spmi_runtime_suspend(struct device *dev) > +{ > + struct spmi_device *sdev = to_spmi_device(dev); > + int err; > + > + err = pm_generic_runtime_suspend(dev); > +

Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-12-27 Thread Felipe Balbi
On Fri, Dec 27, 2013 at 10:23:10AM -0800, Stephen Boyd wrote: > On 12/27/13 10:10, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 12, 2013 at 04:51:36PM +0200, Ivan T. Ivanov wrote: > >> From: "Ivan T. Ivanov" > >> > >> This patch f

Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code to platform data

2013-12-27 Thread Felipe Balbi
diate step before adding support for reset > framework and newer targets. > > Signed-off-by: Ivan T. Ivanov > Acked-by: David Brown > Cc: Daniel Walker > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman this really looks like you should be using reset framework (drivers/reset

Re: [PATCH v4 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-12-23 Thread Felipe Balbi
On Mon, Dec 23, 2013 at 05:18:42PM +0530, Manu Gautam wrote: > Allow userspace to pass SuperSpeed descriptors and > handle them in the driver accordingly. > This change doesn't modify existing desc_header and thereby > keeps the ABI changes backward compatible i.e. existing > userspace drivers comp

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-12-19 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 03:03:15PM -0800, David Brown wrote: > On Tue, Nov 26, 2013 at 10:38:46AM -0600, Felipe Balbi wrote: > >Hi, > > > >On Tue, Nov 12, 2013 at 04:51:35PM +0200, Ivan T. Ivanov wrote: > >>From: "Ivan T. Ivanov" > >> > >>

Re: [PATCH v2 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Oct 08, 2013 at 09:52:55AM +0530, Manu Gautam wrote: > On 10/2/2013 10:06 AM, Manu Gautam wrote: > > On 10/1/2013 8:07 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Mon, Sep 30, 2013 at 02:31:50PM +0530, Manu Gautam wrote: > >>> On 9/28/

Re: [PATCH v4 00/15] usb: phy: msm: Fixes, cleanups and DT support

2013-11-26 Thread Felipe Balbi
Hi, On Tue, Nov 12, 2013 at 04:51:35PM +0200, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Hi, > > Patches have been tested on top of Stephen's clock controller > patches[1] and recent fixes for chipidea msm glue layer driver > posted here[2]. Hardware platform AP8074 DragonBoard. Only g

Re: [PATCH v3 12/13] usb: phy: msm: Properly check core interrupt number

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:39PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > IRQ with number 0 is valid case, so check for negative not entirelly correct... IRQ 0 isn't supposed to be used as a linux IRQ number IIRC. > numbers instead. > > Signed-off-by: Ivan T. Ivanov > --- >

Re: [PATCH v3 02/13] usb: phy: msm: Move global regulators variables to driver state

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 06:24:29PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Signed-off-by: Ivan T. Ivanov this one looks good. -- balbi signature.asc Description: Digital signature

Re: [PATCH v3 01/13] usb: phy: msm: Move mach depndend code to platform data

2013-10-14 Thread Felipe Balbi
Hi, On Mon, Oct 14, 2013 at 06:24:28PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch fix compilation error and is an intermediate step > before the addition of DeviceTree support for newer targets. > > Cc: David Brown > Cc: Daniel Walker

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-10-04 Thread Felipe Balbi
On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS, LS)

Re: [PATCH v2 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-10-01 Thread Felipe Balbi
2:08 AM > >> > >> On 9/26/2013 2:10 AM, Felipe Balbi wrote: > >>> > >>> On Tue, Sep 24, 2013 at 03:00:20PM +0530, Manu Gautam wrote: > >>>> Hi Felipe, > >>>> > >>>> I wanted to mention one point with resp

Re: [PATCH v2 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-09-25 Thread Felipe Balbi
Hi, (please avoid top-posting) On Tue, Sep 24, 2013 at 03:00:20PM +0530, Manu Gautam wrote: > Hi Felipe, > > I wanted to mention one point with respect to this patch: Below > changes in the functionfs.h to add ss_count (super speed descriptors > count) in desc_header (which is passed from usersp

Re: [PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's

2013-09-23 Thread Felipe Balbi
Hi, On Wed, Aug 21, 2013 at 04:29:45PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver > which manage Synopsys DesignWare USB3 controller stack > inside Qualcomm SoC's.

Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Felipe Balbi
Hi, On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS

Re: [PATCH v4 1/3] usb: dwc3: msm: Add device tree binding information

2013-09-23 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 12:56:03PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-27 Thread Felipe Balbi
at 9:54 AM, Ivan T. Ivanov wrote: > > > > > > > > > > > Hi, > > > > > > > > On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: > > > >> On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > > > >>> > >

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-22 Thread Felipe Balbi
-20 at 16:01 +0100, Kumar Gala wrote: > >>>> On Aug 20, 2013, at 9:54 AM, Ivan T. Ivanov wrote: > >>>> > >>>>> > >>>>> Hi, > >>>>> > >>>>> On Tue, 2013-08-20 at 09:33 -0500, Felipe Balbi wrote: >

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
On Tue, Aug 20, 2013 at 05:09:11PM +0300, Ivan T. Ivanov wrote: > Hi, > > On Tue, 2013-08-20 at 08:37 -0500, Felipe Balbi wrote: > > Hi, > > > > On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > > > On Tue, Aug 20, 2013 at 12:56:04PM +030

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 04:32:23PM +0300, Ivan T. Ivanov wrote: > > On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > > > These drivers handles control and configuration of the HS > > > and SS USB PHY transceivers. They are part of the drive

Re: [PATCH v4 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-20 Thread Felipe Balbi
Hi, On Tue, Aug 20, 2013 at 12:56:04PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > These drivers handles control and configuration of the HS > and SS USB PHY transceivers. They are part of the driver > which manage Synopsys DesignWare USB3 controller stack > inside Qualcomm SoC's.

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-13 Thread Felipe Balbi
On Mon, Aug 12, 2013 at 02:52:33PM -0400, Alan Stern wrote: > On Mon, 12 Aug 2013, Felipe Balbi wrote: > > > > > maybe a single callback for supporting 'testmodes' ? which receives the > > > > test mode as argument ? > > > > > > I

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote: > > On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) > > probably good to spell out Synopsys rather than SNPS Synopsys (the company) has always

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 11:04:48AM -0400, Alan Stern wrote: > > > > heh, it doesn't need to be entirely in the core. Core could have the > > > > generic calls and HCDs could implement some callbacks, but I think quite > > > > a bit of the code will be similar if we implement the same thing on

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 10:37:50AM -0400, Alan Stern wrote: > > > > Wait a minute, didn't we discuss a while back that these test features > > > > should be built into usbcore so that we could have a usbcv clone for > > > > linux ? > > > > > > There's no way this can be built into the core.

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 05:33:48PM -0400, Alan Stern wrote: > > On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > > > On Thu, 25 Jul 2013, Greg KH wrote: > > > > > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > > > From: Manu Gautam > > > > > > > > > > The

Re: [RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-09 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 12:53:47PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > DWC3 glue layer is hardware layer around Synopsys DesignWare > USB3 core. Its purpose is to supply Synopsys IP with required > clocks, voltages and interface it with the rest of the SoC. > > Signed-off-b

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-26 Thread Felipe Balbi
On Fri, Jul 26, 2013 at 03:31:34PM +0300, Ivan T. Ivanov wrote: > > Hi Felipe, > > On Thu, 2013-07-25 at 16:43 +0300, Ivan T. Ivanov wrote: > > On Wed, 2013-07-24 at 15:39 +0300, Felipe Balbi wrote: > > > On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov w

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg KH wrote: > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > From: Manu Gautam > > > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > > SINGLE_STEP_SET_FEATUR

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 04:40:51PM +0300, Ivan T. Ivanov wrote: > > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > > > index 6d05085..111f454 100644 > > > --- a/drivers/usb/phy/phy-msm-usb.c > > > +++ b/drivers/usb/phy/phy-msm-usb.c > > > @@ -64,8 +64,8 @@ stati

Re: [PATCH v2 3/7] usb: phy: msm: Move regulator usage to managed resource allocation

2013-07-24 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 06:47:09PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch move global regulators variables to driver state > structire and move allocation of the regulators to be devm managed. split into two patches please. One for moving the global regulators into

Re: [PATCH v2 2/7] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-07-24 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Use managed device resources to clean up the probe/remove > and get DT support for free. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/usb/phy/phy-msm-usb.c | 78 > +++--

Re: [PATCH v2 1/7] usb: phy: msm: Move mach depndend code to platform data

2013-07-24 Thread Felipe Balbi
On Wed, Jul 24, 2013 at 03:34:43PM +0300, Felipe Balbi wrote: > On Tue, Jul 09, 2013 at 06:47:07PM +0300, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This patch fix compilation error and is an intermediate step > > before the addition of DeviceTr

Re: [PATCH v2 1/7] usb: phy: msm: Move mach depndend code to platform data

2013-07-24 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 06:47:07PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > This patch fix compilation error and is an intermediate step > before the addition of DeviceTree support for newer targets. > Fix suggested here: https://lkml.org/lkml/2013/6/19/381 > > Cc: David Brown

Re: [PATCH 7/7] usb: phy: msm: Lindent the code

2013-07-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 06:27:44PM +0300, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > > Signed-off-by: Ivan T. Ivanov I really don't

Re: [PATCH 1/7] usb: phy: msm: Move mach dependent code to platform data

2013-07-24 Thread Felipe Balbi
/381 > > Cc: David Brown > Cc: Daniel Walker > Cc: Bryan Huntsman > Cc: Russell King > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: Stephen Boyd > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > > Signed-off-by: Ivan T

Re: [PATCH 03/12] usb: otg: msm: Convert to clk_prepare/unprepare

2013-06-04 Thread Felipe Balbi
Hi, On Tue, Jun 04, 2013 at 12:25:29PM -0700, Stephen Boyd wrote: > Add calls to clk_prepare and unprepare so that MSM can migrate to > the common clock framework. > > Cc: Felipe Balbi > Signed-off-by: Stephen Boyd it's best if this goes with the rest of the series,

Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.

2011-12-21 Thread Felipe Balbi
Hi, On Wed, Dec 21, 2011 at 06:05:26AM -0800, Shimrit Malichi wrote: > > * Shimrit Malichi | 2011-12-07 09:34:33 [-0800]: > > > >> > >>Hi guys, > > Hi, > > > >>Thanks for all your inputs. The good thing is that we now have a better > >>understanding of the UASP implementation that was done offline

Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.

2011-12-07 Thread Felipe Balbi
On Tue, Dec 06, 2011 at 09:09:55AM -0800, Greg KH wrote: > On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: > > > > > On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: > > >> This patch series implements the UAS gadget driver. > > >> > > >> It has been tested using t

Re: [RFC/PATCH v4 1/3] uas: MS UAS Gadget driver - Infrastructure

2011-12-05 Thread Felipe Balbi
Hi, On Sun, Dec 04, 2011 at 10:12:29PM +0200, Shimrit Malichi wrote: > This patch implements the infrastructure for the UAS gadget driver. > The UAS gadget driver registers as a second configuration of the MS > gadet driver. > > A new module parameter was added to the mass_storage module: > bool

Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations

2011-08-11 Thread Felipe Balbi
Hi, On Thu, Aug 11, 2011 at 04:07:18PM +0100, Russell King - ARM Linux wrote: > On Thu, Aug 11, 2011 at 05:15:31PM +0300, Felipe Balbi wrote: > > On Tue, Aug 09, 2011 at 09:08:01AM +0100, Russell King - ARM Linux wrote: > > > diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/

Re: [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations

2011-08-11 Thread Felipe Balbi
On Tue, Aug 09, 2011 at 09:08:01AM +0100, Russell King - ARM Linux wrote: > Consolidate 24 trivial gpiolib implementions out of mach/gpio.h > into asm/gpio.h. This is basically the include of asm-generic/gpio.h > and the definition of gpio_get_value, gpio_set_value, and gpio_cansleep > as describe

Re: [RFC/PATCH 2/3] usb:gadget: Add SuperSpeed function power management

2011-07-28 Thread Felipe Balbi
hi, On Thu, Jul 28, 2011 at 09:15:46AM -0700, Amit Blay wrote: > >> Interface: GET_STATUS & SET_FEATURE(FUNC_SUSPEND). > > > > if it's targeted to an interface, why don't you just let the gadget > > driver handle it ? composite.c tracks all functions already and we > > should just call function->s

Re: [RFC/PATCH 3/3] usb:gadget: SuperSpeed function power management testing support

2011-07-27 Thread Felipe Balbi
On Sun, Jul 03, 2011 at 05:29:33PM +0300, Amit Blay wrote: > 1. Fix dummy_hcd to let the function handle GET_STATUS(Interface) request. > 2. Fix a bug in f_loopback Gadget which updated the bmAttribute of > f_sourcesink instead of f_loopback. > 3. Update f_sourcesink Gadget to support function susp

Re: [RFC/PATCH 2/3] usb:gadget: Add SuperSpeed function power management

2011-07-27 Thread Felipe Balbi
Hi, On Sun, Jul 03, 2011 at 05:29:32PM +0300, Amit Blay wrote: > 1. Add missing definitions in ch9.h for requests tarageted to an typo... s/tarageted/targeted > Interface: GET_STATUS & SET_FEATURE(FUNC_SUSPEND). if it's targeted to an interface, why don't you just let the gadget driver handle i

Re: [RFC/PATCH 1/3] usb: Add SuperSpeed support to g_zero gadget

2011-07-08 Thread Felipe Balbi
Hi, On Sun, Jul 03, 2011 at 05:29:31PM +0300, Amit Blay wrote: > This patch adds SuperSpeed descriptors to the g_zero gadget. > The SuperSpeed descriptors were added both for f_soursesink and f_loopback > configurations of the g_zero gadget. > > Signed-off-by: Tatyana Brokhman > Signed-off-by: A

  1   2   >