;
int nutmrs;
u32 ufs_version;
+ struct ufs_hba_variant_ops *vops;
'const' declaration is expected.
Thanks,
Seungwon Jeon
+ void *priv;
unsigned int irq;
struct uic_command *active_uic_cmd;
@@ -253,8 +283,8 @@ struct ufs_hba {
#define ufshcd_readl(hba, reg
On Wed, July 24, 2013, Sujit Reddy Thumma wrote:
On 7/23/2013 2:04 PM, Seungwon Jeon wrote:
On Sat, July 20, 2013, Sujit Reddy Thumma wrote:
On 7/19/2013 7:28 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
Error handling in UFS driver is broken and resets
On Wed, July 24, 2013, Sujit Reddy Thumma wrote:
On 7/23/2013 1:57 PM, Seungwon Jeon wrote:
On Sat, July 20, 2013, Sujit Reddy Thumma wrote:
On 7/19/2013 7:27 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
As of now SCSI initiated error handling is broken
On Sat, July 20, 2013, Sujit Reddy Thumma wrote:
On 7/19/2013 7:26 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013 Sujit Reddy Thumma wrote:
Currently, sending Task Management (TM) command to the card might
be broken in some scenarios as listed below:
Problem: If there are more than 8 TM
On Sat, July 20, 2013, Sujit Reddy Thumma wrote:
On 7/19/2013 7:27 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
As of now SCSI initiated error handling is broken because,
the reset APIs don't try to bring back the device initialized and
ready for further
On Sat, July 20, 2013, Sujit Reddy Thumma wrote:
On 7/19/2013 7:28 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
Error handling in UFS driver is broken and resets the host controller
for fatal errors without re-initialization. Correct the fatal error
handling
this case should be different.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
Dolev
--
QUALCOMM ISRAEL
into such states.
With your suggestion, when we disable bkops, the exception is raised and
we enable bkops after which there is no way to disable it again?
Yes, it's difficult to find proper time.
Maybe, BKOPS can be disabled when request comes up.
Thanks,
Seungwon Jeon
--
Regards,
Sujit
,
Seungwon Jeon
+ UFS_LOGICAL_RESET, resp);
+ if (err || resp != UPIU_TASK_MANAGEMENT_FUNC_COMPL) {
+ err = FAILED;
goto out;
+ } else {
+ err = SUCCESS;
+ }
for (pos = 0; pos hba-nutrs; pos
= UFSHCD_STATE_OPERATIONAL;
lock is no needed?
Thanks,
Seungwon Jeon
+
+ /* If we are in error handling context no need to scan the host */
+ if (!(ufshcd_device_reset_pending(hba) ||
+ ufshcd_host_reset_pending(hba))) {
+ scsi_scan_host(hba-host
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
There is a possible race condition in the hardware when the abort
command is issued to terminate the ongoing SCSI command as described
below:
- A bit in the door-bell register is set in the controller for a
new SCSI command.
- In some rare
UFSHCD_UIC_DL_PA_INIT_ERROR, it's not fatal. Should it go to fatal_eh?
Thanks,
Seungwon Jeon
goto fatal_eh;
}
+ /*
+ * Other errors are either non-fatal or completed by the
+ * controller by updating OCS fields with success/failure.
+ */
return
then once iff there was an error and the request
was not executed properly.
I wonder that valid result comes after error is happened and retry is taken.
Should we allow the retry in case errors?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body
On Thu, July 11, 2013, Sujit Reddy Thumma wrote:
On 7/10/2013 6:58 PM, Seungwon Jeon wrote:
On Tue, July 09, 2013, Sujit Reddy Thumma wrote:
As part of device initialization sequence, sending NOP OUT UPIU and
waiting for NOP IN UPIU response is mandatory. This confirms that the
device UFS
On Thu, July 11, 2013, Sujit Reddy Thumma wrote:
On 7/10/2013 7:01 PM, Seungwon Jeon wrote:
I'm not sure that BKOPS with runtime-pm associates.
Do you think it's helpful for power management?
How about hibernation scheme for runtime-pm?
I'm testing and I can introduce soon.
Well, I am
along with regular command?
If right, ufshcd_config_int_aggr should not be skipped.
Thanks,
Seungwon Jeon
}
/**
@@ -1432,10 +1795,10 @@ ufshcd_issue_tm_cmd(struct ufs_hba *hba,
task_req_upiup =
(struct utp_upiu_task_req *) task_req_descp-task_req_upiu
is difference between two for-loop?
Thanks,
Seungwon Jeon
+ dev_dbg(hba-dev, %s: error %d retrying\n, __func__,
+ err);
+ }
+ }
+ if (err)
+ dev_err(hba-dev,
+ %s reading fDeviceInit
*query;
+ struct ufs_query_res *response;
+ int err = -ENOMEM;
+
+ if (!attr_val) {
+ dev_err(hba-dev, %s: attribute value required for write
request\n,
It's trivial, but message is only focused on write.
attr_val is also needed in case read request.
Thanks,
Seungwon Jeon
device *dev, struct ufs_hba
**hba_handle,
*hba_handle = hba;
+ /* Hold auto suspend until async scan completes */
What's meaning of comment?
Thanks,
Seungwon Jeon
+ pm_runtime_get_sync(dev);
+
async_schedule(ufshcd_async_scan, hba);
return 0;
--
QUALCOMM
for ufshcd.
' scsi: ufs: add support for query requests' is not merged finally.
I think we can talk with Santosh for those.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Sunday, May 12, 2013, Dolev Raviv wrote:
Author should be identified here. (From: author...)
Except last patch of series(8/8), all of patches are not from you.
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon tgih@samsung.com
Signed-off-by: Dolev Raviv dra
invalid value after current function is out.
Thanks,
Seungwon Jeon
+ }
+
+ if (err retries--) {
+ dev_dbg(hba-dev, %s: error %d retrying\n, __func__, err);
+ goto retry;
+ }
+
+out:
+ if (err)
+ dev_err(hba-dev, %s: NOP OUT failed %d\n
to runtime suspend as such.
Anyway, you have my ack!
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Yes, it's reasonable.
Cache feature is closely connected with eMMC.
Acked-by: Seungwon Jeon tgin@samsung.com
Thanks,
Seungwon Jeon
Kind regards
Ulf Hansson
--
To unsubscribe from this list
in case of IOZONE test.
Depending on user scenario, write can be considered to be important.
It needs to check the starvation of write.
Thanks,
Seungwon Jeon
Hi Chung
The below is my environment:
Kernel Version: linux-3.4
Card: eMMC4.5 (50MHz DDR mode, 8-bit buswidth) Host controller : dw
exceeding 17 requests.
Is it assured that read request doesn't follow immediately after packed write?
I wonder this case.
Thanks,
Seungwon Jeon.
Thanks,
Seungwon Jeon
Thanks,
Maya Erez
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc
25 matches
Mail list logo
