Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-09 Thread Srinivas Kandagatla
On 09/09/15 04:33, Rajendra Nayak wrote: On 09/09/2015 12:51 AM, Stephen Boyd wrote: On 09/07, Rajendra Nayak wrote: Yeah this might happen though because we've assigned the of_node pointer to the tsens device before we register it on the platform bus. The other way to pass that data down f

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-08 Thread Rajendra Nayak
On 09/09/2015 09:03 AM, Rajendra Nayak wrote: On 09/09/2015 12:51 AM, Stephen Boyd wrote: On 09/07, Rajendra Nayak wrote: Yeah this might happen though because we've assigned the of_node pointer to the tsens device before we register it on the platform bus. The other way to pass that data do

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-08 Thread Rajendra Nayak
On 09/09/2015 12:51 AM, Stephen Boyd wrote: On 09/07, Rajendra Nayak wrote: Yeah this might happen though because we've assigned the of_node pointer to the tsens device before we register it on the platform bus. The other way to pass that data down from gcc to tsens would be to not have an of_

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-08 Thread Stephen Boyd
On 09/07, Rajendra Nayak wrote: > > > >Yeah this might happen though because we've assigned the of_node > >pointer to the tsens device before we register it on the platform > >bus. The other way to pass that data down from gcc to tsens would > >be to not have an of_node assigned to the tsens device

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-06 Thread Rajendra Nayak
[].. No. The driver should work just fine without having to interrogate the device's compatible string. If we still need the compatible check for some reason, then we can always match based on qcom,gcc-msm8960, qcom,gcc-apq8064, etc. But I don't see why Thats not quite possible I guess. 2 driv

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-03 Thread Stephen Boyd
On 09/02, Rajendra Nayak wrote: > Stephen, > > >Also, I don't like having a subnode in DT. Why can't we use the > >same node as the GCC node and create a virtual child device here > >for tsens? We can assign the same of_node that this platform > >device has so that DT keeps working

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-09-01 Thread Rajendra Nayak
Stephen, Also, I don't like having a subnode in DT. Why can't we use the same node as the GCC node and create a virtual child device here for tsens? We can assign the same of_node that this platform device has so that DT keeps working correctly. So the current driver looks up data based on com

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-13 Thread Rajendra Nayak
[].. Also, I don't like having a subnode in DT. Why can't we use the same node as the GCC node and create a virtual child device here for tsens? We can assign the same of_node that this platform device has so that DT keeps working correctly. So the current driver looks up data based on compatib

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-13 Thread Stephen Boyd
On 08/12, Bjorn Andersson wrote: > On Wed 12 Aug 14:57 PDT 2015, Stephen Boyd wrote: > > > Here's the patch I'm suggesting. The device name is probably wrong, but > > you get the idea. > > Looks very much like my take on it as well, I do however have concerns > that suddenly the node called "clo

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-13 Thread Stephen Boyd
On 08/13, Rajendra Nayak wrote: > >On 11/08/15 23:49, Stephen Boyd wrote: > >>On 07/08, Rajendra Nayak wrote: > >>>diff --git a/drivers/clk/qcom/gcc-msm8960.c > >>>b/drivers/clk/qcom/gcc-msm8960.c > >>>index eb6a4f9..2c80d03 100644 > >>>--- a/drivers/clk/qcom/gcc-msm8960.c > >>>+++ b/drivers/clk/qc

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-12 Thread Rajendra Nayak
On 11/08/15 23:49, Stephen Boyd wrote: On 07/08, Rajendra Nayak wrote: diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c index eb6a4f9..2c80d03 100644 --- a/drivers/clk/qcom/gcc-msm8960.c +++ b/drivers/clk/qcom/gcc-msm8960.c @@ -15,6 +15,7 @@ #include #include

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-12 Thread Bjorn Andersson
On Wed 12 Aug 14:57 PDT 2015, Stephen Boyd wrote: > On 08/12/2015 01:18 PM, Bjorn Andersson wrote: > > On Tue 11 Aug 15:49 PDT 2015, Stephen Boyd wrote: > > > >> On 07/08, Rajendra Nayak wrote: > >>> diff --git a/drivers/clk/qcom/gcc-msm8960.c > >>> b/drivers/clk/qcom/gcc-msm8960.c > >>> index eb

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-12 Thread Stephen Boyd
On 08/12/2015 01:18 PM, Bjorn Andersson wrote: On Tue 11 Aug 15:49 PDT 2015, Stephen Boyd wrote: On 07/08, Rajendra Nayak wrote: diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c index eb6a4f9..2c80d03 100644 --- a/drivers/clk/qcom/gcc-msm8960.c +++ b/drivers/clk/qco

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-12 Thread Bjorn Andersson
On Tue 11 Aug 15:49 PDT 2015, Stephen Boyd wrote: > On 07/08, Rajendra Nayak wrote: > > diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c > > index eb6a4f9..2c80d03 100644 > > --- a/drivers/clk/qcom/gcc-msm8960.c > > +++ b/drivers/clk/qcom/gcc-msm8960.c > > @@ -15,6 +15,

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-12 Thread Srinivas Kandagatla
On 11/08/15 23:49, Stephen Boyd wrote: On 07/08, Rajendra Nayak wrote: diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c index eb6a4f9..2c80d03 100644 --- a/drivers/clk/qcom/gcc-msm8960.c +++ b/drivers/clk/qcom/gcc-msm8960.c @@ -15,6 +15,7 @@ #include #include

Re: [PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-08-11 Thread Stephen Boyd
On 07/08, Rajendra Nayak wrote: > diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c > index eb6a4f9..2c80d03 100644 > --- a/drivers/clk/qcom/gcc-msm8960.c > +++ b/drivers/clk/qcom/gcc-msm8960.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #in

[PATCH 5/9] clk: qcom: gcc-msm8960: add child devices support.

2015-07-08 Thread Rajendra Nayak
From: Srinivas Kandagatla This patch adds support to add child devices to gcc as some of the registers mapped by gcc are used by things like thermal sensors. Signed-off-by: Srinivas Kandagatla --- drivers/clk/qcom/gcc-msm8960.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --g