Re: [PATCH RFC v2] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-19 Thread Georgi Djakov
Hi Jaehoon, Thank you for noticing this and providing feedback. I will make it use the framework function. BR, Georgi On 08/19/2013 10:27 AM, Jaehoon Chung wrote: Hi Georgi, I found the you use the "vreg->is_enabled". why don't you use the regulator_is_enabled()? i think better that use thi

Re: [PATCH RFC v2] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-19 Thread Jaehoon Chung
Hi Georgi, I found the you use the "vreg->is_enabled". why don't you use the regulator_is_enabled()? i think better that use this function. Is there a special reason that use the "vreg->is_enabled"? Best Regards, Jaehoon Chung On 08/13/2013 11:06 PM, Georgi Djakov wrote: > This platform driver

Re: [PATCH RFC v2] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-16 Thread Georgi Djakov
Hi Ivan, On 08/15/2013 10:22 AM, Ivan T. Ivanov wrote: Hi Georgi, I have several comments below. Shouldn't we add required clocks here? It looks that some of them are optional and others mandatory. Yes, there are various clocks for MMC, SD/SDIO and at least 400mhz must be provided for

Re: [PATCH RFC v2] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-15 Thread Ivan T. Ivanov
Hi Georgi, I have several comments below. On Tue, 2013-08-13 at 17:06 +0300, Georgi Djakov wrote: > This platform driver adds the support of Secure Digital Host > Controller Interface compliant controller in MSM chipsets. > > CC: Asutosh Das > CC: Venkat Gopalakrishnan > CC: Sahitya Tummala

[PATCH RFC v2] mmc: sdhci-msm: Add support for MSM chipsets

2013-08-13 Thread Georgi Djakov
This platform driver adds the support of Secure Digital Host Controller Interface compliant controller in MSM chipsets. CC: Asutosh Das CC: Venkat Gopalakrishnan CC: Sahitya Tummala CC: Subhash Jadavani Signed-off-by: Georgi Djakov --- Changes from v1: - GPIO references are replaced by pinctr