Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-14 Thread Alan Stern
On Tue, 13 Aug 2013, Jack Pham wrote: In addition, we may want some of the work (though at this point I'm not still clear on exactly what parts) to be moved into usbcore. +1. I am open to suggestions on how best to achieve this. I have a another patch in the for doing the same

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-13 Thread Felipe Balbi
On Mon, Aug 12, 2013 at 02:52:33PM -0400, Alan Stern wrote: On Mon, 12 Aug 2013, Felipe Balbi wrote: maybe a single callback for supporting 'testmodes' ? which receives the test mode as argument ? I don't have a clear picture of how you would apply such an approach to this

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-13 Thread Alan Stern
On Tue, 13 Aug 2013, Felipe Balbi wrote: That's not what I meant. Yes, the test-device driver knows what test it wants to run, based on the VID/PID. I was asking how it would communicate this knowledge to the HCD. For example, it doesn't make sense to have a callback that means

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-13 Thread Jack Pham
On Tue, Aug 13, 2013 at 10:32:57AM -0500, Felipe Balbi wrote: On Mon, Aug 12, 2013 at 02:52:33PM -0400, Alan Stern wrote: On Mon, 12 Aug 2013, Felipe Balbi wrote: anything that USB[23]0CV supports today. There are even link layer tests for USB3 and a bunch of others. This

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 11:04:48AM -0400, Alan Stern wrote: heh, it doesn't need to be entirely in the core. Core could have the generic calls and HCDs could implement some callbacks, but I think quite a bit of the code will be similar if we implement the same thing on all

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Felipe Balbi wrote: maybe a single callback for supporting 'testmodes' ? which receives the test mode as argument ? I don't have a clear picture of how you would apply such an approach to this case. There would have to be a way to tell the HCD to insert a

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 05:33:48PM -0400, Alan Stern wrote: On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg KH wrote: On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Felipe Balbi wrote: Wait a minute, didn't we discuss a while back that these test features should be built into usbcore so that we could have a usbcv clone for linux ? There's no way this can be built into the core. This test requires the behavior of the host

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 10:37:50AM -0400, Alan Stern wrote: Wait a minute, didn't we discuss a while back that these test features should be built into usbcore so that we could have a usbcv clone for linux ? There's no way this can be built into the core. This test

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-09 Thread Alan Stern
On Fri, 9 Aug 2013, Felipe Balbi wrote: heh, it doesn't need to be entirely in the core. Core could have the generic calls and HCDs could implement some callbacks, but I think quite a bit of the code will be similar if we implement the same thing on all HCDs. What generic calls

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Greg KH
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 2) The host

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg KH wrote: On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: 1) The host enumerates the test

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: On Thu, 25 Jul 2013, Greg KH wrote: On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Jack Pham
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index 2b70277..8e6dc09 100644 ---

[RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-02 Thread Jack Pham
From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 2) The host sends the SETUP stage of a GetDescriptor(Device) 3) The device