Re: [RFC/PATCH v2] usb: Add streams support to epautoconf.

2010-12-27 Thread merez
On Wed, Dec 22, 2010 at 03:58AM, Maya Erez wrote: We beleive that the chip-specific code for net2280 and goku at the beginning of usb_ep_autoconfig can be moved to this new gadget op, therefore it is also needed for today's implementation. I will do the cahnge and send a new patch for review

Re: [RFC/PATCH v2] usb: Add streams support to epautoconf.

2010-12-22 Thread merez
On Tue, Dec 21, 2010 at 09:58AM, Greg KH wrote: First rule of kernel development, don't add infrastructure that you do not need today. We beleive that the chip-specific code for net2280 and goku at the beginning of usb_ep_autoconfig can be moved to this new gadget op, therefore it is also

Re: [RFC/PATCH v2] usb: Add streams support to epautoconf.

2010-12-21 Thread merez
On Mon, Dec 20, 2010 at 11:58AM, Greg KH wrote: Ok, but please note the word of proprietary usually means something else when talking about kernel code (i.e. licensing issues.) I'll be glad to take this type of patch when you also provide a patch that uses the callback, but not before then.

Re: [RFC/PATCH v2] usb: Add streams support to epautoconf.

2010-12-20 Thread merez
On Thu, Dec 16, 2010 at 10:15AM, Greg KH wrote: What do you exactly mean by proprietary search algorithm? Our implementation for finding an EP with the required number of streams may not fit the needs and platform definitions of all controllers. For example, having the minimum number of streams