Re: [PATCH] regulator: Update consumer state only after set voltage succeeds.

2010-12-20 Thread Mark Brown
On Fri, Dec 17, 2010 at 02:44:28PM -0800, Saravana Kannan wrote: > static int regulator_check_consumers(struct regulator_dev *rdev, > + struct regulator *ignore, >int *min_uV, int *max_uV) This feels really invasive, and prone

Re: [PATCH] regulator: Update consumer state only after set voltage succeeds.

2010-12-20 Thread Saravana Kannan
On 12/20/10 04:39, Mark Brown wrote: On Fri, Dec 17, 2010 at 02:44:28PM -0800, Saravana Kannan wrote: static int regulator_check_consumers(struct regulator_dev *rdev, +struct regulator *ignore, int *min_uV, int *max_uV)

Re: [PATCH] regulator: Update consumer state only after set voltage succeeds.

2010-12-21 Thread Mark Brown
On Mon, Dec 20, 2010 at 02:27:40PM -0800, Saravana Kannan wrote: > I agree it looks a bit odd and I'm willing to do the code reorg if > there is a better way. But I definitely wouldn't call this as See the suggestion I made in the previous mail - try doing it by making the change, then backing it