Re: [PATCH v3 04/10] spmi: Add MSM PMIC Arbiter SPMI controller

2013-10-30 Thread Josh Cartwright
On Wed, Oct 30, 2013 at 11:05:36AM -0700, Stephen Boyd wrote: > On 10/28, Josh Cartwright wrote: > > + > > +/** > > + * pa_write_data: write 1..4 bytes from buf to pmic-arb's register > > + * @bc byte-count -1. range: 0..3 > > + * @reg register's address > > + * @buf buffer to write. length must be

Re: [PATCH v3 04/10] spmi: Add MSM PMIC Arbiter SPMI controller

2013-10-30 Thread Stephen Boyd
On 10/28, Josh Cartwright wrote: > + > +/** > + * pa_write_data: write 1..4 bytes from buf to pmic-arb's register > + * @bc byte-count -1. range: 0..3 > + * @reg register's address > + * @buf buffer to write. length must be bc+1 Missing colon between variable and description. > + */ > +static voi