Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Fons Adriaensen
On Tue, Aug 11, 2015 at 09:23:28PM +0100, Simon Jenkins wrote: I wrote that comment whilst implementing what the list agreed was the best way to deal with cycles in the graph. Its not “how the sort works” so much as “how we fudged the sort to deal with cycles”. Indeed. I think the

Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Fons Adriaensen
On Mon, Aug 10, 2015 at 04:43:01PM -0400, Paul Davis wrote: it provides output indicating the logic decisions that lead to the execution order. I spent most of the day trying to convinve myself that I was overlooking something. But in the end the conclusion of all that work is this: * The

Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Paul Davis
That said, we became aware that a similar algorithm, implemented by Torben Hohn when he parallelized Ardour, that forms part of the Ardour DSP engine was also flawed and was replaced with topological sorting within the last couple of years. On Tue, Aug 11, 2015 at 2:39 PM, Paul Davis

Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Paul Davis
To follow up, Ardour explicitly builds a DAG and uses a topo sort. The change was never made to Jack1 because of a lack of time (even time to just verify that it had the same issue, even though that seemed likely). I also want to make it clear that my previous reference to Torben wasn't intended

Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Simon Jenkins
On 11 Aug 2015, at 19:48, Fons Adriaensen f...@linuxaudio.org wrote: Simon (last name forgotten right now) added a variation on topological sort years ago, specifically to deal with some issues. His comment was: /* How the sort works: ... ??? Fons, I wrote that comment whilst

Re: [LAD] Strange Jack1 problem

2015-08-11 Thread Paul Davis
Although it pains me to say it, I think the simple fact is that none of the people close enough to the code understood that we need to use topological sort. When we ran into problem inside Ardour in 2011, we came to realize that toposort was the standard solution for this, but back in 2001-2004,