[LAD] library soname, was Re: Rubber Band Library v3.0.0 released

2022-07-28 Thread Chris Cannam
On Fri, 15 Jul 2022, at 23:02, Robin Gareus wrote: > Congrats on the release and thanks for the very informative blog post. Thank you! > https://hg.sr.ht/~breakfastquay/rubberband/browse/rubberband.pc.in?rev=v3.0.0 > > states Version: 1.8.2 (not 3.0.0). > The ABI version of the shared object is

Re: [LAD] library soname, was Re: Rubber Band Library v3.0.0 released

2022-07-28 Thread Fons Adriaensen
On Thu, Jul 28, 2022 at 02:52:03PM +0100, Chris Cannam wrote: > This implies that if you add a function, you need not change the soname. In this case you didn't just add a function, but a completely new and improved algorithm. That's reason enough to increment the major version, even if only for

Re: [LAD] library soname, was Re: Rubber Band Library v3.0.0 released

2022-07-28 Thread Chris Cannam
On Thu, 28 Jul 2022, at 15:26, Fons Adriaensen wrote: > In this case you didn't just add a function, but a completely new and > improved algorithm. That's reason enough to increment the major version, > even if only for 'marketing'. And more so if you also offer a commercial > license. I guess yo

Re: [LAD] library soname, was Re: Rubber Band Library v3.0.0 released

2022-07-28 Thread Robin Gareus
On 7/28/22 15:52, Chris Cannam wrote: > > The version in the .pc file is written in at install time, Except, it isn't. $PREFIX/lib/pkgconfig/rubberband.pc here has Version: 1.8.2 for rubberband v3.0.0 the .pc.in file likely needs a placeholder %VERSION% so that it is replaced at install time. >

Re: [LAD] library soname, was Re: Rubber Band Library v3.0.0 released

2022-07-28 Thread Chris Cannam
On Thu, 28 Jul 2022, at 17:06, Robin Gareus wrote: > On 7/28/22 15:52, Chris Cannam wrote: >> >> The version in the .pc file is written in at install time, > > Except, it isn't. $PREFIX/lib/pkgconfig/rubberband.pc here has Version: > 1.8.2 for rubberband v3.0.0 Oops. How are you installing? If I