Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-07-05 Thread Paul Coccoli
On 6/26/06, Jack O'Quin <[EMAIL PROTECTED]> wrote: OK, I see it now. All those uninitialized write complaints are due to the fact that jack_request_t is a union. Most requests don't need (or want) to fill in all the bytes, just the ones that matter for that RequestType. There are jack_request_

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-26 Thread Jack O'Quin
On 6/26/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: On Mon, 26 Jun, 2006 at 10:16AM -0500, Jack O'Quin spake thus: > libjack seems OK already, but there was an unitialied char > written by jackd. I fixed that and committed it as [0.102.18]. > > I don't have valgrind set up correctly on my n

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-26 Thread james
On Mon, 26 Jun, 2006 at 10:16AM -0500, Jack O'Quin spake thus: > On 6/25/06, Dave Robillard <[EMAIL PROTECTED]> wrote: > >On Sun, 2006-06-25 at 16:49 -0400, Lee Revell wrote: > >> On Sun, 2006-06-25 at 16:34 -0400, Dave Robillard wrote: > >> > On Sun, 2006-06-25 at 10:29 +1000, Erik de Castro Lopo

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-26 Thread Jack O'Quin
On 6/25/06, Dave Robillard <[EMAIL PROTECTED]> wrote: On Sun, 2006-06-25 at 16:49 -0400, Lee Revell wrote: > On Sun, 2006-06-25 at 16:34 -0400, Dave Robillard wrote: > > On Sun, 2006-06-25 at 10:29 +1000, Erik de Castro Lopo wrote: > > > Regardless of whether this is a bug or not it would be real

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-25 Thread Dave Robillard
On Sun, 2006-06-25 at 16:49 -0400, Lee Revell wrote: > On Sun, 2006-06-25 at 16:34 -0400, Dave Robillard wrote: > > On Sun, 2006-06-25 at 10:29 +1000, Erik de Castro Lopo wrote: > > > Paul Davis wrote: > > > > > > > they don't matter. they are the result of writing a byte to a FIFO to > > > > wake

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-25 Thread Erik de Castro Lopo
Lee Revell wrote: > I have not looked closely at the code, but could it be considered an > information leak if you're using a byte of unitialized data? If that data is an automatic (ie stack) variable, then yes. Erik -- +---+ Erik de Cas

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-25 Thread Lee Revell
On Sun, 2006-06-25 at 16:34 -0400, Dave Robillard wrote: > On Sun, 2006-06-25 at 10:29 +1000, Erik de Castro Lopo wrote: > > Paul Davis wrote: > > > > > they don't matter. they are the result of writing a byte to a FIFO to > > > wake up an(other) client. the contents of the byte do not make any >

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-25 Thread Dave Robillard
On Sun, 2006-06-25 at 10:29 +1000, Erik de Castro Lopo wrote: > Paul Davis wrote: > > > they don't matter. they are the result of writing a byte to a FIFO to > > wake up an(other) client. the contents of the byte do not make any > > difference at any point. > > > Regardless of whether this is a

Re: [Jackit-devel] [linux-audio-dev] What valgrind says

2006-06-24 Thread Erik de Castro Lopo
Paul Davis wrote: > they don't matter. they are the result of writing a byte to a FIFO to > wake up an(other) client. the contents of the byte do not make any > difference at any point. Regardless of whether this is a bug or not it would be really nice if this could be fixed. Fixing it means tha