[PATCH] dist target fixes

2007-07-30 Thread John D. Ramsdell
Steve, I discovered a few more files that are being mistakenly omitted when using the dist target. John Only in b/audit-1.5.6: ab.diff Only in b/audit-1.5.6: ac.diff Only in b/audit-1.5.6: aclocal.m4 Only in b/audit-1.5.6/audisp: Makefile Only in b/audit-1.5.6/audisp: Makefile.in Only in b/audit

Re: [2.6 patch] kernel/audit.c: change the exports to EXPORT_SYMBOL_GPL

2007-07-30 Thread Steve Grubb
On Sunday 29 July 2007 11:02:33 Adrian Bunk wrote: > They are still completely unused, but hopefully some of the theoretical > code that might use it will appear in the kernel in the near future... > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > Acked-by: Steve Grubb <[EMAIL PROTECTED]> I am

Re: [2.6 patch] kernel/audit.c: change the exports to EXPORT_SYMBOL_GPL

2007-07-30 Thread Adrian Bunk
On Mon, Jul 30, 2007 at 09:18:41AM -0400, Steve Grubb wrote: > On Sunday 29 July 2007 11:02:33 Adrian Bunk wrote: > > They are still completely unused, but hopefully some of the theoretical > > code that might use it will appear in the kernel in the near future... > > > > Signed-off-by: Adrian Bunk

selinux_audit_set_callback

2007-07-30 Thread Casey Schaufler
What is the rationale behind the selinux_audit_set_callback() mechanism? It looks for all the world as if the selinux code ought to be able to call the registered function directly. Casey Schaufler [EMAIL PROTECTED] -- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailm

Re: [PATCH] dist target fixes

2007-07-30 Thread Miloslav Trmac
Hello, John D. Ramsdell napsal(a): > diff -ur a/audit-1.5.6/Makefile.am b/audit-1.5.6/Makefile.am > --- a/audit-1.5.6/Makefile.am 2007-06-27 06:19:18.0 -0400 > +++ b/audit-1.5.6/Makefile.am 2007-07-30 07:53:45.0 -0400 > @@ -21,9 +21,14 @@ > # Rickard E. (Rik) Faith <[EMAIL PROTEC

Re: selinux_audit_set_callback

2007-07-30 Thread Stephen Smalley
On Mon, 2007-07-30 at 07:24 -0700, Casey Schaufler wrote: > What is the rationale behind the selinux_audit_set_callback() > mechanism? It looks for all the world as if the selinux code > ought to be able to call the registered function directly. Looks like it is a legacy of when the callback was a

Re: [PATCH] dist target fixes

2007-07-30 Thread John D. Ramsdell
Miloslav Trmac <[EMAIL PROTECTED]> writes: ... > system-config-audit.lang is generated by %install when building the rpm, > and should not be in the tarball at all. ... > A better solution is to change s-c-audit/autogen.sh (and to distribute > the autogen.sh files): I changed audit/system-config-

Re: [PATCH] dist target fixes

2007-07-30 Thread Miloslav Trmac
John D. Ramsdell napsal(a): > I changed audit/system-config-audit/autogen.sh as you suggested, but > the tarball created with "make dist" contains no .m4 files. Have you executed the new autogen.sh? What automake version to you use? Mirek -- Linux-audit mailing list Linux-audit@redhat.com

Re: [PATCH] dist target fixes

2007-07-30 Thread John D. Ramsdell
Miloslav Trmac <[EMAIL PROTECTED]> writes: > Have you executed the new autogen.sh? Between changes, I've been performing: $ aclocal && autoconf && autoheader && automake $ ./configure $ make dist The first line is from audit.spec, so I assume it is correct. > What automake version to you use?

Re: [PATCH] dist target fixes

2007-07-30 Thread Miloslav Trmac
John D. Ramsdell napsal(a): > Miloslav Trmac <[EMAIL PROTECTED]> writes: > >> Have you executed the new autogen.sh? > > Between changes, I've been performing: > > $ aclocal && autoconf && autoheader && automake > $ ./configure > $ make dist > > The first line is from audit.spec, so I assume it

Re: [PATCH] dist target fixes

2007-07-30 Thread John D. Ramsdell
Miloslav Trmac <[EMAIL PROTECTED]> writes: > Use the top-level autogen.sh instead, please. This worked, and I notice that with the changes to system-config-audit/autogen.sh you suggested earlier, fewer M4 files are placed in the distribution. I also notice quite a few warning messages. [EMAIL P

Re: [PATCH] dist target fixes

2007-07-30 Thread Miloslav Trmac
John D. Ramsdell napsal(a): > Miloslav Trmac <[EMAIL PROTECTED]> writes: >> Use the top-level autogen.sh instead, please. > > This worked, and I notice that with the changes to > system-config-audit/autogen.sh you suggested earlier, fewer M4 files > are placed in the distribution. That is expected

Re: [PATCH] dist target fixes

2007-07-30 Thread John D. Ramsdell
Miloslav Trmac <[EMAIL PROTECTED]> writes: > Use the top-level autogen.sh instead, please. I think I've gotten myself in over my head. I tried to create a new dist target fixes patch, but the patch is huge. Running the top-level autogen.sh results in differences in a large number of derived fil