Re: [PATCH 1/7] audit: implement generic feature setting and retrieving

2013-11-02 Thread Richard Guy Briggs
On Fri, May 24, 2013 at 12:11:44PM -0400, Eric Paris wrote: > The audit_status structure was not designed with extensibility in mind. > Define a new AUDIT_SET_FEATURE message type which takes a new structure > of bits where things can be enabled/disabled/locked one at a time. This > structure shou

[PATCH v2] audit: fix incorrect type of sessionid

2013-11-02 Thread Gao feng
The type of task->sessionid is unsigned int, the return type of audit_get_sessionid should be consistent with it. And this patch also changes the type of oldsessionid to unsigned int. Signed-off-by: Gao feng --- include/linux/audit.h | 4 ++-- kernel/auditsc.c | 3 ++- 2 files changed, 4 i

Re: [PATCH 1/7] audit: implement generic feature setting and retrieving

2013-11-02 Thread Eric Paris
On Sat, 2013-11-02 at 03:26 -0400, Richard Guy Briggs wrote: > On Fri, May 24, 2013 at 12:11:44PM -0400, Eric Paris wrote: > > The audit_status structure was not designed with extensibility in mind. > > Define a new AUDIT_SET_FEATURE message type which takes a new structure > > of bits where things

Re: [PATCH v2] audit: fix incorrect type of sessionid

2013-11-02 Thread Richard Guy Briggs
On Sat, Nov 02, 2013 at 02:45:02PM +0800, Gao feng wrote: > The type of task->sessionid is unsigned int, the return > type of audit_get_sessionid should be consistent with it. > > And this patch also changes the type of oldsessionid to > unsigned int. Looks good, thanks! > Signed-off-by: Gao fen