unbind [was: Re: [PATCH] netlink: have netlink per-protocol bind function return] an error code.

2014-03-25 Thread Richard Guy Briggs
On 14/03/24, Richard Guy Briggs wrote: > On 14/03/24, Richard Guy Briggs wrote: > > On 14/03/23, David Miller wrote: > > > From: Richard Guy Briggs > > > Date: Fri, 21 Mar 2014 12:39:11 -0400 Ok, sorry for all the noise. I had a problem between chair and keyboard which can explain the number of

[PATCH][v6] netlink: have netlink per-protocol bind function return an error code.

2014-03-25 Thread Richard Guy Briggs
Have the netlink per-protocol optional bind function return an int error code rather than void to signal a failure. This will enable netlink protocols to perform extra checks including capabilities and permissions verifications when updating memberships in multicast groups. In netlink_bind() and

Re: [PATCH] netlink: simplify nfnetlink_bind

2014-03-25 Thread Pablo Neira Ayuso
On Fri, Mar 21, 2014 at 12:44:09PM -0400, Richard Guy Briggs wrote: > Remove duplicity and simplify code flow by moving the rcu_read_unlock() above > the condition and let the flow control exit naturally at the end of the > function. > > Signed-off-by: Richard Guy Briggs > --- > net/netfilter/nf

Re: [PATCH 4/4] ARCH: AUDIT: audit_syscall_entry() should not require the arch

2014-03-25 Thread Richard Guy Briggs
On 14/03/19, Eric Paris wrote: > We have a function where the arch can be queried, syscall_get_arch(). > So rather than have every single piece of arch specific code use and/or > duplicate syscall_get_arch(), just have the audit code use the > syscall_get_arch() code. > > Signed-off-by: Eric Paris