Re: [PATCH ghak90 V5 05/10] audit: add containerid support for ptrace and signals

2019-03-27 Thread Richard Guy Briggs
On 2019-03-27 22:17, Ondrej Mosnacek wrote: > On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > > Add audit container identifier support to ptrace and signals. In > > particular, the "ref" field provides a way to label the auxiliary record > > to which it is associated. > > > >

Re: [PATCH ghak90 V5 09/10] audit: add support for containerid to network namespaces

2019-03-27 Thread Richard Guy Briggs
On 2019-03-27 23:42, Ondrej Mosnacek wrote: > On Fri, Mar 15, 2019 at 7:35 PM Richard Guy Briggs wrote: > > Audit events could happen in a network namespace outside of a task > > context due to packets received from the net that trigger an auditing > > rule prior to being associated with a

Re: [RFC PATCH ghak10 v6 0/2] audit: Log changes that can affect the system clock

2019-03-27 Thread Paul Moore
On Mon, Mar 25, 2019 at 10:50 AM Paul Moore wrote: > On Thu, Mar 7, 2019 at 7:33 AM Ondrej Mosnacek wrote: > > This patchset implements auditing of (syscall-triggered) changes that > > can modify or indirectly affect the system clock. Some of these > > changes can already be detected by simply

Re: [PATCH ghak90 V5 10/10] audit: NETFILTER_PKT: record each container ID associated with a netNS

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:35 PM Richard Guy Briggs wrote: > Add audit container identifier auxiliary record(s) to NETFILTER_PKT > event standalone records. Iterate through all potential audit container > identifiers associated with a network namespace. > > Signed-off-by: Richard Guy Briggs

Re: [PATCH ghak90 V5 09/10] audit: add support for containerid to network namespaces

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:35 PM Richard Guy Briggs wrote: > Audit events could happen in a network namespace outside of a task > context due to packets received from the net that trigger an auditing > rule prior to being associated with a running task. The network > namespace could be in use by

Re: [PATCH ghak109 V2] audit: link integrity evm_write_xattrs record to syscall event

2019-03-27 Thread Paul Moore
On Wed, Mar 27, 2019 at 11:05 AM Mimi Zohar wrote: > On Tue, 2019-03-26 at 19:58 -0400, Paul Moore wrote: > > On Tue, Mar 26, 2019 at 4:40 PM Mimi Zohar wrote: > > > > > > Hi Richard, Paul, > > > > > > On Tue, 2019-03-26 at 14:49 -0400, Richard Guy Briggs wrote: > > > > In commit fa516b66a1bf

Re: [PATCH ghak90 V5 04/10] audit: log container info of syscalls

2019-03-27 Thread Richard Guy Briggs
On 2019-03-27 22:01, Ondrej Mosnacek wrote: > On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > > Create a new audit record AUDIT_CONTAINER_ID to document the audit > > container identifier of a process if it is present. > > > > Called from audit_log_exit(), syscalls are covered. > > >

Re: [PATCH ghak90 V5 08/10] audit: add containerid filtering

2019-03-27 Thread Richard Guy Briggs
On 2019-03-27 22:41, Ondrej Mosnacek wrote: > On Tue, Mar 19, 2019 at 12:47 AM Richard Guy Briggs wrote: > > On 2019-03-18 21:02, Ondrej Mosnacek wrote: > > > On Fri, Mar 15, 2019 at 7:35 PM Richard Guy Briggs > > > wrote: > > > > > > > > Implement audit container identifier filtering using the

Re: [PATCH ghak90 V5 08/10] audit: add containerid filtering

2019-03-27 Thread Ondrej Mosnacek
On Tue, Mar 19, 2019 at 12:47 AM Richard Guy Briggs wrote: > On 2019-03-18 21:02, Ondrej Mosnacek wrote: > > On Fri, Mar 15, 2019 at 7:35 PM Richard Guy Briggs wrote: > > > > > > Implement audit container identifier filtering using the AUDIT_CONTID > > > field name to send an 8-character string

Re: [PATCH ghak90 V5 07/10] audit: add containerid support for user records

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > Add audit container identifier auxiliary record to user event standalone > records. > > Signed-off-by: Richard Guy Briggs Reviewed-by: Ondrej Mosnacek > --- > kernel/audit.c | 13 ++--- > 1 file changed, 6 insertions(+), 7

Re: [PATCH ghak90 V5 06/10] audit: add support for non-syscall auxiliary records

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > Standalone audit records have the timestamp and serial number generated > on the fly and as such are unique, making them standalone. This new > function audit_alloc_local() generates a local audit context that will > be used only for a

Re: [PATCH ghak90 V5 05/10] audit: add containerid support for ptrace and signals

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > Add audit container identifier support to ptrace and signals. In > particular, the "ref" field provides a way to label the auxiliary record > to which it is associated. > > Signed-off-by: Richard Guy Briggs > Acked-by: Serge Hallyn >

Re: [PATCH ghak90 V5 04/10] audit: log container info of syscalls

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:34 PM Richard Guy Briggs wrote: > Create a new audit record AUDIT_CONTAINER_ID to document the audit > container identifier of a process if it is present. > > Called from audit_log_exit(), syscalls are covered. > > A sample raw event: > type=SYSCALL

Re: [PATCH ghak90 V5 02/10] audit: add container id

2019-03-27 Thread Richard Guy Briggs
On 2019-03-27 21:38, Ondrej Mosnacek wrote: > On Fri, Mar 15, 2019 at 7:33 PM Richard Guy Briggs wrote: > > Implement the proc fs write to set the audit container identifier of a > > process, emitting an AUDIT_CONTAINER_OP record to document the event. > > > > This is a write from the container

Re: [PATCH ghak90 V5 02/10] audit: add container id

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:33 PM Richard Guy Briggs wrote: > Implement the proc fs write to set the audit container identifier of a > process, emitting an AUDIT_CONTAINER_OP record to document the event. > > This is a write from the container orchestrator task to a proc entry of > the form

Re: [PATCH ghak90 V5 01/10] audit: collect audit task parameters

2019-03-27 Thread Ondrej Mosnacek
On Fri, Mar 15, 2019 at 7:33 PM Richard Guy Briggs wrote: > The audit-related parameters in struct task_struct should ideally be > collected together and accessed through a standard audit API. > > Collect the existing loginuid, sessionid and audit_context together in a > new struct

Re: [PATCH ghak109 V2] audit: link integrity evm_write_xattrs record to syscall event

2019-03-27 Thread Mimi Zohar
On Tue, 2019-03-26 at 19:58 -0400, Paul Moore wrote: > On Tue, Mar 26, 2019 at 4:40 PM Mimi Zohar wrote: > > > > Hi Richard, Paul, > > > > On Tue, 2019-03-26 at 14:49 -0400, Richard Guy Briggs wrote: > > > In commit fa516b66a1bf ("EVM: Allow runtime modification of the set of > > > verified