Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

On 2016年07月06日 09:28, Masashi Honma wrote: > Though netlink_broadcast() ... Thanks for reply of David Miller, Eric Dumazet, David Teigrand. On the basis of their comment, only rtnl_unicast() looks need to add gfp flag argument. So I will drop almost of patches except 0005. I will send patch

Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

On 2016年07月09日 01:08, David Teigland wrote: On Thu, Jul 07, 2016 at 09:35:45AM +0900, Masashi Honma wrote: At the fs/dlm/netlink.c#dlm_timeout_warn(), prepare_data allocates buffer with GFP_NOFS and send_data() sends the buffer. But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. Should

Re: [RFC 5/7] net: Add allocation flag to rtnl_unicast()

On 2016年07月08日 11:56, Eric Dumazet wrote: Managing to mix GFP_ATOMIC and GFP_KERNEL almost randomly as you did in this patch is definitely not good. Further more, RTNL is a mutex, held in control path, designed to allow schedules and waiting for memory under pressure. We do not want to encoura

Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

At the fs/dlm/netlink.c#dlm_timeout_warn(), prepare_data allocates buffer with GFP_NOFS and send_data() sends the buffer. But send_data() uses GFP_KERNEL or GFP_ATOMIC inside it. Should it be replaced by GFP_NOFS ? Masashi Honma -- Linux-audit mailing list Linux-audit@redhat.com https

[RFC 6/7] genetlink: Add allocation flag to genlmsg_unicast()

Signed-off-by: Masashi Honma --- drivers/net/gtp.c | 3 ++- drivers/net/team/team.c | 5 +++-- drivers/net/wireless/mac80211_hwsim.c | 2 +- fs/dlm/netlink.c | 2 +- include/net/genetlink.h | 8 +--- kernel/taskstats.c

[RFC 7/7] genetlink: Add allocation flag to genlmsg_reply()

Add allocation flag to genlmsg_reply() and remove netlink_unicast() temporal functionality for stepwise modification. Signed-off-by: Masashi Honma --- drivers/block/drbd/drbd_nl.c | 2 +- drivers/net/wireless/mac80211_hwsim.c | 2 +- include/net/genetlink.h | 7

[RFC 2/7] netfilter: Add allocation flag to nfnetlink_unicast()

Signed-off-by: Masashi Honma --- include/linux/netfilter/nfnetlink.h | 2 +- net/netfilter/nfnetlink.c | 4 ++-- net/netfilter/nfnetlink_log.c | 4 ++-- net/netfilter/nfnetlink_queue.c | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/include/linux

[RFC 3/7] netlink: Add allocation flag to nlmsg_unicast()

Signed-off-by: Masashi Honma --- crypto/crypto_user.c | 3 ++- drivers/infiniband/core/netlink.c | 2 +- include/net/genetlink.h | 2 +- include/net/netlink.h | 6 -- net/core/rtnetlink.c | 2 +- net/netfilter/nf_tables_api.c | 10

[RFC 0/7] netlink: Add allocation flag to netlink_unicast()

y guessing based on context. If we could not determine the value, we remain it gfp_any(). We welcome comments like "this gfp_any() should be GFP_KERNEL". Of course other comments are welcome as well. This series of patches are not tested. This is a RFC because this does not fix existing issu

[RFC 4/7] infiniband: Add allocation flag to ibnl_unicast()

Signed-off-by: Masashi Honma --- drivers/infiniband/core/iwpm_msg.c | 6 +++--- drivers/infiniband/core/iwpm_util.c | 5 +++-- drivers/infiniband/core/iwpm_util.h | 1 + drivers/infiniband/core/netlink.c | 4 ++-- include/rdma/rdma_netlink.h | 3 ++- 5 files changed, 11 insertions

[RFC 5/7] net: Add allocation flag to rtnl_unicast()

Signed-off-by: Masashi Honma --- include/linux/rtnetlink.h | 3 ++- net/core/net_namespace.c | 2 +- net/core/rtnetlink.c | 10 ++ net/dcb/dcbnl.c | 2 +- net/decnet/dn_route.c | 3 ++- net/ipv4/devinet.c| 2 +- net/ipv4/ipmr.c | 6 -- net

[RFC 1/7] netlink: Add allocation flag to netlink_unicast()

ned-off-by: Masashi Honma --- drivers/connector/connector.c| 2 +- include/linux/netlink.h | 3 ++- include/net/netlink.h| 2 +- kernel/audit.c | 9 + net/core/rtnetlink.c | 2 +- net/ipv4/fib_frontend.c