[PATCH 0/3] Misc build fixes

2016-07-06 Thread Thomas Petazzoni
ng to switch back to Subversion is really painful, which is why the patches in this series are Git-formatted. Thanks! Thomas Thomas Petazzoni (3): lib/gen_tables.c: define EHWPOISON when not available Fix usage of audit_status.feature_bitmap configure.ac: add subdir-objects configure.ac

[PATCH 1/3] lib/gen_tables.c: define EHWPOISON when not available

2016-07-06 Thread Thomas Petazzoni
whole concept of building a program on the host to generate a table with errno values, then built into a target program is inherently broken, so our fix is not more broken than the rest of the mechanism used by audit. Signed-off-by: Thomas Petazzoni --- lib/gen_tables.c | 9 + 1 file chang

[PATCH 3/3] configure.ac: add subdir-objects

2016-07-06 Thread Thomas Petazzoni
This allows to avoid the following warning when re-generating the configure script: auparse/Makefile.am:95: warning: source file '../lib/gen_tables.c' is in a subdirectory, auparse/Makefile.am:95: but option 'subdir-objects' is disabled Signed-off-by: Thomas Petazzoni -

[PATCH 2/3] Fix usage of audit_status.feature_bitmap

2016-07-06 Thread Thomas Petazzoni
^ libaudit.c: In function 'audit_rule_fieldpair_data': libaudit.c:1424:9: warning: this decimal constant is unsigned only in ISO C90 [enabled by default] 4294967295; This commit fixes that by testing the availability of the feature_bitmap field. Signed-off-by: Thomas Petazzoni --- Note

Re: [PATCH 0/3] Misc build fixes

2016-07-07 Thread Thomas Petazzoni
Hello, On Wed, 06 Jul 2016 18:45:28 -0400, Steve Grubb wrote: > On Wednesday, July 6, 2016 9:08:16 PM EDT Thomas Petazzoni wrote: > > The first two patches in this series fix misc build issues of audit > > with old kernel headers. > > I applied both. The second patch

Re: Missing linker flags when statically linking

2016-07-10 Thread Thomas Petazzoni
s already linked to libcap-ng. > > I was talking about Package*.private* not package itself. > Package.private is the equivalent to Libs.private but for libs that also > have a .pc file Agreed. When possible, Package.private should be preferred over Libs.private. Thomas -- Thomas P

Re: [PATCH 3/3] configure.ac: add subdir-objects

2016-07-11 Thread Thomas Petazzoni
1.16 when a variable is used in _SOURCES. I've fixed that in v2 by using a simpler relative path in the Python bindings Makefile.am. Patch coming shortly. Thanks for spotting the issue, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering htt

[PATCH v2] configure.ac: add subdir-objects

2016-07-11 Thread Thomas Petazzoni
id a bug in automake < 1.16, we have to adjust two Makefile.am, to use a relative path rather in _SOURCES rather than a path that uses $(top_srcdir). Indeed, $(top_srcdir) was not properly expanded when used in _SOURCES in automake versions < 1.16. Signed-off-by: Thomas Petazzoni --- bindings/

Re: [PATCH 3/3] configure.ac: add subdir-objects

2016-07-11 Thread Thomas Petazzoni
ng shortly. > > > > Thanks for spotting the issue, > > I always run "make distcheck" when doing a release. If v2 passes this, then > all is good. Well, this raises another issue: /bin/bash: ../../../../src/.dirstamp: Permission denied So seems like my v2