Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-11 Thread Paul Moore
On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: > strnlen_user() returns 0 when it hits fault, not -1. Fix the test in > audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless > there's a kernel bug so it's mostly a cosmetic fix. > > CC: Paul Moore > Signed-off-by: Jan Kar

Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-05 Thread Jan Kara
On Thu 04-06-15 09:18:49, Paul Moore wrote: > On Thu, Jun 4, 2015 at 3:36 AM, Jan Kara wrote: > > On Wed 03-06-15 14:56:18, Paul Moore wrote: > >> On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: > >> > strnlen_user() returns 0 when it hits fault, not -1. Fix the test in > >> > audit_log_sing

Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-04 Thread Paul Moore
On Thu, Jun 4, 2015 at 5:32 PM, Jan Kara wrote: > On Thu 04-06-15 09:18:49, Paul Moore wrote: >> On Thu, Jun 4, 2015 at 3:36 AM, Jan Kara wrote: >> > On Wed 03-06-15 14:56:18, Paul Moore wrote: >> >> On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: >> >> > strnlen_user() returns 0 when it hi

Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-04 Thread Paul Moore
On Thu, Jun 4, 2015 at 3:36 AM, Jan Kara wrote: > On Wed 03-06-15 14:56:18, Paul Moore wrote: >> On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: >> > strnlen_user() returns 0 when it hits fault, not -1. Fix the test in >> > audit_log_single_execve_arg(). Luckily this shouldn't ever happen un

Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-04 Thread Jan Kara
On Wed 03-06-15 14:56:18, Paul Moore wrote: > On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: > > strnlen_user() returns 0 when it hits fault, not -1. Fix the test in > > audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless > > there's a kernel bug so it's mostly a cosmeti

Re: [PATCH] audit: Fix check of return value of strnlen_user()

2015-06-03 Thread Paul Moore
On Tuesday, June 02, 2015 05:08:29 PM Jan Kara wrote: > strnlen_user() returns 0 when it hits fault, not -1. Fix the test in > audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless > there's a kernel bug so it's mostly a cosmetic fix. > > CC: Paul Moore > Signed-off-by: Jan Kar

[PATCH] audit: Fix check of return value of strnlen_user()

2015-06-02 Thread Jan Kara
strnlen_user() returns 0 when it hits fault, not -1. Fix the test in audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless there's a kernel bug so it's mostly a cosmetic fix. CC: Paul Moore Signed-off-by: Jan Kara --- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1