Re: [PATCH] audit: fix error handling in audit_data_to_entry()

2020-03-17 Thread Richard Guy Briggs
On 2020-03-17 16:37, Paul Moore wrote: > On Tue, Mar 17, 2020 at 3:14 PM Richard Guy Briggs wrote: > > On 2020-02-24 16:31, Paul Moore wrote: > > > Commit 219ca39427bf ("audit: use union for audit_field values since > > > they are mutually exclusive") combined a number of separate fields in > > >

Re: [PATCH] audit: fix error handling in audit_data_to_entry()

2020-03-17 Thread Paul Moore
On Tue, Mar 17, 2020 at 3:14 PM Richard Guy Briggs wrote: > On 2020-02-24 16:31, Paul Moore wrote: > > Commit 219ca39427bf ("audit: use union for audit_field values since > > they are mutually exclusive") combined a number of separate fields in > > the audit_field struct into a single union. Gene

Re: [PATCH] audit: fix error handling in audit_data_to_entry()

2020-03-17 Thread Richard Guy Briggs
On 2020-02-24 16:31, Paul Moore wrote: > Commit 219ca39427bf ("audit: use union for audit_field values since > they are mutually exclusive") combined a number of separate fields in > the audit_field struct into a single union. Generally this worked > just fine because they are generally mutually e

Re: [PATCH] audit: fix error handling in audit_data_to_entry()

2020-02-25 Thread Paul Moore
On Mon, Feb 24, 2020 at 4:31 PM Paul Moore wrote: > > Commit 219ca39427bf ("audit: use union for audit_field values since > they are mutually exclusive") combined a number of separate fields in > the audit_field struct into a single union. Generally this worked > just fine because they are genera

[PATCH] audit: fix error handling in audit_data_to_entry()

2020-02-24 Thread Paul Moore
Commit 219ca39427bf ("audit: use union for audit_field values since they are mutually exclusive") combined a number of separate fields in the audit_field struct into a single union. Generally this worked just fine because they are generally mutually exclusive. Unfortunately in audit_data_to_entry(