Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-23 Thread Davidlohr Bueso
On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: > I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. What do you have in mind? At least in code size static inlining wins: textdata bss dec hex filename 14423 284 676 153833c17 kernel/audi

Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-23 Thread Davidlohr Bueso
On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote: > On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso wrote: > > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: > >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. > > > > What do you have in mind? > > Pretty much wh

Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-22 Thread Paul Moore
On Sat, Feb 21, 2015 at 10:00 AM, Davidlohr Bueso wrote: > On Sat, 2015-02-21 at 08:45 -0500, Paul Moore wrote: >> On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso wrote: >> > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: >> >> I'd prefer if the audit_log_d_path_exe() helper wasn't a stati

Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-21 Thread Paul Moore
On Fri, Feb 20, 2015 at 8:23 PM, Davidlohr Bueso wrote: > On Wed, 2015-02-18 at 22:23 -0500, Paul Moore wrote: >> I'd prefer if the audit_log_d_path_exe() helper wasn't a static inline. > > What do you have in mind? Pretty much what I said before, audit_log_d_path_exe() as a traditional function

[PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-18 Thread Davidlohr Bueso
From: Davidlohr Bueso This patch adds a audit_log_d_path_exe() helper function to share how we handle auditing of the exe_file's path. Used by both audit and auditsc. No functionality is changed. Cc: Paul Moore Cc: Eric Paris Cc: linux-audit@redhat.com Signed-off-by: Davidlohr Bueso --- Comp

Re: [PATCH 1/3] kernel/audit: consolidate handling of mm->exe_file

2015-02-18 Thread Paul Moore
On Wed, Feb 18, 2015 at 7:10 PM, Davidlohr Bueso wrote: > From: Davidlohr Bueso > > This patch adds a audit_log_d_path_exe() helper function > to share how we handle auditing of the exe_file's path. > Used by both audit and auditsc. No functionality is changed. > > Cc: Paul Moore > Cc: Eric Pari