[PATCH 1/5] Add the field checking for missing value after opration

2008-08-06 Thread Zhang Xiliang
Hello Steve, I think the missing value for -F should be checking. For example, auditctl -a exit,always -F pid= No error message is output and "pid=0" is added to rule. Signed-off-by: Zhang Xiliang <[EMAIL PROTECTED]> --- lib/deprecated.c |3 +++ lib/libaudit.c |3 +++ src/auditctl

Re: [PATCH 1/5] Add the field checking for missing value after opration

2008-08-06 Thread Zhang Xiliang
Hello Steve, > if (v == NULL || f == v) > return -1; I have some questions for "f == v". I think it only checks the address of "f" and "v". It seems unuseful. If we need to check whether the value is equal to the field, I think we should use strcmp(). What your opinion abou

Re: [PATCH 1/5] Add the field checking for missing value after opration

2008-08-06 Thread Steve Grubb
On Wednesday 06 August 2008 04:12:42 Zhang Xiliang wrote: >I think the missing value for -F should be checking. > >For example, >auditctl -a exit,always -F pid= > +   if (*v == NULL) > +   return -20; I changed these to (*v == 0) since it is a char and not a pointer. Thanks for

Re: [PATCH 1/5] Add the field checking for missing value after opration

2008-08-06 Thread Steve Grubb
On Wednesday 06 August 2008 04:46:27 Zhang Xiliang wrote: > Hello Steve, > > > if (v == NULL || f == v) > > return -1; > > I have some questions for "f == v". > > I think it only checks the address of "f" and "v". Yes, this was in attempt to make sure that they didn't type -F =10.