Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-21 Thread Paul Moore
On Wed, Feb 21, 2018 at 3:46 AM, Ingo Molnar wrote: > > * Paul Moore wrote: > >> On Tue, Feb 20, 2018 at 10:18 AM, Peter Zijlstra >> wrote: >> > On Tue, Feb 20, 2018 at 09:51:08AM -0500, Paul Moore wrote: >> >> On Tue, Feb 20, 2018

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-21 Thread Peter Zijlstra
On Wed, Feb 21, 2018 at 09:46:02AM +0100, Ingo Molnar wrote: > AFAICS the primary problem appears to be this code path: > > audit_receive() -> audit_receive_msg() -> AUDIT_TTY_SET -> > audit_log_common_recv_msg() -> audit_log_start() > > where we can arrive already holding the lock. > > I.e.

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-21 Thread Ingo Molnar
* Paul Moore wrote: > On Tue, Feb 20, 2018 at 10:18 AM, Peter Zijlstra wrote: > > On Tue, Feb 20, 2018 at 09:51:08AM -0500, Paul Moore wrote: > >> On Tue, Feb 20, 2018 at 9:06 AM, Peter Zijlstra > >> wrote: > > > >> > It's not

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-20 Thread Paul Moore
On Tue, Feb 20, 2018 at 10:18 AM, Peter Zijlstra wrote: > On Tue, Feb 20, 2018 at 09:51:08AM -0500, Paul Moore wrote: >> On Tue, Feb 20, 2018 at 9:06 AM, Peter Zijlstra wrote: > >> > It's not at all clear to me what that code does, I just stumbled upon

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 09:51:08AM -0500, Paul Moore wrote: > On Tue, Feb 20, 2018 at 9:06 AM, Peter Zijlstra wrote: > > It's not at all clear to me what that code does, I just stumbled upon > > __mutex_owner() outside of the mutex code itself and went WTF. > > If you

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-20 Thread Paul Moore
On Tue, Feb 20, 2018 at 9:06 AM, Peter Zijlstra wrote: > On Tue, Feb 20, 2018 at 08:25:21AM -0500, Paul Moore wrote: >> On Tue, Feb 20, 2018 at 7:37 AM, Peter Zijlstra wrote: >> > On Tue, Mar 28, 2017 at 02:30:56PM +0200, Greg Kroah-Hartman wrote: >>

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-20 Thread Peter Zijlstra
On Tue, Feb 20, 2018 at 08:25:21AM -0500, Paul Moore wrote: > On Tue, Feb 20, 2018 at 7:37 AM, Peter Zijlstra wrote: > > On Tue, Mar 28, 2017 at 02:30:56PM +0200, Greg Kroah-Hartman wrote: > >> 4.10-stable review patch. If anyone has any objections, please let me > >>

Re: [PATCH 4.10 070/111] audit: fix auditd/kernel connection state tracking

2018-02-20 Thread Paul Moore
On Tue, Feb 20, 2018 at 7:37 AM, Peter Zijlstra wrote: > On Tue, Mar 28, 2017 at 02:30:56PM +0200, Greg Kroah-Hartman wrote: >> 4.10-stable review patch. If anyone has any objections, please let me know. > >> + if (!(auditd_test_task(current) || >> + (current