Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread Ralf Baechle
On Wed, Apr 02, 2014 at 11:56:23AM -0400, Richard Guy Briggs wrote: (Adding dwmw2 who might give some insight on the purpose of __AUDIT_ARCH_LE to cc.) this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread Steve Grubb
On Thursday, April 03, 2014 11:32:57 AM Ralf Baechle wrote: - To make matters worse, most MIPS processors can be configured to be big or little endian. Traditionally the the 64-bit little endian configuration is named mips64el, so I've changed references to MIPSEL64 in

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread David Woodhouse
On Thu, 2014-04-03 at 11:32 +0200, Ralf Baechle wrote: There's probably the odd bitfield or similar where it might matter? I did dig a bit in the history of the auditing code and found no code that uses __AUDIT_ARCH_LE other than setting that flag. David - you introduced __AUDIT_ARCH_LE

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread Eric Paris
On Thu, 2014-04-03 at 14:48 +0100, David Woodhouse wrote: On Thu, 2014-04-03 at 11:32 +0200, Ralf Baechle wrote: There's probably the odd bitfield or similar where it might matter? I did dig a bit in the history of the auditing code and found no code that uses __AUDIT_ARCH_LE other than

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread Eric Paris
On Wed, 2014-04-02 at 12:13 +0200, Manuel Lauss wrote: From: Ralf Baechle r...@linux-mips.org this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd appreciate your comments and maybe even an Acked-by. - MIPS

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread David Woodhouse
On Thu, 2014-04-03 at 09:58 -0400, Eric Paris wrote: Same for the 64BIT flag. Do what makes sense to identify the arch and don't worry to much about it. (sounds to me like MIPS has 3 arches) Since the syscall numbers are disjoint for the three MIPS arches, you could surely consider it to be

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-03 Thread Richard Guy Briggs
On 14/04/03, David Woodhouse wrote: On Thu, 2014-04-03 at 11:32 +0200, Ralf Baechle wrote: The __AUDIT_ARCH_64BIT flag does allow you to distinguish between 32-bit and 64-bit system calls on architectures where you can't tell them apart by syscall number alone (e.g. S390?). But even that isn't

[RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-02 Thread Manuel Lauss
From: Ralf Baechle r...@linux-mips.org this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd appreciate your comments and maybe even an Acked-by. - MIPS syscalls return a success / error flag in register $7. If the

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Manuel Lauss wrote: From: Ralf Baechle r...@linux-mips.org this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd appreciate your comments and maybe even an Acked-by. - MIPS syscalls return a