Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
FYI... Sending unsubscribe to this list doest work. On Nov 1, 2013 3:20 PM, "David Rebman" wrote: > unsubscribe > > From: William Roberts > Date: Friday, November 1, 2013 at 5:10 PM > To: Richard Guy Briggs > Cc: "linux-audit@redhat.com" > Subject:

Re: Format specifier issue when building kernel

2013-11-01 Thread David Rebman
unsubscribe From: William Roberts mailto:bill.c.robe...@gmail.com>> Date: Friday, November 1, 2013 at 5:10 PM To: Richard Guy Briggs mailto:r...@redhat.com>> Cc: "linux-audit@redhat.com<mailto:linux-audit@redhat.com>" mailto:linux-audit@redhat.com>> Subjec

Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
On Nov 1, 2013 12:58 PM, "Richard Guy Briggs" wrote: > > On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: > > On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: > > > On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: > > > > On Thu, Oct 31, 2013 at 12:

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: > On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: > > On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: > > > On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: > > > +char usermsg_format

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: > On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: > > On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: > > > > + if (msg_type != AUDIT_USER_TTY) { > > > > +

Re: Format specifier issue when building kernel

2013-11-01 Thread Steve Grubb
On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: > On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: > > > + if (msg_type != AUDIT_USER_TTY) { > > > + char fmt[64]; > > > + strcat(fmt,

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: > > + if (msg_type != AUDIT_USER_TTY) { > > + char fmt[64]; > > + strcat(fmt, " msg='%."); > > + strcat(fmt, "AUDIT_MESSAG

Re: Format specifier issue when building kernel

2013-10-31 Thread William Roberts
> > Ugh. That's not so easy to read... Slightly longer, how about this? > > diff --git a/kernel/audit.c b/kernel/audit.c > index 8378c5e..3f569d1 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -824,11 +824,13 @@ static int audit_receive_msg(struct sk_buff *skb, > struct nlmsghdr *nlh

Re: Format specifier issue when building kernel

2013-10-31 Thread Richard Guy Briggs
On Mon, Oct 28, 2013 at 08:55:08PM -0700, William Roberts wrote: > On Mon, Oct 28, 2013 at 6:43 PM, William Roberts > wrote: > > On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs wrote: > >> On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: > >> > On Mon, Oct 28, 2013 at 4:30 PM, W

Re: Format specifier issue when building kernel

2013-10-28 Thread William Roberts
On Mon, Oct 28, 2013 at 6:43 PM, William Roberts wrote: > > > > On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs wrote: > >> On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: >> > On Mon, Oct 28, 2013 at 4:30 PM, William Roberts >> > wrote: >> > >> > > I've been working off of Ri

Re: Format specifier issue when building kernel

2013-10-28 Thread William Roberts
On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs wrote: > On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: > > On Mon, Oct 28, 2013 at 4:30 PM, William Roberts > > wrote: > > > > > I've been working off of Richard Guy Brigs git repo on branch > > > audit-for-next prepping my pa

Re: Format specifier issue when building kernel

2013-10-28 Thread Richard Guy Briggs
On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: > On Mon, Oct 28, 2013 at 4:30 PM, William Roberts > wrote: > > > I've been working off of Richard Guy Brigs git repo on branch > > audit-for-next prepping my patch and I noticed a build warning: > > > > kernel/audit.c:832:8: warning

Re: Format specifier issue when building kernel

2013-10-28 Thread William Roberts
On Mon, Oct 28, 2013 at 4:30 PM, William Roberts wrote: > I've been working off of Richard Guy Brigs git repo on branch > audit-for-next prepping my patch and I noticed a build warning: > > kernel/audit.c:832:8: warning: format ‘%A’ expects argument of type > ‘double’, but argument 3 has type ‘cha

Format specifier issue when building kernel

2013-10-28 Thread William Roberts
I've been working off of Richard Guy Brigs git repo on branch audit-for-next prepping my patch and I noticed a build warning: kernel/audit.c:832:8: warning: format ‘%A’ expects argument of type ‘double’, but argument 3 has type ‘char *’ [-Wformat] Looking at the code, it looks wrong: -- Resp