Re: [PATCH] bcachefs: make bch2_target_to_text_sb static

2023-11-05 Thread Kent Overstreet
On Mon, Nov 06, 2023 at 10:34:01AM +0800, Jiapeng Chong wrote: > The bch2_target_to_text_sb are not used outside the file disk_groups.c, > so the modification is defined as static. > > fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for > ‘bch2_target_to_text_sb’. > > Reported-by

[PATCH] bcachefs: make bch2_target_to_text_sb static

2023-11-05 Thread Jiapeng Chong
The bch2_target_to_text_sb are not used outside the file disk_groups.c, so the modification is defined as static. fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for ‘bch2_target_to_text_sb’. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7144 Si

[GIT PULL] bcachefs for 6.7-rc1, part 2

2023-11-05 Thread Kent Overstreet
Hi Linus, here's the rest of the bcachefs patches for the merge window. Cheers, Kent The following changes since commit cd063c8b9e1e95560e90bac7816234d8b2ee2897: Merge tag 'objtool-core-2023-10-28' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2023-10-30 13:20:02 -1000) are avai

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Kent Overstreet
On Mon, Nov 06, 2023 at 12:58:52AM +0100, Mateusz Guzik wrote: > On 11/6/23, Kent Overstreet wrote: > > On Sun, Nov 05, 2023 at 11:16:15PM +0100, Mateusz Guzik wrote: > >> On 11/5/23, Mateusz Guzik wrote: > >> > On 11/5/23, Kent Overstreet wrote: > >> >> On Sun, Nov 05, 2023 at 09:27:15PM +0100,

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
On 11/6/23, Kent Overstreet wrote: > On Sun, Nov 05, 2023 at 11:16:15PM +0100, Mateusz Guzik wrote: >> On 11/5/23, Mateusz Guzik wrote: >> > On 11/5/23, Kent Overstreet wrote: >> >> On Sun, Nov 05, 2023 at 09:27:15PM +0100, Mateusz Guzik wrote: >> >>> On 11/5/23, Kent Overstreet wrote: >> >>> >

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Kent Overstreet
On Sun, Nov 05, 2023 at 11:16:15PM +0100, Mateusz Guzik wrote: > On 11/5/23, Mateusz Guzik wrote: > > On 11/5/23, Kent Overstreet wrote: > >> On Sun, Nov 05, 2023 at 09:27:15PM +0100, Mateusz Guzik wrote: > >>> On 11/5/23, Kent Overstreet wrote: > >>> > On Sun, Nov 05, 2023 at 08:57:53PM +0100,

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
On 11/5/23, Mateusz Guzik wrote: > On 11/5/23, Kent Overstreet wrote: >> On Sun, Nov 05, 2023 at 09:27:15PM +0100, Mateusz Guzik wrote: >>> On 11/5/23, Kent Overstreet wrote: >>> > On Sun, Nov 05, 2023 at 08:57:53PM +0100, Mateusz Guzik wrote: >>> >> On 11/5/23, Kent Overstreet wrote: >>> >> >

[PATCH 1/2] nix: fix build add overlay and formatter to flake

2023-11-05 Thread Finn Behrens
Co-authored-by: Leona Maroni Signed-off-by: Leona Maroni Signed-off-by: Finn Behrens --- build.nix | 34 +- default.nix | 16 ++-- flake.lock | 18 +- flake.nix | 17 + 4 files changed, 37 insertions(+), 48 deletio

[PATCH 2/2] nix: add devShell

2023-11-05 Thread Finn Behrens
Signed-off-by: Finn Behrens --- flake.nix | 20 1 file changed, 20 insertions(+) diff --git a/flake.nix b/flake.nix index bdaa4bf..e6ad966 100644 --- a/flake.nix +++ b/flake.nix @@ -27,5 +27,25 @@ }; formatter = pkgs.nixfmt; + +devShells.default =

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
On 11/5/23, Kent Overstreet wrote: > On Sun, Nov 05, 2023 at 09:27:15PM +0100, Mateusz Guzik wrote: >> On 11/5/23, Kent Overstreet wrote: >> > On Sun, Nov 05, 2023 at 08:57:53PM +0100, Mateusz Guzik wrote: >> >> On 11/5/23, Kent Overstreet wrote: >> >> > Can you check btree_transactions in debug

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Kent Overstreet
On Sun, Nov 05, 2023 at 09:27:15PM +0100, Mateusz Guzik wrote: > On 11/5/23, Kent Overstreet wrote: > > On Sun, Nov 05, 2023 at 08:57:53PM +0100, Mateusz Guzik wrote: > >> On 11/5/23, Kent Overstreet wrote: > >> > Can you check btree_transactions in debugfs? > >> > >> 3807 __bch2_create > >> pa

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
On 11/5/23, Kent Overstreet wrote: > On Sun, Nov 05, 2023 at 08:57:53PM +0100, Mateusz Guzik wrote: >> On 11/5/23, Kent Overstreet wrote: >> > Can you check btree_transactions in debugfs? >> >> 3807 __bch2_create >> path 0 b l=0 subvolumes:0:1:0 >> r l=0 ff4007690c378000 b l=0 subvolu

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Kent Overstreet
On Sun, Nov 05, 2023 at 08:57:53PM +0100, Mateusz Guzik wrote: > On 11/5/23, Kent Overstreet wrote: > > Can you check btree_transactions in debugfs? > > 3807 __bch2_create > path 0 b l=0 subvolumes:0:1:0 > r l=0 ff4007690c378000 b l=0 subvolumes:SPOS_MAX locks 6:0:0 > held by pid 0 >

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
On 11/5/23, Kent Overstreet wrote: > On Sun, Nov 05, 2023 at 01:38:49PM +0100, Mateusz Guzik wrote: >> Setup is a 24 core vm + 24G of ram, running debian 12 with top of >> master as of writing this e-mail, commit being: >> commit 1c41041124bd14dd6610da256a3da4e5b74ce6b1 (HEAD -> master, >> origin/

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Kent Overstreet
On Sun, Nov 05, 2023 at 01:38:49PM +0100, Mateusz Guzik wrote: > Setup is a 24 core vm + 24G of ram, running debian 12 with top of > master as of writing this e-mail, commit being: > commit 1c41041124bd14dd6610da256a3da4e5b74ce6b1 (HEAD -> master, > origin/master, origin/HEAD) > Merge: b8cc56d0414e

Re: long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Thomas Weißschuh
On 2023-11-05 13:38:49+0100, Mateusz Guzik wrote: [..] > Side note: mkfs.bcachefs warns about xfs being on the volume, but is > perfectly happy to format an existing bcachefs partition -- perhaps > this should also ask if it was intended? mkfs.bcachefs uses libblkid to detect existing filesystems

long stalls when creating 20 directory trees of 1 million inodes in parallel

2023-11-05 Thread Mateusz Guzik
Setup is a 24 core vm + 24G of ram, running debian 12 with top of master as of writing this e-mail, commit being: commit 1c41041124bd14dd6610da256a3da4e5b74ce6b1 (HEAD -> master, origin/master, origin/HEAD) Merge: b8cc56d0414e 9fd00df05e81 Author: Linus Torvalds Date: Sat Nov 4 16:25:36 2023 -10