On 2023-11-05 13:38:49+0100, Mateusz Guzik wrote:
[..]
> Side note: mkfs.bcachefs warns about xfs being on the volume, but is
> perfectly happy to format an existing bcachefs partition -- perhaps
> this should also ask if it was intended?
mkfs.bcachefs uses libblkid to detect existing filesystems
Hi Kent,
On 2023-09-29 14:19:28-0400, Kent Overstreet wrote:
> On Fri, Sep 29, 2023 at 05:17:24PM +0200, Thomas Weißschuh wrote:
> > I'd like to extend libblkid/util-linux to handle the new members v2
> > format. We are using the superblock members to calculate the overall
>
Hi,
I'd like to extend libblkid/util-linux to handle the new members v2
format. We are using the superblock members to calculate the overall
filesystem size and per-device UUIDs.
While I found the kernel part, I did not so for the userspace part.
Could you give me a hint?
Also it would be great
Static variables defined in headers generate unused variable compiler
warnings in CUs that do not use said functions.
Avoid the warnings by either replacing the variables by enums and by
explicitly inhibiting the warning.
Signed-off-by: Thomas Weißschuh
---
fs/bcachefs/bcachefs.h| 3
It is never used outside of snapshot.c.
Signed-off-by: Thomas Weißschuh
---
fs/bcachefs/snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bcachefs/snapshot.c b/fs/bcachefs/snapshot.c
index 9da09911466e..c69b16010027 100644
--- a/fs/bcachefs/snapshot.c
+++ b/fs
As the variables are never read back they can be removed.
Signed-off-by: Thomas Weißschuh
---
fs/bcachefs/alloc_foreground.c | 3 ---
fs/bcachefs/backpointers.c | 3 ---
fs/bcachefs/btree_io.c | 3 +--
fs/bcachefs/btree_trans_commit.c | 4
fs/bcachefs/compress.c
Some fixes for warnings found by "make W=1".
Note: This was only compile-tested.
Signed-off-by: Thomas Weißschuh
---
Thomas Weißschuh (5):
bcachefs: Delete dead code
bcachefs: Mark bch2_snapshot_node_delete() static
bcachefs: Delete set but not used variables
These help the compiler detect incorrect use of format strings and their
arguments.
Signed-off-by: Thomas Weißschuh
---
fs/bcachefs/btree_io.c | 1 +
fs/bcachefs/btree_update.c | 2 ++
fs/bcachefs/btree_update.h | 3 +++
3 files changed, 6 insertions(+)
diff --git a/fs/bcachefs/btree_io.c
It is not used, might as well delete it.
Signed-off-by: Thomas Weißschuh
---
fs/bcachefs/btree_update.c| 11 ---
fs/bcachefs/btree_update.h| 1 -
fs/bcachefs/fs-io-pagecache.c | 7 ---
fs/bcachefs/reflink.c | 8
4 files changed, 27 deletions(-)
diff
