Re: (subset) [PATCH 22/32] vfs: inode cache conversion to hash-bl

2023-11-04 Thread Dave Chinner
s because RT makes spinlocks sleeping locks. - There's been additions for lockless RCU inode hash lookups from AFS and ext4 in weird, uncommon corner cases and I have no idea how to validate they still work correctly with hash-bl. I suspect they should just go away with hash-bl, but There's more, but these are the big ones. -Dave. -- Dave Chinner da...@fromorbit.com

Re: (subset) [PATCH 22/32] vfs: inode cache conversion to hash-bl

2023-10-20 Thread Dave Chinner
Hence there's no urgency to "fix" these lock contention problems despite the ease with which micro-benchmarks can reproduce it... I've kept the patches current for years, even though there hasn't been a pressing need for them. The last "vfs-scale" version I did some validation on is here: https://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs.git/log/?h=vfs-scale 5.17 was the last kernel I did any serious validation and measurement against, and that all needs to be repeated before proposing it for inclusion because lots of stuff has changed since I last did some serious multi-filesystem a/b testing of this code -Dave. -- Dave Chinner da...@fromorbit.com

Re: (subset) [PATCH 22/32] vfs: inode cache conversion to hash-bl

2023-10-22 Thread Dave Chinner
On Fri, Oct 20, 2023 at 07:49:18PM +0200, Mateusz Guzik wrote: > On 10/20/23, Dave Chinner wrote: > > On Thu, Oct 19, 2023 at 05:59:58PM +0200, Mateusz Guzik wrote: > >> > To be clear there is no urgency as far as I'm concerned, but I did run > >> > into somethin

Re: [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH

2024-01-22 Thread Dave Chinner
t corpse to isolate the write groups where the consistency failure occurs when doing work to optimise flushes being issued by the XFS journal checkpoint writes. Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: file handle in statx

2023-12-12 Thread Dave Chinner
On Tue, Dec 12, 2023 at 05:39:27PM -0500, Kent Overstreet wrote: > On Wed, Dec 13, 2023 at 09:23:18AM +1100, Dave Chinner wrote: > > On Wed, Dec 13, 2023 at 08:57:43AM +1100, NeilBrown wrote: > > > On Wed, 13 Dec 2023, Dave Chinner wrote: > > > > On Tue, Dec 12, 2

Re: file handle in statx

2023-12-12 Thread Dave Chinner
On Tue, Dec 12, 2023 at 09:15:29AM -0800, Frank Filz wrote: > > On Tue, Dec 12, 2023 at 10:10:23AM +0100, Donald Buczek wrote: > > > On 12/12/23 06:53, Dave Chinner wrote: > > > > > > > So can someone please explain to me why we need to try to re-invent

Re: file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?)

2023-12-12 Thread Dave Chinner
On Tue, Dec 12, 2023 at 10:21:53AM -0500, Kent Overstreet wrote: > On Tue, Dec 12, 2023 at 04:53:28PM +1100, Dave Chinner wrote: > > Doesn't anyone else see or hear the elephant trumpeting loudly in > > the middle of the room? > > > > I mean, we already have name_t

Re: file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?)

2023-12-11 Thread Dave Chinner
andle to determine what subvol/snapshot the inode belongs to when the handle is passed back to it (e.g. from open_by_handle_at()) then nothing else needs to care how it is encoded. So can someone please explain to me why we need to try to re-invent a generic filehandle concept in statx when we already have a have working and widely supported user API that provides exactly this functionality? Cheers, Dave. -- Dave Chinner da...@fromorbit.com

Re: [PATCH v2] statx: stx_subvol

2024-03-10 Thread Dave Chinner
t, truncate, clear rt, copy data back into data dev". It's still the same inode, and may have exactly the same data, so why should change stx_vol and make it appear to userspace as being a different inode? -Dave. -- Dave Chinner da...@fromorbit.com