On Tue 07-02-17 12:21:01, Tejun Heo wrote:
> Hello,
>
> On Tue, Feb 07, 2017 at 01:33:31PM +0100, Jan Kara wrote:
> > > We can see above that inode->i_wb is in r31, and the machine crashed at
> > > 0xc03799a0 so it was trying to dereference wb and crashed.
> > > r31 is NULL in the crash i
On Wed 08-02-17 08:51:42, Jan Kara wrote:
> On Tue 07-02-17 12:21:01, Tejun Heo wrote:
> > Hello,
> >
> > On Tue, Feb 07, 2017 at 01:33:31PM +0100, Jan Kara wrote:
> > > > We can see above that inode->i_wb is in r31, and the machine crashed at
> > > > 0xc03799a0 so it was trying to derefe
> From: Jens Axboe [mailto:ax...@kernel.dk]
> Sent: Wednesday, February 8, 2017 00:09
> To: Dexuan Cui ; Bart Van Assche
> ; h...@suse.com; h...@suse.de
> Cc: h...@lst.de; linux-ker...@vger.kernel.org; linux-block@vger.kernel.org;
> j...@kernel.org
> Subject: Re: [PATCH] genhd: Do not hold event lo
> Il giorno 08 feb 2017, alle ore 11:33, Omar Sandoval ha
> scritto:
>
> On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote:
>>
>>> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval
>>> ha scritto:
>>>
>>> On Tue, Feb 07, 2017 at 06:33:46PM +0100, Paolo Valente wrote:
Hi,
On Wed, Feb 8, 2017 at 12:46 AM, Christoph Hellwig wrote:
> Add a new merge strategy that merges discard bios into a request until the
> maximum number of discard ranges (or the maximum discard size) is reached
> from the plug merging code. I/O scheduler merging is not wired up yet
> but might al
On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote:
>
> > Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval
> > ha scritto:
> >
> > On Tue, Feb 07, 2017 at 06:33:46PM +0100, Paolo Valente wrote:
> >> Hi,
> >> this patch is meant to show that, if the body of the hook exit_icq is
> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval ha
> scritto:
>
> On Tue, Feb 07, 2017 at 06:33:46PM +0100, Paolo Valente wrote:
>> Hi,
>> this patch is meant to show that, if the body of the hook exit_icq is
>> executed
>> from inside that hook, and not as deferred work, then a circul
Am 02.02.2017 um 18:34 schrieb Jan Kara:
> Allocate struct backing_dev_info separately instead of embedding it
> inside the superblock. This unifies handling of bdi among users.
>
> CC: Richard Weinberger
> CC: Artem Bityutskiy
> CC: Adrian Hunter
> CC: linux-...@lists.infradead.org
> Signed-of
This makes it available outside of blk-merge.c, and inlining such a trivial
helper seems pretty useful to start with.
Signed-off-by: Christoph Hellwig
---
block/blk-merge.c | 7 ---
block/blk.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/blk-merge.
Switch these constants to an enum, and make let the compiler ensure that
all callers of blk_try_merge and elv_merge handle all potential values.
Signed-off-by: Christoph Hellwig
---
block/blk-core.c | 76 +---
block/blk-merge.c| 2 +-
Hi all,
this series adds support for merging discontiguous discard bios into a
single request if the driver supports it. This reduces the number of
discards sent to the device by about a factor of 5-6 for typical
workloads on NVMe, and for slower devices that use I/O scheduling
the number will pr
Add a new merge strategy that merges discard bios into a request until the
maximum number of discard ranges (or the maximum discard size) is reached
from the plug merging code. I/O scheduler merging is not wired up yet
but might also be useful, although not for fast devices like NVMe which
are the
NVMe supports up to 255 ranges per DSM command, so wire up support
for ranged discards up to that limit.
Signed-off-by: Christoph Hellwig
---
drivers/nvme/host/core.c | 28 +---
include/linux/nvme.h | 2 ++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --gi
Looks like this caused by del_timer_sync() in wbt_disable_default() under
irq-safe lock.
Here
void wbt_disable_default(struct request_queue *q)
{
struct rq_wb *rwb = q->rq_wb;
if (rwb && rwb->enable_state == WBT_STATE_ON_DEFAULT) {
del_timer_sync(&rwb->window_ti
On Wed, Feb 08, 2017 at 01:32:22PM +, Andrey Kuzmin wrote:
> On Wed, Feb 8, 2017, 16:14 Christoph Hellwig wrote:
>
> > NVMe supports up to 255 ranges per DSM command,
>
>
> 256 per spec, with number of ranges being zero-based.
You're right. I'll do another round of the patch. That beeing
NVMe supports up to 256 ranges per DSM command, so wire up support
for ranged discards up to that limit.
Signed-off-by: Christoph Hellwig
---
drivers/nvme/host/core.c | 30 +++---
include/linux/nvme.h | 2 ++
2 files changed, 25 insertions(+), 7 deletions(-)
diff --
On Wed, Feb 08, 2017 at 06:54:24PM +0800, Ming Lei wrote:
> > + struct bio *bio)
> > +{
> > + unsigned short segments = blk_rq_nr_discard_segments(req);
> > +
> > + if (segments >= queue_max_discard_segments(q))
> > + goto no_merge;
> > + if (blk_rq_sec
This makes it available outside of blk-merge.c, and inlining such a trivial
helper seems pretty useful to start with.
Signed-off-by: Christoph Hellwig
---
block/blk-merge.c | 7 ---
block/blk.h | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block/blk-merge.
Hi all,
this series adds support for merging discontiguous discard bios into a
single request if the driver supports it. This reduces the number of
discards sent to the device by about a factor of 5-6 for typical
workloads on NVMe, and for slower devices that use I/O scheduling
the number will pr
Add a new merge strategy that merges discard bios into a request until the
maximum number of discard ranges (or the maximum discard size) is reached
from the plug merging code. I/O scheduler merging is not wired up yet
but might also be useful, although not for fast devices like NVMe which
are the
On Thu, Feb 02, 2017 at 06:34:06PM +0100, Jan Kara wrote:
> Allocate struct backing_dev_info separately instead of embedding it
> inside superblock. This unifies handling of bdi among users.
>
> CC: Chris Mason
> CC: Josef Bacik
> CC: David Sterba
> CC: linux-bt...@vger.kernel.org
> Signed-off-
Switch these constants to an enum, and make let the compiler ensure that
all callers of blk_try_merge and elv_merge handle all potential values.
Signed-off-by: Christoph Hellwig
---
block/blk-core.c | 76 +---
block/blk-merge.c| 2 +-
On Wed, Feb 8, 2017 at 2:23 AM, Jan Kara wrote:
> On Wed 08-02-17 08:51:42, Jan Kara wrote:
[..]
>
> This ordering seems to be the real culprit of the bdi name reuse problems
> Omar has reported? Same as described in commit 6cd18e711dd8 for MD BTW and
> Dan's patch could be IMHO replaced by a mov
In preparation for allowing seamless reconnects we need a way to make
sure that we don't free the socks array out from underneath ourselves.
So a socks_ref counter in order to keep track of who is using the socks
array, and only free it and change num_connections once our reference
reduces to zero.
On Tue, Feb 07 2017 at 11:58pm -0500,
Kent Overstreet wrote:
> On Tue, Feb 07, 2017 at 09:39:11PM +0100, Pavel Machek wrote:
> > On Mon 2017-02-06 17:49:06, Kent Overstreet wrote:
> > > On Mon, Feb 06, 2017 at 04:47:24PM -0900, Kent Overstreet wrote:
> > > > On Mon, Feb 06, 2017 at 01:53:09PM +01
On Wed, Feb 08, 2017 at 11:39:24AM +0100, Paolo Valente wrote:
>
> > Il giorno 08 feb 2017, alle ore 11:33, Omar Sandoval
> > ha scritto:
> >
> > On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote:
> >>
> >>> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval
> >>> ha scritto:
>
On 02/08/2017 03:48 AM, Dexuan Cui wrote:
>> From: Jens Axboe [mailto:ax...@kernel.dk]
>> Sent: Wednesday, February 8, 2017 00:09
>> To: Dexuan Cui ; Bart Van Assche
>> ; h...@suse.com; h...@suse.de
>> Cc: h...@lst.de; linux-ker...@vger.kernel.org; linux-block@vger.kernel.org;
>> j...@kernel.org
>>
On 02/08/2017 06:46 AM, Christoph Hellwig wrote:
> Hi all,
>
> this series adds support for merging discontiguous discard bios into a
> single request if the driver supports it. This reduces the number of
> discards sent to the device by about a factor of 5-6 for typical
> workloads on NVMe, and
On Wed, Feb 08, 2017 at 10:43:59AM -0700, Jens Axboe wrote:
> I've changed the subject line, this issue has nothing to do with the
> issue that Hannes was attempting to fix.
Nothing really useful in the thread. Dexuan, can you throw in some
prints to see which command times out?
When CONFIG_KASAN is in use, the sed_ioctl function uses unusually large stack,
as each possible ioctl argument gets its own stack area plus redzone:
block/sed-opal.c: In function 'sed_ioctl':
block/sed-opal.c:2447:1: error: the frame size of 2256 bytes is larger than
2048 bytes [-Werror=frame-la
On Wed, Feb 08, 2017 at 10:15:28PM +0100, Arnd Bergmann wrote:
> When CONFIG_KASAN is in use, the sed_ioctl function uses unusually large
> stack,
> as each possible ioctl argument gets its own stack area plus redzone:
>
> block/sed-opal.c: In function 'sed_ioctl':
> block/sed-opal.c:2447:1: erro
On Wed, Feb 08, 2017 at 02:58:28PM -0700, Scott Bauer wrote:
> On Wed, Feb 08, 2017 at 10:15:28PM +0100, Arnd Bergmann wrote:
> > When CONFIG_KASAN is in use, the sed_ioctl function uses unusually large
> > stack,
> > as each possible ioctl argument gets its own stack area plus redzone:
> >
> > b
When CONFIG_KASAN is enabled, compilation fails:
block/sed-opal.c: In function 'sed_ioctl':
block/sed-opal.c:2447:1: error: the frame size of 2256 bytes is larger than
2048 bytes [-Werror=frame-larger-than=]
Moved all the ioctl structures off the stack to a static
union to prevent oversized stac
When CONFIG_KASAN is enabled, compilation fails:
block/sed-opal.c: In function 'sed_ioctl':
block/sed-opal.c:2447:1: error: the frame size of 2256 bytes is larger than
2048 bytes [-Werror=frame-larger-than=]
Moved all the ioctl structures off the stack to a static
union to prevent oversized stac
On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote:
> On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote:
> > On 02/06/2017 05:14 PM, James Bottomley wrote:
> > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
> > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig
> > > > wrote:
> > >
On Thu, Jan 26, 2017 at 02:57:43PM +0300, Kirill A. Shutemov wrote:
> +++ b/include/linux/pagemap.h
> @@ -332,6 +332,15 @@ static inline struct page *grab_cache_page_nowait(struct
> address_space *mapping,
> mapping_gfp_mask(mapping));
> }
>
> +static inline struct page *f
On Thu, Jan 26, 2017 at 02:57:45PM +0300, Kirill A. Shutemov wrote:
> These flags are in use for filesystems with backing storage: PG_error,
> PG_writeback and PG_readahead.
Oh ;-) Then I amend my comment on patch 1 to be "patch 3 needs to go
ahead of patch 1" ;-)
> Signed-off-by: Kirill A. Shut
> From: h...@lst.de [mailto:h...@lst.de]
> Sent: Thursday, February 9, 2017 02:03
> To: Jens Axboe
> Cc: Dexuan Cui ; Bart Van Assche
> ; h...@suse.com; h...@suse.de; Martin K.
> Petersen ; h...@lst.de; linux-
> ker...@vger.kernel.org; linux-block@vger.kernel.org; j...@kernel.org
> Subject: Re: Bo
38 matches
Mail list logo
