Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

2017-07-01 Thread Coly Li
On 2017/7/2 上午3:39, Eric Wheeler wrote: > On Sun, 2 Jul 2017, Coly Li wrote: > >> On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: >>> From: Eric Wheeler >>> >>> Bypass if: bio->bi_opf & (REQ_RAHEAD|REQ_BACKGROUND) >>> >>> Writeback if: op_is_sync(bio->bi_opf) || bio->bi_opf & (REQ_META|

Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

2017-07-01 Thread Eric Wheeler
On Sun, 2 Jul 2017, Coly Li wrote: > On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > > From: Eric Wheeler > > > > Bypass if: bio->bi_opf & (REQ_RAHEAD|REQ_BACKGROUND) > > > > Writeback if: op_is_sync(bio->bi_opf) || bio->bi_opf & (REQ_META|REQ_PRIO) > > > > Hi Eric, > > Could you

[PATCH 05/19] bcache: fix calling ida_simple_remove() with incorrect minor

2017-07-01 Thread Eric Wheeler
From: Tang Junhui bcache called ida_simple_remove() with minor which have multiplied by BCACHE_MINORS, it would cause minor wrong release and leakage. In addition, when adding partition support to bcache, the name assignment was not updated, resulting in numbers jumping (bcache0, bcache16, bcach

Re: [PATCH 10/19] bcache: initialize stripe_sectors_dirty correctly for thin flash device

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Tang Junhui > > Thin flash device does not initialize stripe_sectors_dirty correctly, this > patch fixes this issue. Hi Junhui, Could you please explain why stripe_sectors_ditry is not correctly initialized and how about its negative

Re: [PATCH 09/19] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Eric Wheeler > > Bypass if: bio->bi_opf & (REQ_RAHEAD|REQ_BACKGROUND) > > Writeback if: op_is_sync(bio->bi_opf) || bio->bi_opf & (REQ_META|REQ_PRIO) > Hi Eric, Could you please explain a bit how the above policy is designed ? I

Re: [PATCH 06/19] bcache: explicitly destory mutex while exiting

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Liang Chen > > mutex_destroy does nothing most of time, but it's better to call > it to make the code future proof and it also has some meaning > for like mutex debug. > > Signed-off-by: Liang Chen > Reviewed-by: Eric Wheeler > Cc: s

Re: [PATCH 04/19] bcache: fix wrong cache_misses statistics

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Tang Junhui > > Some missed IOs are not counted into cache_misses, this patch fix this > issue. Could you please explain more about, - which kind of missed I/O are mot counted - where cache_missed is located This will help the patch t

Re: [PATCH 03/19] bcache: do not subtract sectors_to_gc for bypassed IO

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Tang Junhui > > Since bypassed IOs use no bucket, so do not subtract sectors_to_gc to > trigger gc thread. > > Signed-off-by: tang.junhui > Reviewed-by: Eric Wheeler > Cc: sta...@vger.kernel.org Acked-by: Coly Li Thanks. > --- >

Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-07-01 Thread Coly Li
On 2017/7/1 上午4:42, bca...@lists.ewheeler.net wrote: > From: Jan Kara > > If blkdev_get_by_path() in register_bcache() fails, we try to lookup the > block device using lookup_bdev() to detect which situation we are in to > properly report error. However we never drop the reference returned to > u

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-07-01 Thread Jens Axboe
On 06/30/2017 10:59 PM, Jens Axboe wrote: > On 06/30/2017 10:17 PM, Jens Axboe wrote: >> On 06/30/2017 08:08 AM, Jens Axboe wrote: >>> On 06/30/2017 07:05 AM, Brian King wrote: On 06/29/2017 09:17 PM, Jens Axboe wrote: > On 06/29/2017 07:20 PM, Ming Lei wrote: >> On Fri, Jun 30, 2017 a