Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-04 Thread Coly Li
On 2017/9/5 下午2:43, Christoph Hellwig wrote: > On Tue, Sep 05, 2017 at 01:30:04AM +0800, Coly Li wrote: >> >> When you mentioned "whole chunk of code", do you mean the following >> block of code ? >> >> >> 1960 if (IS_ERR(bdev)) { >> = start of whole chunk of code >> 19

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-04 Thread Dave Chinner
On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: > On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: > > Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set > > physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default > > physical sec

Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-04 Thread Christoph Hellwig
On Tue, Sep 05, 2017 at 01:30:04AM +0800, Coly Li wrote: > > When you mentioned "whole chunk of code", do you mean the following > block of code ? > > > 1960 if (IS_ERR(bdev)) { > = start of whole chunk of code > 1961 if (bdev == ERR_PTR(-EBUSY)) { >

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-04 Thread Omar Sandoval
On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: > On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: > > Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set > > physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default > > physical sec

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-04 Thread Christoph Hellwig
On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: > Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set > physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default > physical sector size of loop devices. On ppc64, this causes loop devices > to have 64k

[PATCH] block: fix bio.c kernel-doc notation warning

2017-09-04 Thread Randy Dunlap
From: Randy Dunlap Sphinx treats symbols that end with '_' as some kind of special documentation indicator, so fix that by adding an ending '*' to it. ../block/bio.c:404: ERROR: Unknown target name: "gfp". Signed-off-by: Randy Dunlap --- block/bio.c |2 +- 1 file changed, 1 insertion(+),

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Ming Lei
On Tue, Sep 05, 2017 at 01:40:11AM +, Bart Van Assche wrote: > On Tue, 2017-09-05 at 00:08 +0800, Ming Lei wrote: > > On Mon, Sep 04, 2017 at 03:40:35PM +, Bart Van Assche wrote: > > > Have you considered to use the blk-mq "reserved request" mechanism to > > > avoid > > > starvation of pow

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Bart Van Assche
On Tue, 2017-09-05 at 00:08 +0800, Ming Lei wrote: > On Mon, Sep 04, 2017 at 03:40:35PM +, Bart Van Assche wrote: > > Have you considered to use the blk-mq "reserved request" mechanism to avoid > > starvation of power management requests instead of making the block layer > > even more complicat

Re: [PATCH V4 00/14] blk-mq-sched: improve SCSI-MQ performance

2017-09-04 Thread Ming Lei
On Mon, Sep 04, 2017 at 11:12:49AM +0200, Paolo Valente wrote: > > > Il giorno 02 set 2017, alle ore 17:17, Ming Lei ha > > scritto: > > > > Hi, > > > > In Red Hat internal storage test wrt. blk-mq scheduler, we > > found that I/O performance is much bad with mq-deadline, especially > > about

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-04 Thread Adrian Hunter
On 09/04/2017 04:48 PM, Ulf Hansson wrote: > On 4 September 2017 at 09:06, Adrian Hunter wrote: >> On 01/09/17 16:28, Adrian Hunter wrote: >>> On 01/09/17 15:58, Ulf Hansson wrote: + Christoph On 1 September 2017 at 13:42, Adrian Hunter wrote: > On 31/08/17 14:56, Adrian

Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-04 Thread Coly Li
On 2017/7/6 上午2:24, Christoph Hellwig wrote: > On Fri, Jun 30, 2017 at 01:42:50PM -0700, bca...@lists.ewheeler.net wrote: >> From: Jan Kara >> >> If blkdev_get_by_path() in register_bcache() fails, we try to lookup the >> block device using lookup_bdev() to detect which situation we are in to >> p

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Ming Lei
On Mon, Sep 04, 2017 at 04:18:32PM +, Bart Van Assche wrote: > On Tue, 2017-09-05 at 00:08 +0800, Ming Lei wrote: > > On Mon, Sep 04, 2017 at 03:40:35PM +, Bart Van Assche wrote: > > > On Mon, 2017-09-04 at 15:16 +0800, Ming Lei wrote: > > > > On Mon, Sep 04, 2017 at 04:13:26AM +, Bart

Re: [PATCH V3 6/8] block: introduce preempt version of blk_[freeze|unfreeze]_queue

2017-09-04 Thread Ming Lei
On Mon, Sep 04, 2017 at 03:21:08PM +, Bart Van Assche wrote: > On Sat, 2017-09-02 at 21:08 +0800, Ming Lei wrote: > > --- a/include/linux/blkdev.h > > +++ b/include/linux/blkdev.h > > @@ -565,6 +565,10 @@ struct request_queue { > > > > int bypass_depth; > > atomic_

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Bart Van Assche
On Tue, 2017-09-05 at 00:08 +0800, Ming Lei wrote: > On Mon, Sep 04, 2017 at 03:40:35PM +, Bart Van Assche wrote: > > On Mon, 2017-09-04 at 15:16 +0800, Ming Lei wrote: > > > On Mon, Sep 04, 2017 at 04:13:26AM +, Bart Van Assche wrote: > > > > Allowing blk_get_request() to succeed after the

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Ming Lei
On Mon, Sep 04, 2017 at 03:40:35PM +, Bart Van Assche wrote: > On Mon, 2017-09-04 at 15:16 +0800, Ming Lei wrote: > > On Mon, Sep 04, 2017 at 04:13:26AM +, Bart Van Assche wrote: > > > Allowing blk_get_request() to succeed after the DYING flag has been set is > > > completely wrong because

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Bart Van Assche
On Mon, 2017-09-04 at 15:16 +0800, Ming Lei wrote: > On Mon, Sep 04, 2017 at 04:13:26AM +, Bart Van Assche wrote: > > Allowing blk_get_request() to succeed after the DYING flag has been set is > > completely wrong because that could result in a request being queued after > > the DEAD flag has b

Re: [PATCH V3 6/8] block: introduce preempt version of blk_[freeze|unfreeze]_queue

2017-09-04 Thread Bart Van Assche
On Sat, 2017-09-02 at 21:08 +0800, Ming Lei wrote: > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -565,6 +565,10 @@ struct request_queue { > > int bypass_depth; > atomic_tmq_freeze_depth; > + spinlock_t freeze_lo

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-04 Thread Ulf Hansson
On 4 September 2017 at 09:06, Adrian Hunter wrote: > On 01/09/17 16:28, Adrian Hunter wrote: >> On 01/09/17 15:58, Ulf Hansson wrote: >>> + Christoph >>> >>> On 1 September 2017 at 13:42, Adrian Hunter wrote: On 31/08/17 14:56, Adrian Hunter wrote: > Here is V7 of the hardware command qu

Re: [PATCH 2/4] fs: support IOCB_NOWAIT in generic_file_buffered_read

2017-09-04 Thread Jan Kara
On Tue 29-08-17 16:13:19, Christoph Hellwig wrote: > From: Milosz Tanski > > Allow generic_file_buffered_read to bail out early instead of waiting for > the page lock or reading a page if IOCB_NOWAIT is specified. > > Signed-off-by: Milosz Tanski > Reviewed-by: Christoph Hellwig > Reviewed-by:

Re: [PATCH] blk-mq: fix nr_requests wrong value when modify it from sysfs

2017-09-04 Thread Ming Lei
On Sun, Sep 3, 2017 at 9:46 PM, weiping zhang wrote: > if blk-mq use "none" io scheduler, nr_request get a wrong value when > input a number > tag_set->queue_depth. blk_mq_tag_update_depth will get > the smaller one min(nr, set->queue_depth), and then q->nr_request get a > wrong value. > > Reprodu

Re: Memory leak in BFQ?

2017-09-04 Thread Paolo Valente
> Il giorno 31 ago 2017, alle ore 22:42, Bart Van Assche > ha scritto: > > Hello Paolo, > > If I run the following commands: > > # echo bfq > /sys/block/sda/queue/scheduler > # echo 3 >/proc/sys/vm/drop_caches; find / -xdev >/dev/null > # echo none > /sys/block/sda/queue/scheduler > # echo s

Re: [PATCH V4 00/14] blk-mq-sched: improve SCSI-MQ performance

2017-09-04 Thread Paolo Valente
> Il giorno 02 set 2017, alle ore 17:17, Ming Lei ha > scritto: > > Hi, > > In Red Hat internal storage test wrt. blk-mq scheduler, we > found that I/O performance is much bad with mq-deadline, especially > about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, > SRP...) > > Tur

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-09-04 Thread Ming Lei
On Mon, Sep 4, 2017 at 4:14 PM, Mel Gorman wrote: > On Thu, Aug 31, 2017 at 03:42:57PM +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >> > [SECOND TAKE, with just the name of one of the tester fixed] >> > >> > Hi, >> > while testing the read-write unfair

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-09-04 Thread Paolo Valente
> Il giorno 04 set 2017, alle ore 10:14, Mel Gorman > ha scritto: > > On Thu, Aug 31, 2017 at 03:42:57PM +0100, Mel Gorman wrote: >> On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: >>> [SECOND TAKE, with just the name of one of the tester fixed] >>> >>> Hi, >>> while testing the

Re: [PATCH BUGFIX/IMPROVEMENT V2 0/3] three bfq fixes restoring service guarantees with random sync writes in bg

2017-09-04 Thread Mel Gorman
On Thu, Aug 31, 2017 at 03:42:57PM +0100, Mel Gorman wrote: > On Thu, Aug 31, 2017 at 08:46:28AM +0200, Paolo Valente wrote: > > [SECOND TAKE, with just the name of one of the tester fixed] > > > > Hi, > > while testing the read-write unfairness issues reported by Mel, I > > found BFQ failing to g

Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen

2017-09-04 Thread Ming Lei
On Mon, Sep 04, 2017 at 04:13:26AM +, Bart Van Assche wrote: > On Sat, 2017-09-02 at 21:12 +0800, Ming Lei wrote: > > Please let us know if V3 addresses your previous concern about calling > > blk_queue_enter_live() during preempt freezing. > > Do you understand how request queue cleanup works

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-04 Thread Adrian Hunter
On 01/09/17 16:28, Adrian Hunter wrote: > On 01/09/17 15:58, Ulf Hansson wrote: >> + Christoph >> >> On 1 September 2017 at 13:42, Adrian Hunter wrote: >>> On 31/08/17 14:56, Adrian Hunter wrote: Here is V7 of the hardware command queue patches without the software command queue patches,