Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

Ah. I will copy linux-block in the future, then. Thanks! -mpl On Thu, Sep 28, 2017 at 9:22 PM, Coly Li wrote: > Oh, it is because Christoph Hellwig suggested to Cc linux-block when > posting bcache patches to linux-bcache list, then patches may have more > eyes on them. > >

Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

P.S. another concern with the current design is that for every backing device, there's a separate writeback thread that can want to scan for dirty blocks with very poor locking (starving other writes). With several of these threads, there's no guarantee that they won't all stack up and want to do

Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

On 2017/9/29 下午12:15, Michael Lyle wrote: [snip] > Also, why do you keep copying linux-block for every bit of feedback on > this code? It seems like we probably don't want to clutter that list > with this discussion. Oh, it is because Christoph Hellwig suggested to Cc linux-block when posting

Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

It's presently guaranteed, but it sure seems like a good idea to confirm that the keys are actually contiguous on the same volume. What's the harm with checking-- it prevents the code from being delicate if things change. If anything, this should get factored to util.h with the check in place.

Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

From: Tang Junhui Hello Mike: > + if (KEY_INODE(>key) != KEY_INODE(>key)) > + return false; Please remove these redundant codes, all the keys in dc->writeback_keys have the same KEY_INODE. it is guaranted by refill_dirty(). Regards, Tang Junhui > Previously,

Re: [PATCH] badblocks: fix wrong return value in badblocks_set if badblocks are disabled

On 09/29/2017 02:45 AM, Liu Bo wrote: On Thu, Sep 28, 2017 at 09:57:41AM +0800, Guoqing Jiang wrote: On 09/28/2017 06:13 AM, Liu Bo wrote: MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if badblocks are disabled, otherwise, rdev_set_badblocks() will record superblock

Re: [PATCH] blk-throttle: fix possible io stall when doing upgrade

On Thu, Sep 28, 2017 at 07:19:45PM +0800, Joseph Qi wrote: > > > On 17/9/28 11:48, Joseph Qi wrote: > > Hi Shahua, > > > > On 17/9/28 05:38, Shaohua Li wrote: > >> On Tue, Sep 26, 2017 at 11:16:05AM +0800, Joseph Qi wrote: > >>> > >>> > >>> On 17/9/26 10:48, Shaohua Li wrote: > On Tue, Sep

[PATCH 1/2] block: genhd: add device_add_disk_with_groups

In the NVME subsystem, we're seeing a race condition with udev where device_add_disk() is called (which triggers an "add" uevent), and a sysfs attribute group is added to the disk device afterwards. If udev rules access these attributes before they are created, udev processing of the device is

[PATCH 2/2] nvme: use device_add_disk_with_groups()

By using device_add_disk_with_groups(), we can avoid the race condition with udev rule processing, because no udev event will be triggered before all attributes are available. Signed-off-by: Martin Wilck --- drivers/nvme/host/core.c | 12 +++- 1 file changed, 7

Re: [PATCH] badblocks: fix wrong return value in badblocks_set if badblocks are disabled

On Thu, Sep 28, 2017 at 09:57:41AM +0800, Guoqing Jiang wrote: > > > On 09/28/2017 06:13 AM, Liu Bo wrote: > > MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if > > badblocks are disabled, otherwise, rdev_set_badblocks() will record > > superblock changes and return success in

Re: [PATCH 8/9] nvme: implement multipath access to nvme subsystems

On Mon, Sep 25, 2017 at 03:40:30PM +0200, Christoph Hellwig wrote: > The new block devices nodes for multipath access will show up as > > /dev/nvm-subXnZ Just thinking ahead ... Once this goes in, someone will want to boot their OS from a multipath target. It was a pain getting installers

[PATCH] lightnvm: pblk: fix changing GC group list for a line

pblk_line_gc_list seems to had a bug since the introduction of pblk in getting GC list for a line. In b20ba1bc7 while redesigning GC algorithm it was not fixed correctly. The problem is that even if valid sector count (vsc) is less that mid_thrs (threshold for GC mid list) it would always

Re: [PATCH] blk-throttle: fix possible io stall when doing upgrade

On 17/9/28 11:48, Joseph Qi wrote: > Hi Shahua, > > On 17/9/28 05:38, Shaohua Li wrote: >> On Tue, Sep 26, 2017 at 11:16:05AM +0800, Joseph Qi wrote: >>> >>> >>> On 17/9/26 10:48, Shaohua Li wrote: On Tue, Sep 26, 2017 at 09:06:57AM +0800, Joseph Qi wrote: > Hi Shaohua, > > On

Re: [PATCH V6 0/6] block/scsi: safe SCSI quiescing

Hey. I can confirm that v6 of your patchset still works well for me. Tested on v4.13 kernel. Thanks. On středa 27. září 2017 10:52:41 CEST Ming Lei wrote: > On Wed, Sep 27, 2017 at 04:27:51PM +0800, Ming Lei wrote: > > On Wed, Sep 27, 2017 at 09:57:37AM +0200, Martin Steigerwald wrote: > > >

Re: [PATCH 1/2 v6] mmc: block: Convert RPMB to a character device

On Wed, 27 Sep 2017 21:45:58 +0200 Linus Walleij wrote: > On Wed, Sep 27, 2017 at 1:35 PM, Adrian Hunter > wrote: > > > > BUG when removing, fixed by reverting this patch. > > > > [ 346.548512] mmc1: card 0001 removed > > [ 346.552782] BUG: unable to handle kernel