Re: [PATCH v3 8/8] scsi/pmcraid: Use sgl_alloc_order() and sgl_free_order()

2017-11-05 Thread Hannes Reinecke
On 11/03/2017 11:23 PM, Bart Van Assche wrote: > Use the sgl_alloc_order() and sgl_free_order() functions instead > of open coding these functions. > > Signed-off-by: Bart Van Assche > Reviewed-by: Johannes Thumshirn > Cc: linux-s...@vger.kernel.org > Cc: Martin K. Petersen > Cc: Anil Ravindran

Re: [PATCH v3 7/8] scsi/pmcraid: Remove an unused structure member

2017-11-05 Thread Hannes Reinecke
On 11/03/2017 11:23 PM, Bart Van Assche wrote: > Signed-off-by: Bart Van Assche > Reviewed-by: Johannes Thumshirn > Cc: linux-s...@vger.kernel.org > Cc: Martin K. Petersen > Cc: Anil Ravindranath > --- > drivers/scsi/pmcraid.h | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Hannes Reine

Re: [PATCH v3 5/8] target: Use sgl_alloc_order() and sgl_free()

2017-11-05 Thread Hannes Reinecke
On 11/03/2017 11:23 PM, Bart Van Assche wrote: > Use the sgl_alloc_order() and sgl_free() functions instead of open > coding these functions. > > Signed-off-by: Bart Van Assche > Cc: Nicholas A. Bellinger > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Sagi Grimberg > --- > drivers/targe

Re: [PATCH] blk-mq: respect queue dead via blk_mq_quiesce_queue

2017-11-05 Thread Ming Lei
On Sun, Nov 05, 2017 at 03:38:49PM +, Bart Van Assche wrote: > On Sun, 2017-11-05 at 20:10 +0800, Ming Lei wrote: > > diff --git a/block/blk-core.c b/block/blk-core.c > > index 048be4aa6024..0b121f29e3b1 100644 > > --- a/block/blk-core.c > > +++ b/block/blk-core.c > > @@ -658,6 +658,10 @@ void

Re: high overhead of functions blkg_*stats_* in bfq

2017-11-05 Thread Jens Axboe
On 11/05/2017 01:39 AM, Paolo Valente wrote: > >> Il giorno 18 ott 2017, alle ore 15:19, Tejun Heo ha >> scritto: >> >> Hello, Paolo. >> >> On Tue, Oct 17, 2017 at 12:11:01PM +0200, Paolo Valente wrote: >> ... >>> protected by a per-device scheduler lock. To give you an idea, on an >>> Intel i7

[PATCH] blk-throttle: fix wrong initialization in case of dm device

2017-11-05 Thread Joseph Qi
From: Joseph Qi dm device set QUEUE_FLAG_NONROT in resume, which is after register queue. That is to mean, the previous initialization in blk_throtl_register_queue is wrong in this case. Fix it by checking and then updating the info during root tg initialization as we don't have a better choice.

Re: possible deadlock in blkdev_reread_part

2017-11-05 Thread Eric Biggers
On Wed, Nov 01, 2017 at 10:02:44PM +0300, 'Dmitry Vyukov' via syzkaller-bugs wrote: > > Still happens on linux-next 36ef71cae353f88fd6e095e2aaa3e5953af1685d (Oct 20). > Note repro needs to be compiled with -m32 > > [ 243.819514] == > [ 243.82

[PATCH 2/2] blktrace: fix unlocked registration of tracepoints

2017-11-05 Thread Jens Axboe
We need to ensure that tracepoints are registered and unregistered with the users of them. The existing atomic count isn't enough for that. Add a lock around the tracepoints, so we serialize access to them. This fixes cases where we have multiple users setting up and tearing down tracepoints, like

[PATCH 1/2] blktrace: fix unlocked access to init/start-stop/teardown

2017-11-05 Thread Jens Axboe
sg.c calls into the blktrace functions without holding the proper queue mutex for doing setup, start/stop, or teardown. Add internal unlocked variants, and export the ones that do the proper locking. Fixes: 6da127ad0918 ("blktrace: Add blktrace ioctls to SCSI generic devices") Signed-off-by: Jens

[PATCH v2] blktrace: cleanup/fix registration locking

2017-11-05 Thread Jens Axboe
One patch that fixes up a discrepancy in how we lock the queue for blktrace registration, and one that fixes up how we globally serialize registering the tracepoints.

Re: [PATCH] blk-mq: respect queue dead via blk_mq_quiesce_queue

2017-11-05 Thread Bart Van Assche
On Sun, 2017-11-05 at 20:10 +0800, Ming Lei wrote: > diff --git a/block/blk-core.c b/block/blk-core.c > index 048be4aa6024..0b121f29e3b1 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -658,6 +658,10 @@ void blk_cleanup_queue(struct request_queue *q) > queue_flag_set(QUEUE_FLAG_

Re: [PATCH 6/6] nvme: split __nvme_revalidate_disk

2017-11-05 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 3/6] nvme: don't pass struct nvme_ns to nvme_init_integrity

2017-11-05 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 2/6] nvme: always unregister the integrity profile in __nvme_revalidate_disk

2017-11-05 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 1/6] nvme: move the dying queue check from cancel to completion

2017-11-05 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

[PATCH] blk-mq: respect queue dead via blk_mq_quiesce_queue

2017-11-05 Thread Ming Lei
blk-mq never respects queue dead, and this may cause use-after-free on any kind of queue resources. This patch respects the rule by calling blk_mq_quiesce_queue() when queue is marked as DEAD. This patch fixes the following kernel crash: [ 42.170824] BUG: unable to handle kernel NULL pointer de

Re: high overhead of functions blkg_*stats_* in bfq

2017-11-05 Thread Paolo Valente
> Il giorno 18 ott 2017, alle ore 15:19, Tejun Heo ha scritto: > > Hello, Paolo. > > On Tue, Oct 17, 2017 at 12:11:01PM +0200, Paolo Valente wrote: > ... >> protected by a per-device scheduler lock. To give you an idea, on an >> Intel i7-4850HQ, and with 8 threads doing random I/O in parallel

[PATCH] block: pass full fmode_t to blk_verify_command

2017-11-05 Thread Christoph Hellwig
Use the obvious calling convention. Signed-off-by: Christoph Hellwig --- block/bsg.c| 18 -- block/scsi_ioctl.c | 8 drivers/scsi/sg.c | 2 +- include/linux/blkdev.h | 2 +- 4 files changed, 14 insertions(+), 16 deletions(-) diff --git a/block/bs