[GIT PULL] Block IO bits for 4.16-rc5

a revert for a sysfs fix that caused some user space confusion. - Two bcache fixes by way of Michael Lyle. - A loop regression fix, fixing an issue with lost writes on DAX. Please pull! git://git.kernel.dk/linux-block.git tags/for-linus-20180309

VLA removal, device_handler and COMMAND_SIZE

Hi, I’ve been looking into removing some VLAs from device_handler drivers, prompted by https://lkml.org/lkml/2018/3/7/621 The uses in question here are quite straightforward, e.g. in drivers/scsi/device_handler/scsi_dh_alua.c: u8 cdb[COMMAND_SIZE(MAINTENANCE_IN)]; There’s no trivial

Re: [PATCH] device_handler: remove VLAs

On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > scsi_dh_{alua,emc,rdac} use variable-length array declarations to > store command blocks, with the appropriate size as determined by >

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > +/* > + * SCSI command sizes are as follows, in bytes, for fixed size commands, per > + * group: 6, 10, 10, 12, 16, 12, 10, 10. The top three bits of an opcode > + * determine its group. > + * The size table is encoded into a 32-bit value by

[PATCH] scsi: resolve COMMAND_SIZE at compile time

COMMAND_SIZE currently uses an array of values in block/scsi_ioctl.c. A number of device_handler functions use this to initialise arrays, and this is flagged by -Wvla. This patch replaces COMMAND_SIZE with a variant using a formula which can be resolved at compile time in cases where the opcode

[PATCH] device_handler: remove VLAs

In preparation to enabling -Wvla, remove VLAs and replace them with fixed-length arrays instead. scsi_dh_{alua,emc,rdac} use variable-length array declarations to store command blocks, with the appropriate size as determined by COMMAND_SIZE. This patch replaces these with fixed-sized arrays using

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

From: Ming Lei Sent: Thursday, March 8, 2018 7:32 PM To: James Bottomley; Jens Axboe; Martin K . Petersen Cc: Christoph Hellwig; linux-s...@vger.kernel.org; linux-block@vger.kernel.org; Meelis Roos; Don Brace; Kashyap Desai; Laurence

Newly initialized DVD+RW treated as zero length by the block layer

A couple of weeks ago I submitted a proposed patch to extend BLKRRPART It got zero response which I assume means no dice to that approach. So, does anyone have another suggestion about how to deal with this issue? The readable size of new, factory blank, optical media can change via user space

Re: [PATCH] blk-mq-debugfs: Show more request state information

On 3/8/18 4:27 PM, Bart Van Assche wrote: > Since commit 634f9e4631a8 ("blk-mq: remove REQ_ATOM_COMPLETE usages > from blk-mq") blk_rq_is_complete() only reports whether or not a > request has completed for legacy queues. Hence modify the > blk-mq-debugfs code such that it shows the blk-mq request

Re: [PATCH] block: Suppress kernel-doc warnings triggered by blk-zoned.c

On 3/8/18 4:28 PM, Bart Van Assche wrote: > Avoid that building with W=1 causes the kernel-doc tool to complain > about undocumented function arguments for the blk-zoned.c source file. Applied, thanks. -- Jens Axboe

Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible

On Fri, 9 Mar 2018, Ming Lei wrote: > On Fri, Mar 09, 2018 at 11:08:54AM +0100, Thomas Gleixner wrote: > > > > So my understanding is that these irq patches are enhancements and not > > > > bug > > > > fixes. I'll queue them for 4.17 then. > > > > > > Wrt. this IO hang issue, these patches

Re: [PATCH V4 0/4] SCSI: fix selection of reply(hw) queue

> V4: > - splitted from previous patchset > - handle virtio-scsi by force_blk_mq > > Ming Lei (4): > scsi: hpsa: fix selection of reply queue > scsi: megaraid_sas: fix selection of reply queue > scsi: introduce force_blk_mq > scsi: virtio_scsi: fix IO hang caused by irq vector

RE: [PATCH V4 2/4] scsi: megaraid_sas: fix selection of reply queue

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Friday, March 9, 2018 5:33 PM > To: Kashyap Desai > Cc: James Bottomley; Jens Axboe; Martin K . Petersen; Christoph Hellwig; > linux-s...@vger.kernel.org; linux-block@vger.kernel.org; Meelis Roos; Don > Brace;

Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible

On Fri, Mar 09, 2018 at 11:08:54AM +0100, Thomas Gleixner wrote: > On Fri, 9 Mar 2018, Ming Lei wrote: > > On Fri, Mar 09, 2018 at 12:20:09AM +0100, Thomas Gleixner wrote: > > > On Thu, 8 Mar 2018, Ming Lei wrote: > > > > Actually, it isn't a real fix, the real one is in the following two: > > > >

Re: [PATCH V4 2/4] scsi: megaraid_sas: fix selection of reply queue

On Fri, Mar 09, 2018 at 04:37:56PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Friday, March 9, 2018 9:02 AM > > To: James Bottomley; Jens Axboe; Martin K . Petersen > > Cc: Christoph Hellwig; linux-s...@vger.kernel.org;

RE: [PATCH V4 2/4] scsi: megaraid_sas: fix selection of reply queue

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Friday, March 9, 2018 9:02 AM > To: James Bottomley; Jens Axboe; Martin K . Petersen > Cc: Christoph Hellwig; linux-s...@vger.kernel.org; linux- > bl...@vger.kernel.org; Meelis Roos; Don Brace; Kashyap Desai;

Re: [PATCH V3 0/4] genirq/affinity: irq vector spread among online CPUs as far as possible

On Fri, 9 Mar 2018, Ming Lei wrote: > On Fri, Mar 09, 2018 at 12:20:09AM +0100, Thomas Gleixner wrote: > > On Thu, 8 Mar 2018, Ming Lei wrote: > > > Actually, it isn't a real fix, the real one is in the following two: > > > > > > 0c20244d458e scsi: megaraid_sas: fix selection of reply queue > >

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Fri, Mar 09, 2018 at 12:26:57PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Thursday, March 8, 2018 4:54 PM > > To: Kashyap Desai > > Cc: Jens Axboe; linux-block@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > >