Re: [for-4.17 20/20] bcache: Fix a compiler warning in bcache_device_init()

2018-03-21 Thread Coly Li
On 22/03/2018 2:38 AM, Michael Lyle wrote: > On 03/18/2018 06:32 PM, Coly Li wrote: >> On 19/03/2018 8:36 AM, Michael Lyle wrote: >>> From: Bart Van Assche >>> >>> Avoid that building with W=1 triggers the following compiler warning: >>> >>> drivers/md/bcache/super.c:776:20: warning: comparison is

Re: [PATCH] Fix slab name "biovec-(1<<(21-12))"

2018-03-21 Thread Jens Axboe
On 3/21/18 10:49 AM, Mikulas Patocka wrote: > I'm getting a slab named "biovec-(1<<(21-12))". It is caused by unintended > expansion of the macro BIO_MAX_PAGES. This patch renames it to biovec-max. Applied, thanks. -- Jens Axboe

Re: [PATCH 08/12] lightnvm: implement get log report chunk helpers

2018-03-21 Thread Javier Gonzalez
> On 21 Mar 2018, at 20.27, Matias Bjørling wrote: > >> On 03/21/2018 03:36 PM, Keith Busch wrote: >> On Wed, Mar 21, 2018 at 03:06:05AM -0700, Matias Bjørling wrote: outside of nvme core so that we can use it form lightnvm. Signed-off-by: Javier González --- drivers

Re: [PATCH 08/12] lightnvm: implement get log report chunk helpers

2018-03-21 Thread Matias Bjørling
On 03/21/2018 03:36 PM, Keith Busch wrote: On Wed, Mar 21, 2018 at 03:06:05AM -0700, Matias Bjørling wrote: outside of nvme core so that we can use it form lightnvm. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 11 +++ drivers/nvme/host/core.c | 6 ++-- dri

Re: [for-4.17 20/20] bcache: Fix a compiler warning in bcache_device_init()

2018-03-21 Thread Michael Lyle
On 03/18/2018 06:32 PM, Coly Li wrote: > On 19/03/2018 8:36 AM, Michael Lyle wrote: >> From: Bart Van Assche >> >> Avoid that building with W=1 triggers the following compiler warning: >> >> drivers/md/bcache/super.c:776:20: warning: comparison is always false due to >> limited range of data type

Re: [PATCH] block: use 32-bit blk_status_t on Alpha

2018-03-21 Thread Jens Axboe
On 3/21/18 11:00 AM, Mikulas Patocka wrote: > > > On Wed, 21 Mar 2018, Jens Axboe wrote: > >> On 3/21/18 10:42 AM, Mikulas Patocka wrote: >>> Early alpha processors cannot write a single byte or word; they read 8 >>> bytes, modify the value in registers and write back 8 bytes. >>> >>> The type b

Re: [PATCH] block: use 32-bit blk_status_t on Alpha

2018-03-21 Thread Mikulas Patocka
On Wed, 21 Mar 2018, Jens Axboe wrote: > On 3/21/18 10:42 AM, Mikulas Patocka wrote: > > Early alpha processors cannot write a single byte or word; they read 8 > > bytes, modify the value in registers and write back 8 bytes. > > > > The type blk_status_t is defined as one byte, it is often writ

Re: [PATCH v3 11/11] nvmet: Optionally use PCI P2P memory

2018-03-21 Thread Logan Gunthorpe
On 21/03/18 03:27 AM, Christoph Hellwig wrote: >> + const char *page, size_t count) >> +{ >> +struct nvmet_port *port = to_nvmet_port(item); >> +struct device *dev; >> +struct pci_dev *p2p_dev = NULL; >> +bool use_p2pmem; >> + >> +switch (page[0])

Re: [PATCH] block: use 32-bit blk_status_t on Alpha

2018-03-21 Thread Jens Axboe
On 3/21/18 10:42 AM, Mikulas Patocka wrote: > Early alpha processors cannot write a single byte or word; they read 8 > bytes, modify the value in registers and write back 8 bytes. > > The type blk_status_t is defined as one byte, it is often written > asynchronously by I/O completion routines, thi

[PATCH] Fix slab name "biovec-(1<<(21-12))"

2018-03-21 Thread Mikulas Patocka
I'm getting a slab named "biovec-(1<<(21-12))". It is caused by unintended expansion of the macro BIO_MAX_PAGES. This patch renames it to biovec-max. Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org # v4.14+ --- block/bio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] block: use 32-bit blk_status_t on Alpha

2018-03-21 Thread Mikulas Patocka
Early alpha processors cannot write a single byte or word; they read 8 bytes, modify the value in registers and write back 8 bytes. The type blk_status_t is defined as one byte, it is often written asynchronously by I/O completion routines, this asynchronous modification can corrupt content of nea

Re: [PATCH 08/12] lightnvm: implement get log report chunk helpers

2018-03-21 Thread Keith Busch
On Wed, Mar 21, 2018 at 03:06:05AM -0700, Matias Bjørling wrote: > > outside of nvme core so that we can use it form lightnvm. > > > > Signed-off-by: Javier González > > --- > > drivers/lightnvm/core.c | 11 +++ > > drivers/nvme/host/core.c | 6 ++-- > > drivers/nvme/host/lightn

Re: [PATCH 08/12] lightnvm: implement get log report chunk helpers

2018-03-21 Thread Matias Bjørling
On 03/02/2018 04:21 PM, Javier González wrote: The 2.0 spec provides a report chunk log page that can be retrieved using the stangard nvme get log page. This replaces the dedicated get/put bad block table in 1.2. This patch implements the helper functions to allow targets retrieve the chunk meta

Re: [PATCH v3 07/11] IB/core: Ensure we map P2P memory correctly in rdma_rw_ctx_[init|destroy]()

2018-03-21 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 06/11] block: Introduce PCI P2P flags for request and request queue

2018-03-21 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH v3 11/11] nvmet: Optionally use PCI P2P memory

2018-03-21 Thread Christoph Hellwig
> + const char *page, size_t count) > +{ > + struct nvmet_port *port = to_nvmet_port(item); > + struct device *dev; > + struct pci_dev *p2p_dev = NULL; > + bool use_p2pmem; > + > + switch (page[0]) { > + case 'y': > + case 'Y': > + case

Re: [PATCH v3 09/11] nvme-pci: Add support for P2P memory in requests

2018-03-21 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig