Re: testing io.low limit for blk-throttle

2018-04-22 Thread jianchao.wang
Hi Paolo On 04/23/2018 01:32 PM, Paolo Valente wrote: > Thanks for sharing this fix. I tried it too, but nothing changes in > my test :(> That's really sad. > At this point, my doubt is still: am I getting io.low limit right? I > understand that an I/O-bound group should be guaranteed a rbps

Re: testing io.low limit for blk-throttle

2018-04-22 Thread Joseph Qi
Hi Paolo, What's your idle and latency config? IMO, io.low will allow others run more bandwidth if cgroup's average idle time is high or latency is low. In such cases, low limit won't get guaranteed. Thanks, Joseph On 18/4/22 17:23, Paolo Valente wrote: > Hi Shaohua, all, > at last, I started tes

Re: testing io.low limit for blk-throttle

2018-04-22 Thread Paolo Valente
> Il giorno 23 apr 2018, alle ore 04:19, jianchao.wang > ha scritto: > > Hi Paolo > > As I said, I used to meet similar scenario. > After dome debug, I found out 3 issues. > > Here is my setup command: > mkdir test0 test1 > echo "259:0 riops=15" > test0/io.max > echo "259:0 riops=15

Re: question about request merge

2018-04-22 Thread Zhengyuan Liu
2018-04-22 0:23 GMT+08:00 Jens Axboe : > On 4/21/18 8:07 AM, Zhengyuan Liu wrote: >> 2018-04-20 22:34 GMT+08:00 Jens Axboe : >>> On 4/19/18 9:51 PM, Zhengyuan Liu wrote: Hi, Shaohua I found it indeed doesn't do front merge when two threads flush plug list concurrently. To >>

Re: testing io.low limit for blk-throttle

2018-04-22 Thread jianchao.wang
Hi Paolo As I said, I used to meet similar scenario. After dome debug, I found out 3 issues. Here is my setup command: mkdir test0 test1 echo "259:0 riops=15" > test0/io.max echo "259:0 riops=15" > test1/io.max echo "259:0 riops=15" > test2/io.max echo "259:0 riops=5 wiops=5000

Re: testing io.low limit for blk-throttle

2018-04-22 Thread Paolo Valente
> Il giorno 22 apr 2018, alle ore 15:29, jianchao.wang > ha scritto: > > Hi Paolo > > I used to meet similar issue on io.low. > Can you try the following patch to see whether the issue could be fixed. > https://marc.info/?l=linux-block&m=152325456307423&w=2 > https://marc.info/?l=linux-block&

Re: [PATCH 3/3] xen blkback: add fault injection facility

2018-04-22 Thread kbuild test robot
/linux/commits/Stanislav-Kinsburskii/Introduce-Xen-fault-injection-facility/20180422-201946 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones

Re: testing io.low limit for blk-throttle

2018-04-22 Thread jianchao.wang
Hi Paolo I used to meet similar issue on io.low. Can you try the following patch to see whether the issue could be fixed. https://marc.info/?l=linux-block&m=152325456307423&w=2 https://marc.info/?l=linux-block&m=152325457607425&w=2 Thanks Jianchao On 04/22/2018 05:23 PM, Paolo Valente wrote: > H

testing io.low limit for blk-throttle

2018-04-22 Thread Paolo Valente
Hi Shaohua, all, at last, I started testing your io.low limit for blk-throttle. One of the things I'm interested in is how good throttling is in achieving a high throughput in the presence of realistic, variable workloads. However, I seem to have bumped into a totally different problem. The io.l

Re: [PATCH] bsg referencing bus driver module

2018-04-22 Thread James Bottomley
On Fri, 2018-04-20 at 16:44 -0600, Anatoliy Glagolev wrote: >   > > This patch isn't applyable because your mailer has changed all the > > tabs to spaces. > > > > I also think there's no need to do it this way.  I think what we > > need is for fc_bsg_remove() to wait until the bsg queue is > > dra