I'm looking into an issue where removing a virtio disk via sysfs while another
process is issuing write() calls results in the writing task going into a
livelock:
root@guest # cat test.sh
#!/bin/bash
dd if=/dev/zero of=/dev/vda bs=1M count=1 &
sleep 1
echo 1 > /sys/bus/pci/devices/:00:04
> Il giorno 25 apr 2018, alle ore 20:18, Jens Axboe ha
> scritto:
>
> On 4/25/18 12:02 PM, Paolo Valente wrote:
>>
>>
>>> Il giorno 25 apr 2018, alle ore 19:34, Jens Axboe ha
>>> scritto:
>>>
>>> On 4/25/18 11:25 AM, Paolo Valente wrote:
> Il giorno 25 apr 2018, alle ore 1
On 4/25/18 12:02 PM, Paolo Valente wrote:
>
>
>> Il giorno 25 apr 2018, alle ore 19:34, Jens Axboe ha
>> scritto:
>>
>> On 4/25/18 11:25 AM, Paolo Valente wrote:
>>>
>>>
Il giorno 25 apr 2018, alle ore 19:06, Jens Axboe ha
scritto:
On 4/25/18 11:03 AM, Paolo Valente wrote:
On Wed, Apr 18, 2018 at 12:51:31PM +0300, Dan Carpenter wrote:
> This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned
> long. The way the check is written now, if one of the high 32 bits is
> set then we could read outside the info->slots[] array.
>
> This bug is pretty old and
> Il giorno 25 apr 2018, alle ore 19:34, Jens Axboe ha
> scritto:
>
> On 4/25/18 11:25 AM, Paolo Valente wrote:
>>
>>
>>> Il giorno 25 apr 2018, alle ore 19:06, Jens Axboe ha
>>> scritto:
>>>
>>> On 4/25/18 11:03 AM, Paolo Valente wrote:
> Il giorno 25 apr 2018, alle ore 1
On Wed, Apr 25, 2018 at 08:56:02AM -0700, Omar Sandoval wrote:
> On Tue, Apr 24, 2018 at 03:41:46PM -0600, Keith Busch wrote:
> > +_test_hotplug_slot() {
>
> I'd call this _test_dev_in_hotplug_slot().
Sounds good.
> > + parent="$(_get_pci_parent_from_blkdev)"
>
> I haven't been consistent ab
On 4/25/18 11:25 AM, Paolo Valente wrote:
>
>
>> Il giorno 25 apr 2018, alle ore 19:06, Jens Axboe ha
>> scritto:
>>
>> On 4/25/18 11:03 AM, Paolo Valente wrote:
>>>
>>>
Il giorno 25 apr 2018, alle ore 18:50, Jens Axboe ha
scritto:
Hi Linus,
I ended up sitting on
> Il giorno 25 apr 2018, alle ore 19:06, Jens Axboe ha
> scritto:
>
> On 4/25/18 11:03 AM, Paolo Valente wrote:
>>
>>
>>> Il giorno 25 apr 2018, alle ore 18:50, Jens Axboe ha
>>> scritto:
>>>
>>> Hi Linus,
>>>
>>> I ended up sitting on this about a week longer than I wanted to,
>>> since
On 4/25/18 11:03 AM, Paolo Valente wrote:
>
>
>> Il giorno 25 apr 2018, alle ore 18:50, Jens Axboe ha
>> scritto:
>>
>> Hi Linus,
>>
>> I ended up sitting on this about a week longer than I wanted to,
>> since we were hashing out details with a timeout change. I've now
>> killed that patch, so
- Revert of a change from this merge window from Ming, that causes an
> issue on some hardware.
>
> - Minor clarification doc addition from Linus Walleij.
>
> Please pull!
>
>
> git://git.kernel.dk/linux-block.git tags/for-linus-20180425
>
>
> -
of a change from this merge window from Ming, that causes an
issue on some hardware.
- Minor clarification doc addition from Linus Walleij.
Please pull!
git://git.kernel.dk/linux-block.git tags/for-linus-20180425
Alan Jenki
On 4/24/18 2:01 PM, Ming Lei wrote:
> This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
>
> Turns out some drivers(most are FC drivers) may not use managed
> IRQ affinity, and has their customized .map_queues meantime, so
> still keep this code for avoiding regression.
Applied, thanks
On Wed, Apr 25, 2018 at 09:52:12AM -0600, Johannes Thumshirn wrote:
> On Wed, Apr 25, 2018 at 08:30:36AM -0700, Omar Sandoval wrote:
> [...]
> > The TODO comment was leftover here, I removed it.
>
> Oops sorry.
I should probably rename it `make check` and have it check for leftover
TODO comments
On Tue, Apr 24, 2018 at 03:41:46PM -0600, Keith Busch wrote:
> Signed-off-by: Keith Busch
Hey, Keith, thanks for the test! Some comments/questions below.
> ---
> common/rc | 17 +
> tests/block/016 | 52
> 2 files change
On Wed, Apr 25, 2018 at 08:30:36AM -0700, Omar Sandoval wrote:
[...]
> The TODO comment was leftover here, I removed it.
Oops sorry.
> > +DESCRIPTION="Test nvme and nvmet UUID NS descriptors"
> > +
> > +QUICK=1
> > +
> > +requires() {
> > + _have_program nvme && _have_module nvme-loop && _have_
On 24.04.2018 22:01, Ming Lei wrote:
This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
Turns out some drivers(most are FC drivers) may not use managed
IRQ affinity, and has their customized .map_queues meantime, so
still keep this code for avoiding regression.
Reported-by: Laurence
On Tue, Apr 24, 2018 at 10:12:51AM -0600, Johannes Thumshirn wrote:
> Add a regression test for NVMe 1.3's UUID Namespace Descriptors.
>
> Signed-off-by: Johannes Thumshirn
Thanks, Johannes, applied. A couple of comments below for future
reference.
> ---
> tests/nvme/004 | 74
> ++
On 04/25/2018 03:59 PM, Jens Axboe wrote:
> On 4/25/18 2:38 AM, Stefan Haberland wrote:
>> On 25.04.2018 09:41, Christian Borntraeger wrote:
>>> On 04/24/2018 10:01 PM, Ming Lei wrote:
This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
Turns out some drivers(most are FC
On 4/25/18 2:38 AM, Stefan Haberland wrote:
> On 25.04.2018 09:41, Christian Borntraeger wrote:
>> On 04/24/2018 10:01 PM, Ming Lei wrote:
>>> This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
>>>
>>> Turns out some drivers(most are FC drivers) may not use managed
>>> IRQ affinity, and
On Wed 25-04-18 00:07:07, Holger Hoffstätte wrote:
> On 04/24/18 19:34, Christoph Hellwig wrote:
> > On Sat, Apr 21, 2018 at 02:54:05PM +0200, Jan Kara wrote:
> > > > - if (iocb->ki_flags & IOCB_DSYNC)
> > > > + if (iocb->ki_flags & IOCB_DSYNC) {
> > > >
Dear Bart,
On 04/25/18 14:26, Bart Van Assche wrote:
On Wed, 2018-04-25 at 07:37 +0200, Paul Menzel wrote:
Am 24.04.2018 um 23:17 schrieb Bart Van Assche:
On Tue, 2018-04-24 at 23:04 +0200, Paul Menzel wrote:
I applied your change, and rebuilt the Linux kernel. Unfortunately, it
looks like,
On Wed, 2018-04-25 at 07:37 +0200, Paul Menzel wrote:
> Am 24.04.2018 um 23:17 schrieb Bart Van Assche:
> > On Tue, 2018-04-24 at 23:04 +0200, Paul Menzel wrote:
> > > I applied your change, and rebuilt the Linux kernel. Unfortunately, it
> > > looks like, it didn’t make a difference.
> >
> > In t
Hi Paolo,
On 18/4/24 20:12, Paolo Valente wrote:
>
>
>> Il giorno 23 apr 2018, alle ore 11:01, Joseph Qi ha
>> scritto:
>>
>>
>>
>> On 18/4/23 15:35, Paolo Valente wrote:
>>>
>>>
Il giorno 23 apr 2018, alle ore 08:05, Joseph Qi ha
scritto:
Hi Paolo,
>>>
>>> Hi Joseph,
>>>
On Tue, Apr 24, 2018 at 03:14:10PM +0200, Luc Van Oostenryck wrote:
> print_st_err() is defined with its 4th argument taking an
> 'enum drbd_state_rv' but its prototype use an int for it.
>
> Fix this by using 'enum drbd_state_rv' in the prototype too.
>
> Signed-off-by: Luc Van Oostenryck
> ---
On 24/04/2018, Omar Sandoval wrote:
> On Tue, Apr 17, 2018 at 04:21:36PM +0100, Alan Jenkins wrote:
>> > Without this fix, I get an IO error in this test:
>> >
>> > # dd if=/dev/sda of=/dev/null iflag=direct & \
>> > while killall -SIGUSR1 dd; do sleep 0.1; done & \
>> > echo mem > /sys/power/
On 25.04.2018 09:41, Christian Borntraeger wrote:
On 04/24/2018 10:01 PM, Ming Lei wrote:
This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
Turns out some drivers(most are FC drivers) may not use managed
IRQ affinity, and has their customized .map_queues meantime, so
still keep this
On 04/24/2018 10:01 PM, Ming Lei wrote:
> This reverts commit 37c7c6c76d431dd7ef9c29d95f6052bd425f004c.
>
> Turns out some drivers(most are FC drivers) may not use managed
> IRQ affinity, and has their customized .map_queues meantime, so
> still keep this code for avoiding regression.
>
> Report
27 matches
Mail list logo