Fixes the following sparse warning:
drivers/lightnvm/pblk-init.c:23:14: warning:
symbol 'write_buffer_size' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/lightnvm/pblk-init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pb
I noticed that this patch is forgotten at ext4.git#loop-fix and therefore
is not available at linux-next.git . Please be sure to include for 4.18 .
On 2018/05/08 0:37, Theodore Ts'o wrote:
> Refactor the validation code used in LOOP_SET_FD so it is also used in
> LOOP_CHANGE_FD. Otherwise it is p
On Mon, Jun 04, 2018 at 10:40:12AM -0600, kvi...@gmail.com wrote:
> From: Kevin Vigor
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
Reviewed
On 6/4/18 10:40 AM, kvi...@gmail.com wrote:
> From: Kevin Vigor
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
You're missing the Signed-off-
On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote:
> On 6/4/18 10:40 AM, kvi...@gmail.com wrote:
> > From: Kevin Vigor
> >
> > Existing dev_dbg messages sometimes identify request using request
> > pointer, sometimes using nbd_cmd pointer. This makes it hard to
> > follow request flow. C
On 6/5/18 8:30 AM, Josef Bacik wrote:
> On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote:
>> On 6/4/18 10:40 AM, kvi...@gmail.com wrote:
>>> From: Kevin Vigor
>>>
>>> Existing dev_dbg messages sometimes identify request using request
>>> pointer, sometimes using nbd_cmd pointer. This mak
On Tue, Jun 05, 2018 at 06:47:33AM +0200, Christoph Hellwig wrote:
> But let's assume we don't want to use the list due to this concern:
> we'd still have to read the log page, as per the NVMe spec the only
> think clearing a pending AEN is reading the associated log page.
> We'd then need to still
On Mon, 2018-06-04 at 18:41 -0400, Kent Overstreet wrote:
> On Mon, Jun 04, 2018 at 08:59:39AM +, Bart Van Assche wrote:
> > Please comment out the getuid_callout line from /etc/multipath.conf and try
> > again.
> > Changing the "/..." part into the path of the srp-test software should also
>
On Tue, Jun 05, 2018 at 10:04:56PM +0900, Tetsuo Handa wrote:
> I noticed that this patch is forgotten at ext4.git#loop-fix and therefore
> is not available at linux-next.git . Please be sure to include for 4.18 .
I was assuming Jens was going to send it to Linus, after he does a
review. I could
Hi Linus,
This just contains the dm kzalloc fix that was discussed, and
a fix that I queued up yesterday for a case where blk-mq
doesn't honor the stop bit appropriately.
Please pull!
git://git.kernel.dk/linux-block.git tags/for-linus-201
On 6/5/18 8:51 AM, Theodore Y. Ts'o wrote:
> On Tue, Jun 05, 2018 at 10:04:56PM +0900, Tetsuo Handa wrote:
>> I noticed that this patch is forgotten at ext4.git#loop-fix and therefore
>> is not available at linux-next.git . Please be sure to include for 4.18 .
>
> I was assuming Jens was going to
On 6/5/18 3:15 AM, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/lightnvm/pblk-init.c:23:14: warning:
> symbol 'write_buffer_size' was not declared. Should it be static?
Added, thanks.
--
Jens Axboe
Technically we should be able to get away with 0 as the
discard_alignment, but there's no way currently for the protocol to
indicate different alignments, and in real life most disks have
discard_alignment == discard_granularity. Just set our alignment to our
blocksize to make sure discards will a
On 6/4/18 10:40 AM, kvi...@gmail.com wrote:
> From: Kevin Vigor
>
> Existing dev_dbg messages sometimes identify request using request
> pointer, sometimes using nbd_cmd pointer. This makes it hard to
> follow request flow. Consistently use request pointer instead.
Applied, with the SOB added.
On 6/5/18 9:41 AM, Josef Bacik wrote:
> Technically we should be able to get away with 0 as the
> discard_alignment, but there's no way currently for the protocol to
> indicate different alignments, and in real life most disks have
> discard_alignment == discard_granularity. Just set our alignment
On Wed, May 30, 2018 at 03:26:54AM -0400, Yi Zhang wrote:
> Hi Keith
> I found blktest block/019 also can lead my NVMe server hang with 4.17.0-rc7,
> let me know if you need more info, thanks.
>
> Server: Dell R730xd
> NVMe SSD: 85:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd
On Tue, Jun 05, 2018 at 10:18:53AM -0600, Keith Busch wrote:
> On Wed, May 30, 2018 at 03:26:54AM -0400, Yi Zhang wrote:
> > Hi Keith
> > I found blktest block/019 also can lead my NVMe server hang with
> > 4.17.0-rc7, let me know if you need more info, thanks.
> >
> > Server: Dell R730xd
> > NV
Here is the output, and I can see "HotPlug+ Surprise+" on SltCap
# lspci -vvv -s :83:05.0
83:05.0 PCI bridge: PLX Technology, Inc. PEX 8734 32-lane, 8-Port PCI
Express Gen 3 (8.0GT/s) Switch (rev ab) (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
18 matches
Mail list logo