[GIT PULL] nvme fixes for 4.18

2018-06-07 Thread Christoph Hellwig
Hi Jens, a few more small fixes for NVMe for this merge window: The following changes since commit af6c5d5e01ad9f2c9ca38cccaae6b5d67ddd241f: Merge branch 'for-4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq (2018-06-05 17:31:33 -0700) are available in the Git repository at: g

Re: [PATCH] blktrace: display failfast and driver-specific flags

2018-06-07 Thread Hannes Reinecke
On Thu, 7 Jun 2018 13:24:23 +0200 Christoph Hellwig wrote: > Good idea to display the flags, but the characters aren't really > very self-describing. Should we prefix each with an f maybe? Honestly, I don't care. Just wanted to stick with the one-letter acronym like all the others did. But in t

[PATCH 1/2] block: add bioset_init_from_src() helper

2018-06-07 Thread Jens Axboe
Add a helper that allows a caller to initialize a new bio_set, using the settings from an existing bio_set. Signed-off-by: Jens Axboe --- block/bio.c | 18 ++ include/linux/bio.h | 1 + 2 files changed, 19 insertions(+) diff --git a/block/bio.c b/block/bio.c index 59566

[PATCH 0/2] Fix bio_set copy

2018-06-07 Thread Jens Axboe
After a recent change, dm ends up doing a straight copy of a bio_set. This breaks for various items in that bio_set, most notably lists. Provide a proper helper for it, and use it. -- Jens Axboe

[PATCH 2/2] dm: use bioset_init_from_src() to copy bio_set

2018-06-07 Thread Jens Axboe
We can't just copy and clear a bio_set, use the bio helper to setup a new bio_set with the settings from another one. Fixes: 6f1c819c219f ("dm: convert to bioset_init()/mempool_init()") Signed-off-by: Jens Axboe --- drivers/md/dm.c | 22 -- 1 file changed, 16 insertions(+), 6

[PATCH v2] lightnvm: pblk: handle case when mw_cunits equals to 0

2018-06-07 Thread Marcin Dziegielewski
Some devices can expose mw_cunits equal to 0, it can cause the creation of too small write buffer and cause performance to drop on write workloads. Additionally, write buffer size must cover openchannel write data requirements, such as WS_MIN and MW_CUNITS - it must be greater than or equal to t

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

2018-06-07 Thread Jens Axboe
On 6/7/18 12:55 AM, Johannes Thumshirn wrote: > On Thu, Jun 07, 2018 at 10:45:02AM +0800, bingjingc wrote: >> Hi Johannes & Jens, >> >> Thank you for your information and positive feedbacks on this patch. >> >> I'm also inspired by xfstests, too. Most conventional filesystems >> have their test cas

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Jens Axboe
On 6/7/18 2:29 AM, Hannes Reinecke wrote: > blk_partition_remap() will only clear bi_partno if an actual remapping > has happened. But flush request et al don't have an actual size, so > the remapping doesn't happen and bi_partno is never cleared. > So for stacked devices blk_partition_remap() will

Re: [PATCH] blktrace: display failfast and driver-specific flags

2018-06-07 Thread Christoph Hellwig
Good idea to display the flags, but the characters aren't really very self-describing. Should we prefix each with an f maybe?

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Christoph Hellwig
On Thu, Jun 07, 2018 at 10:29:44AM +0200, Hannes Reinecke wrote: > blk_partition_remap() will only clear bi_partno if an actual remapping > has happened. But flush request et al don't have an actual size, so > the remapping doesn't happen and bi_partno is never cleared. > So for stacked devices blk

Re: [PATCH] block: pass failfast and driver-specific flags to flush requests

2018-06-07 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

[PATCH] blktrace: display failfast and driver-specific flags

2018-06-07 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- kernel/trace/blktrace.c | 8 1 file changed, 8 insertions(+) diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 987d9a9ae283..238e16211a5c 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c @@ -1922,6 +1922,14 @@ void

[PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Hannes Reinecke
blk_partition_remap() will only clear bi_partno if an actual remapping has happened. But flush request et al don't have an actual size, so the remapping doesn't happen and bi_partno is never cleared. So for stacked devices blk_partition_remap() will be called on each level. If (as is the case for n