Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Adam Manzanares
On 6/14/18 1:47 PM, Jens Axboe wrote: > On 6/14/18 2:41 PM, Adam Manzanares wrote: >> >> >> On 6/14/18 1:37 PM, Jens Axboe wrote: >>> On 6/14/18 2:32 PM, Adam Manzanares wrote: On 6/14/18 9:09 AM, Hannes Reinecke wrote: > On Thu, 14 Jun 2018 09:33:35 -0600 > Jens Axboe

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 2:41 PM, Adam Manzanares wrote: > > > On 6/14/18 1:37 PM, Jens Axboe wrote: >> On 6/14/18 2:32 PM, Adam Manzanares wrote: >>> >>> >>> On 6/14/18 9:09 AM, Hannes Reinecke wrote: On Thu, 14 Jun 2018 09:33:35 -0600 Jens Axboe wrote: > On 6/14/18 9:29 AM, Hannes

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Adam Manzanares
On 6/14/18 1:37 PM, Jens Axboe wrote: > On 6/14/18 2:32 PM, Adam Manzanares wrote: >> >> >> On 6/14/18 9:09 AM, Hannes Reinecke wrote: >>> On Thu, 14 Jun 2018 09:33:35 -0600 >>> Jens Axboe wrote: >>> On 6/14/18 9:29 AM, Hannes Reinecke wrote: > On Thu, 14 Jun 2018 08:47:33 -0600 >

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 2:32 PM, Adam Manzanares wrote: > > > On 6/14/18 9:09 AM, Hannes Reinecke wrote: >> On Thu, 14 Jun 2018 09:33:35 -0600 >> Jens Axboe wrote: >> >>> On 6/14/18 9:29 AM, Hannes Reinecke wrote: On Thu, 14 Jun 2018 08:47:33 -0600 Jens Axboe wrote: > On 6/14/18 7:38

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Adam Manzanares
On 6/14/18 9:09 AM, Hannes Reinecke wrote: > On Thu, 14 Jun 2018 09:33:35 -0600 > Jens Axboe wrote: > >> On 6/14/18 9:29 AM, Hannes Reinecke wrote: >>> On Thu, 14 Jun 2018 08:47:33 -0600 >>> Jens Axboe wrote: >>> On 6/14/18 7:38 AM, Hannes Reinecke wrote: > For performance

Re: dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Mike Snitzer
On Thu, Jun 14 2018 at 1:37pm -0400, Luis R. Rodriguez wrote: > On Thu, Jun 14, 2018 at 08:38:06AM -0400, Mike Snitzer wrote: > > On Wed, Jun 13 2018 at 8:11pm -0400, > > Luis R. Rodriguez wrote: > > > > > Setting up a zoned disks in a generic form is not so trivial. There > > > is also

Re: dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Luis R. Rodriguez
On Thu, Jun 14, 2018 at 07:37:19PM +0200, Luis R. Rodriguez wrote: > > Ie a file describing which > disk serial gets deadline and which one gets mq-deadline. > Anyway, let's assume this is done in the kernel, which one would use deadline, > which one would use mq-deadline? Nevermind this,

Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Luis R. Rodriguez
On Thu, Jun 14, 2018 at 04:19:23PM +, Bart Van Assche wrote: > On Wed, 2018-06-13 at 17:11 -0700, Luis R. Rodriguez wrote: > > This tries to put a bit of this tribal knowledge into an initial udev > > rule for development with the hopes Linux distributions can later > > deploy. Three rule are

Re: dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Luis R. Rodriguez
On Thu, Jun 14, 2018 at 08:38:06AM -0400, Mike Snitzer wrote: > On Wed, Jun 13 2018 at 8:11pm -0400, > Luis R. Rodriguez wrote: > > > Setting up a zoned disks in a generic form is not so trivial. There > > is also quite a bit of tribal knowledge with these devices which is not > > easy to find.

Re: dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Bart Van Assche
On Thu, 2018-06-14 at 08:38 -0400, Mike Snitzer wrote: > On Wed, Jun 13 2018 at 8:11pm -0400, > Luis R. Rodriguez wrote: > > 1) scheduler setup > > This is wrong.. if zoned devices are so dependent on deadline or > mq-deadline then the kernel should allow them to be hardcoded. I know > Jens

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Hannes Reinecke
On Thu, 14 Jun 2018 09:33:35 -0600 Jens Axboe wrote: > On 6/14/18 9:29 AM, Hannes Reinecke wrote: > > On Thu, 14 Jun 2018 08:47:33 -0600 > > Jens Axboe wrote: > > > >> On 6/14/18 7:38 AM, Hannes Reinecke wrote: > >>> For performance reasons we should be able to allocate all memory > >>>

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 9:29 AM, Hannes Reinecke wrote: > On Thu, 14 Jun 2018 08:47:33 -0600 > Jens Axboe wrote: > >> On 6/14/18 7:38 AM, Hannes Reinecke wrote: >>> For performance reasons we should be able to allocate all memory >>> from a given NUMA node, so this patch adds a new parameter >>>

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Hannes Reinecke
On Thu, 14 Jun 2018 08:47:33 -0600 Jens Axboe wrote: > On 6/14/18 7:38 AM, Hannes Reinecke wrote: > > For performance reasons we should be able to allocate all memory > > from a given NUMA node, so this patch adds a new parameter > > 'rd_numa_node' to allow the user to specify the NUMA node id.

Re: remove nvme_reinit_tagset and blk_mq_tagset_iter

2018-06-14 Thread Jens Axboe
On 6/14/18 8:54 AM, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 08:45:07AM -0600, Jens Axboe wrote: >> On 6/14/18 6:30 AM, Christoph Hellwig wrote: >>> Now that nvme-fc moved off the reinit request concept both the core nvme >>> and blk-mq code for it becomes unused. >>> >>> Jens, are you

Re: remove nvme_reinit_tagset and blk_mq_tagset_iter

2018-06-14 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 08:45:07AM -0600, Jens Axboe wrote: > On 6/14/18 6:30 AM, Christoph Hellwig wrote: > > Now that nvme-fc moved off the reinit request concept both the core nvme > > and blk-mq code for it becomes unused. > > > > Jens, are you ok with queuing up the blk-mq side with the

Re: remove nvme_reinit_tagset and blk_mq_tagset_iter

2018-06-14 Thread Jens Axboe
On 6/14/18 6:30 AM, Christoph Hellwig wrote: > Now that nvme-fc moved off the reinit request concept both the core nvme > and blk-mq code for it becomes unused. > > Jens, are you ok with queuing up the blk-mq side with the pending nvme > changes? Are you asking if you can queue it up, presumable

Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 01:39:50PM +, Bart Van Assche wrote: > On Thu, 2018-06-14 at 10:01 +, Damien Le Moal wrote: > > Applied. Thanks Luis ! > > Hello Damien, > > Can this still be undone? I agree with Mike that it's wrong to invoke > "/sbin/dmsetup create ... zoned ..." from a udev

[PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Hannes Reinecke
For performance reasons we should be able to allocate all memory from a given NUMA node, so this patch adds a new parameter 'rd_numa_node' to allow the user to specify the NUMA node id. When restricing fio to use the same NUMA node I'm seeing a performance boost of more than 200%. Signed-off-by:

Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Bart Van Assche
On Thu, 2018-06-14 at 10:01 +, Damien Le Moal wrote: > Applied. Thanks Luis ! Hello Damien, Can this still be undone? I agree with Mike that it's wrong to invoke "/sbin/dmsetup create ... zoned ..." from a udev rule. Thanks, Bart.

Re: dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Mike Snitzer
On Wed, Jun 13 2018 at 8:11pm -0400, Luis R. Rodriguez wrote: > Setting up a zoned disks in a generic form is not so trivial. There > is also quite a bit of tribal knowledge with these devices which is not > easy to find. > > The currently supplied demo script works but it is not generic

[PATCH 2/2] blk-mq: remove blk_mq_tagset_iter

2018-06-14 Thread Christoph Hellwig
Unused now that nvme stopped using it. Signed-off-by: Christoph Hellwig --- block/blk-mq-tag.c | 29 - include/linux/blk-mq.h | 2 -- 2 files changed, 31 deletions(-) diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index 70356a2a11ab..09b2ee6694fb 100644

Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup

2018-06-14 Thread Damien Le Moal
On 6/14/18 09:11, Luis R. Rodriguez wrote: > Setting up a zoned disks in a generic form is not so trivial. There > is also quite a bit of tribal knowledge with these devices which is not > easy to find. > > The currently supplied demo script works but it is not generic enough to be > practical

Re: [RFC] cleanup bcache bio handling

2018-06-14 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 09:55:32AM +0800, Ming Lei wrote: > > Agreed about bio_for_each_chunk_all(), but I just looked at the patch that > > introduces them and it looks to me like there's no need, they should just be > > bio_for_each_segment_all(). > > Now we can't change the vector with