Thanks :-)
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9C
On Tue, Jun 26, 2018 at 02:16:26AM +, Bart Van Assche wrote:
> On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote:
> > I run SRP test on Fedora 27, and not run any LIO specific commands
> > to load it, seems it is done automatically.
> >
> > So looks it might not a good idea to fail SRP test if
On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote:
> tests/srp/functions | 1288 +++
Can you please move these into common/srp?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.d
A device may have boundary restrictions where the number of sectors
between boundaries exceeds its max transfer size. In this case, we need
to cap the max size to the smaller of the two limits.
Reported-by: Jitendra Bhivare
Tested-by: Jitendra Bhivare
Cc:
Signed-off-by: Keith Busch
---
includ
On 06/26/18 00:27, Johannes Thumshirn wrote:
On Tue, Jun 26, 2018 at 02:16:26AM +, Bart Van Assche wrote:
On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote:
I run SRP test on Fedora 27, and not run any LIO specific commands
to load it, seems it is done automatically.
So looks it might not
On 06/26/18 01:58, Johannes Thumshirn wrote:
On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote:
tests/srp/functions | 1288 +++
Can you please move these into common/srp?
Let's do that once other tests than those in tests/srp need one or
Hi Bart,
> This series of three patches fixes a crash in the block layer core
> that I encountered while retesting the SRP tests in blktests. Please
> consider these patches for kernel v4.19.
Patches 1 and 2 look fine. However, I'm not sure I'm so keen on patch
3. It looks like it's papering ov
Keith,
> A device may have boundary restrictions where the number of sectors
> between boundaries exceeds its max transfer size. In this case, we need
> to cap the max size to the smaller of the two limits.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
On 06/26/18 08:53, Martin K. Petersen wrote:
This series of three patches fixes a crash in the block layer core
that I encountered while retesting the SRP tests in blktests. Please
consider these patches for kernel v4.19.
Patches 1 and 2 look fine. However, I'm not sure I'm so keen on patch
3.
On 6/26/18 9:14 AM, Keith Busch wrote:
> A device may have boundary restrictions where the number of sectors
> between boundaries exceeds its max transfer size. In this case, we need
> to cap the max size to the smaller of the two limits.
Applied, with the subject typo fixed.
--
Jens Axboe
On Fri, Jun 22, 2018 at 11:17 AM Matias Bjørling wrote:
>
> On 06/18/2018 07:56 PM, Heiner Litz wrote:
> > In the read path, partial reads are currently performed synchronously
> > which affects performance for workloads that generate many partial
> > reads. This patch adds an asynchronous partial
> Guarantees that this is at least 32bit, but this should be at least 64
> bit right?
All 64-bit bitmaps in pblk are unsigned long. If we want to change to
u64 this should be part of a different patch
On Fri, Jun 22, 2018 at 11:17 AM Matias Bjørling wrote:
>
> On 06/18/2018 07:56 PM, Heiner Litz
> On 26 Jun 2018, at 20.47, Heiner Litz wrote:
>
>> On Fri, Jun 22, 2018 at 11:17 AM Matias Bjørling wrote:
>>
>>> On 06/18/2018 07:56 PM, Heiner Litz wrote:
>>> In the read path, partial reads are currently performed synchronously
>>> which affects performance for workloads that generate many
> On 26 Jun 2018, at 21.01, Heiner Litz wrote:
>
>> Guarantees that this is at least 32bit, but this should be at least 64
>> bit right?
>
> All 64-bit bitmaps in pblk are unsigned long. If we want to change to
> u64 this should be part of a different patch
It makes sense to me.
Javier
sig
On Tue, Jun 26, 2018 at 08:24:51AM -0700, Bart Van Assche wrote:
> On 06/26/18 00:27, Johannes Thumshirn wrote:
> > On Tue, Jun 26, 2018 at 02:16:26AM +, Bart Van Assche wrote:
> > > On Tue, 2018-06-26 at 09:37 +0800, Ming Lei wrote:
> > > > I run SRP test on Fedora 27, and not run any LIO spec
On Tue, Jun 26, 2018 at 08:25:40AM -0700, Bart Van Assche wrote:
> On 06/26/18 01:58, Johannes Thumshirn wrote:
> > On Fri, Jun 22, 2018 at 03:19:46PM -0700, Bart Van Assche wrote:
> > > tests/srp/functions | 1288 +++
> >
> > Can you please move these into
On Fri, Jun 22, 2018 at 03:19:31PM -0700, Bart Van Assche wrote:
> Hello Omar,
>
> As promised during LSF/MM, I have converted the srp-tests software to the
> blktests framework. This patch series included all blktests patches I postd
> a few days ago. Please consider this patch series for inclusi
On Mon, Jun 25, 2018 at 07:31:45PM +0800, Ming Lei wrote:
> We never pass 'wait' as true to blk_mq_get_driver_tag(), then won't
> get new hctx passed out.
>
> So cleanup the usage and remove the two extra parameters.
Might be worth mentioning that the last use went away in 0c2a6fe4dc3e
("blk-mq:
On Mon, Jun 25, 2018 at 07:31:46PM +0800, Ming Lei wrote:
> 'hctx' won't be changed at all, so not necessary to pass
> '**hctx' to blk_mq_mark_tag_wait().
>
> Cc: Andrew Jones
> Cc: Christoph Hellwig
> Cc: Omar Sandoval
> Cc: Bart Van Assche
Reviewed-by: Omar Sandoval
> Signed-off-by: Ming
There is no good reason to use different code paths for different
request operations. Hence remove the switch/case statement from
bio_clone_bioset().
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Ming Lei
---
block/bio.c | 15 ++-
1 file changed, 2 insertions(+), 13 dele
On Tue, Jun 26, 2018 at 03:26:24PM -0700, Bart Van Assche wrote:
> There is no good reason to use different code paths for different
> request operations. Hence remove the switch/case statement from
> bio_clone_bioset().
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
> Cc: Ming Lei
>From 5299e0e64dfb33ac3a1f3137b42178734ce20087 Mon Sep 17 00:00:00 2001
The Amiga RDB partition parser module uses int for partition sector
address and count, which will overflow for disks 2 TB and larger.
Use sector_t as type for sector address and size (as expected by
put_partition) to allow us
22 matches
Mail list logo
