Re: [PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE

2018-08-01 Thread Ming Lei
On Wed, Aug 01, 2018 at 04:54:02PM +0200, Christoph Hellwig wrote: > We still hit __blk_recalc_rq_segments at least once per submission, > don't we? Either rather wait with this until we have multi-page bvecs. No. Please see blk_queue_split(), where the physical segment number is always updated,

Re: [PATCH] block: copy ioprio in __bio_clone_fast()

2018-08-01 Thread Jens Axboe
On 8/1/18 8:38 AM, Hannes Reinecke wrote: > We need to copy the io priority, too; otherwise the clone will run > with a different priority than the original one. Looks good, but please make the patch against the block 4.19 branch. -- Jens Axboe

Re: [PATCH 0/3] blk-iolatency related ref counting fixes

2018-08-01 Thread Jens Axboe
On 7/31/18 10:39 AM, Josef Bacik wrote: > These are three ref counting issues we found in testing. They are pretty > straightforward, the first two don't really happen in practice but need to be > fixed, but the last one fixes a real panic we saw pretty regularly in our > stress > testing. They'

Re: [PATCH] block: really disable runtime-pm for blk-mq

2018-08-01 Thread Christoph Hellwig
On Mon, Jul 30, 2018 at 08:02:19PM +0800, Ming Lei wrote: > Runtime PM isn't ready for blk-mq yet, and commit 765e40b675a9 ("block: > disable runtime-pm for blk-mq") tried to disable it. Unfortunately, > it can't take effect in that way since user space still can switch > it on via 'echo auto > /sy

Re: [PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE

2018-08-01 Thread Christoph Hellwig
We still hit __blk_recalc_rq_segments at least once per submission, don't we? Either rather wait with this until we have multi-page bvecs.

Re: [PATCH 1/3] block: don't use bio->bi_vcnt to figure out segment number

2018-08-01 Thread Christoph Hellwig
On Tue, Jul 31, 2018 at 06:49:12PM +0800, Ming Lei wrote: > It is wrong to use bio->bi_vcnt to figure out how many segments > there are in the bio even though CLONED flag isn't set on this bio, > because this bio may be splitted or advanced. > > So always use bio_segments() in blk_recount_segments

Re: [PATCH] block: copy ioprio in __bio_clone_fast()

2018-08-01 Thread Johannes Thumshirn
Good catch, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

[PATCH] block: copy ioprio in __bio_clone_fast()

2018-08-01 Thread Hannes Reinecke
We need to copy the io priority, too; otherwise the clone will run with a different priority than the original one. Fixes: 43b62ce3ff0a ("block: move bio io prio to a new field") Signed-off-by: Hannes Reinecke --- block/bio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/bio.c b/bl

Re: [PATCH] block: only rewind to last split

2018-08-01 Thread Jason Yan
Sorry, please ignore this because I saw Greg Edwards's patch ("block: reset bi_iter.bi_done after splitting bio") already fixed this. On 2018/8/1 17:33, Jason Yan wrote: Commit 63573e359d05 ("bio-integrity: Restore original iterator on verify stage") made the bio-integrity verify function works

[PATCH] block: only rewind to last split

2018-08-01 Thread Jason Yan
Commit 63573e359d05 ("bio-integrity: Restore original iterator on verify stage") made the bio-integrity verify function works fine when the bio is smaller than the queue limit. But since commit 54efd50bfd87 ("block: make generic_make_request handle arbitrarily sized bios") the bio will split in bl