Hi Ben
On Wed, Aug 22, 2018 at 9:22 PM Ben Hutchings wrote:
>
> On Mon, 2018-08-20 at 11:04 +0200, Ricardo Ribalda Delgado wrote:
> > Hello Ming
> > On Mon, Aug 20, 2018 at 10:30 AM Ming Lei wrote:
> [...]
> > > One problem found from your iostat log is that looks there is ~30sec
> > > idle perio
On Thu, Aug 23, 2018 at 01:51:05AM +0100, Ben Hutchings wrote:
> On Thu, 2018-08-23 at 06:02 +0800, Ming Lei wrote:
> > On Wed, Aug 22, 2018 at 08:22:00PM +0100, Ben Hutchings wrote:
> > > On Mon, 2018-08-20 at 11:04 +0200, Ricardo Ribalda Delgado wrote:
> > > > Hello Ming
> > > > On Mon, Aug 20, 2
On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> On Mon, Aug 20, 2018 at 03:46:45PM +, Bart Van Assche wrote:
> > Moving these tests into the nvme directory is possible but will make it
> > harder to run the NVMeOF multipath tests separately. Are you fine with this?
>
> Both way'
On Thu, 2018-08-23 at 06:02 +0800, Ming Lei wrote:
> On Wed, Aug 22, 2018 at 08:22:00PM +0100, Ben Hutchings wrote:
> > On Mon, 2018-08-20 at 11:04 +0200, Ricardo Ribalda Delgado wrote:
> > > Hello Ming
> > > On Mon, Aug 20, 2018 at 10:30 AM Ming Lei wrote:
> >
> > [...]
> > > > One problem found
On Wed, Aug 22, 2018 at 08:22:00PM +0100, Ben Hutchings wrote:
> On Mon, 2018-08-20 at 11:04 +0200, Ricardo Ribalda Delgado wrote:
> > Hello Ming
> > On Mon, Aug 20, 2018 at 10:30 AM Ming Lei wrote:
> [...]
> > > One problem found from your iostat log is that looks there is ~30sec
> > > idle perio
On 8/22/18 2:39 PM, Linus Torvalds wrote:
> On Wed, Aug 22, 2018 at 10:54 AM Jens Axboe wrote:
>>
>> - Set of bcache fixes and changes (Coly)
>
> Some of those bcache style fixes look questionable.
>
> Maybe we should push back on some of the checkpatch rules instead?
>
> Like having argument n
On Wed, Aug 22, 2018 at 10:54 AM Jens Axboe wrote:
>
> - Set of bcache fixes and changes (Coly)
Some of those bcache style fixes look questionable.
Maybe we should push back on some of the checkpatch rules instead?
Like having argument names in declarations - sometimes descriptive
names can be
On 08/22/18 21:46, Jens Axboe wrote:
On 8/22/18 1:37 PM, Holger Hoffstätte wrote:
On 08/22/18 21:17, Jens Axboe wrote:
So the obvious suspect is the new return of UINT_MAX from get_limit() to
__wbt_wait(). I first suspected that I mispatched something, but it's all
like in mainline or your tree
On 8/22/18 1:37 PM, Holger Hoffstätte wrote:
> On 08/22/18 21:17, Jens Axboe wrote:
>>> So the obvious suspect is the new return of UINT_MAX from get_limit() to
>>> __wbt_wait(). I first suspected that I mispatched something, but it's all
>>> like in mainline or your tree. Even the recently moved-a
On 08/22/18 21:17, Jens Axboe wrote:
So the obvious suspect is the new return of UINT_MAX from get_limit() to
__wbt_wait(). I first suspected that I mispatched something, but it's all
like in mainline or your tree. Even the recently moved-around atomic loop
inside rq_wait_inc_below() is 1:1 the s
On Mon, 2018-08-20 at 11:04 +0200, Ricardo Ribalda Delgado wrote:
> Hello Ming
> On Mon, Aug 20, 2018 at 10:30 AM Ming Lei wrote:
[...]
> > One problem found from your iostat log is that looks there is ~30sec
> > idle period between IO activities when blk-mq is enabled.
>
> During all the test th
On 8/22/18 1:12 PM, Holger Hoffstätte wrote:
> On 08/22/18 19:28, Jens Axboe wrote:
>> On 8/22/18 8:27 AM, Jens Axboe wrote:
>>> On 8/22/18 6:54 AM, Holger Hoffstätte wrote:
On 08/22/18 06:10, Jens Axboe wrote:
> [...]
> If you have time, please look at the 3 patches I posted earlier t
On 08/22/18 19:28, Jens Axboe wrote:
On 8/22/18 8:27 AM, Jens Axboe wrote:
On 8/22/18 6:54 AM, Holger Hoffstätte wrote:
On 08/22/18 06:10, Jens Axboe wrote:
[...]
If you have time, please look at the 3 patches I posted earlier today.
Those are for mainline, so should be OK :-)
I'm just playi
On 8/22/18 12:07 PM, Coly Li wrote:
> On 2018/8/23 2:02 AM, Coly Li wrote:
>> From: Shan Hai
>>
>> The writeback thread would exit with a lock held when the cache device is
>> detached via sysfs interface, fix it by releasing the held lock before
>> exiting
>> the while-loop.
>>
>> Fixes: fadd94e
On 2018/8/23 2:02 AM, Coly Li wrote:
> From: Shan Hai
>
> The writeback thread would exit with a lock held when the cache device is
> detached via sysfs interface, fix it by releasing the held lock before exiting
> the while-loop.
>
> Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when
From: Shan Hai
The writeback thread would exit with a lock held when the cache device is
detached via sysfs interface, fix it by releasing the held lock before exiting
the while-loop.
Fixes: fadd94e05c02 (bcache: quit dc->writeback_thread when
BCACHE_DEV_DETACHING is set)
Signed-off-by: Shan Ha
)
- blk-mq hardware queue count update fix (Jianchao)
- Various little fixes
Please pull!
git://git.kernel.dk/linux-block.git tags/for-4.19/post-20180822
Chaitanya Kulkarni (1):
block: remove duplicate initialization
From: Shan Hai
The writeback thread would exit with a lock held when the cache device is
detached via sysfs interface, fix it by releasing the held lock before exiting
the while-loop.
Signed-off-by: Shan Hai
Signed-off-by: Coly Li
Tested-by: Shenghui Wang
Cc: sta...@vger.kernel.org #4.17+
---
On 8/22/18 10:23 AM, Mikulas Patocka wrote:
> It is possible to call fsync on a read-only handle (for example, fsck.ext2
> does it when doing read-only check), and this call results in kernel
> warning. This bug was introduced by the commit 721c7fc701c7 "block: fail
> op_is_write() requests to r
It is possible to call fsync on a read-only handle (for example, fsck.ext2
does it when doing read-only check), and this call results in kernel
warning. This bug was introduced by the commit 721c7fc701c7 "block: fail
op_is_write() requests to read-only partitions".
Signed-off-by: Mikulas Patock
On Mon, Aug 20, 2018 at 01:54:20PM -0700, Sagi Grimberg wrote:
> nvme-rdma attempts to map queues based on irq vector affinity.
> However, for some devices, completion vector irq affinity is
> configurable by the user which can break the existing assumption
> that irq vectors are optimally arranged
On Wed 22-08-18 18:50:53, Ming Lei wrote:
> On Wed, Aug 22, 2018 at 12:33:05PM +0200, Jan Kara wrote:
> > On Wed 22-08-18 10:02:49, Martin Wilck wrote:
> > > On Mon, 2018-07-30 at 20:37 +0800, Ming Lei wrote:
> > > > On Wed, Jul 25, 2018 at 11:15:09PM +0200, Martin Wilck wrote:
> > > > >
> > > > >
On Wed, Aug 22, 2018 at 12:33:05PM +0200, Jan Kara wrote:
> On Wed 22-08-18 10:02:49, Martin Wilck wrote:
> > On Mon, 2018-07-30 at 20:37 +0800, Ming Lei wrote:
> > > On Wed, Jul 25, 2018 at 11:15:09PM +0200, Martin Wilck wrote:
> > > >
> > > > +/**
> > > > + * bio_iov_iter_get_pages - pin user or
On Wed 22-08-18 10:02:49, Martin Wilck wrote:
> On Mon, 2018-07-30 at 20:37 +0800, Ming Lei wrote:
> > On Wed, Jul 25, 2018 at 11:15:09PM +0200, Martin Wilck wrote:
> > >
> > > +/**
> > > + * bio_iov_iter_get_pages - pin user or kernel pages and add them
> > > to a bio
> > > + * @bio: bio to add p
On Wed, Aug 22, 2018 at 09:06:40AM +0300, Jarkko Nikula wrote:
> On 08/21/2018 04:57 PM, Ming Lei wrote:
> > On Tue, Aug 21, 2018 at 04:45:41PM +0300, Jarkko Nikula wrote:
> > > On 08/21/2018 04:03 PM, Adrian Hunter wrote:
> > > > On 21/08/18 15:37, Jarkko Nikula wrote:
> > > > > Hi
> > > > >
> >
On Mon, 2018-07-30 at 20:37 +0800, Ming Lei wrote:
> On Wed, Jul 25, 2018 at 11:15:09PM +0200, Martin Wilck wrote:
> >
> > +/**
> > + * bio_iov_iter_get_pages - pin user or kernel pages and add them
> > to a bio
> > + * @bio: bio to add pages to
> > + * @iter: iov iterator describing the region to
Hi Coly,
On 2018年08月22日 15:29, Coly Li wrote:
Hi Shan,
On 2018/8/22 3:00 PM, Shan Hai wrote:
The writeback thread would exit with a lock held when the cache device is
detached via sysfs interface, fix it by releasing the held lock before exiting
the thread.
I will change "the thread" to "the
Hi Shan,
On 2018/8/22 3:00 PM, Shan Hai wrote:
> The writeback thread would exit with a lock held when the cache device is
> detached via sysfs interface, fix it by releasing the held lock before exiting
> the thread.
I will change "the thread" to "the while-loop" when I apply this patch.
>
> S
The writeback thread would exit with a lock held when the cache device is
detached via sysfs interface, fix it by releasing the held lock before exiting
the thread.
Signed-off-by: Shan Hai
---
drivers/md/bcache/writeback.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dr
29 matches
Mail list logo
